All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 1/1] gpio: pca953x: enable driver on Intel Edison
@ 2016-06-14 22:57 Andy Shevchenko
  2016-06-15  7:08 ` Linus Walleij
  2016-06-15  7:11 ` Linus Walleij
  0 siblings, 2 replies; 4+ messages in thread
From: Andy Shevchenko @ 2016-06-14 22:57 UTC (permalink / raw)
  To: Linus Walleij, linux-gpio; +Cc: Andy Shevchenko

Intel Edison board has 4 GPIO expanders PCA9555a connected to I2C bus. Add an
ID to support them.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-pca953x.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 21b21cd..8b630a4 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -67,6 +67,8 @@ static const struct i2c_device_id pca953x_id[] = {
 	{ "pca9575", 16 | PCA957X_TYPE | PCA_INT, },
 	{ "pca9698", 40 | PCA953X_TYPE, },
 
+	{ "pcal9555a", 16 | PCA953X_TYPE | PCA_INT | PCA_PCAL, },
+
 	{ "max7310", 8  | PCA953X_TYPE, },
 	{ "max7312", 16 | PCA953X_TYPE | PCA_INT, },
 	{ "max7313", 16 | PCA953X_TYPE | PCA_INT, },
-- 
2.8.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 1/1] gpio: pca953x: enable driver on Intel Edison
  2016-06-14 22:57 [PATCH v1 1/1] gpio: pca953x: enable driver on Intel Edison Andy Shevchenko
@ 2016-06-15  7:08 ` Linus Walleij
  2016-06-15  7:11 ` Linus Walleij
  1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2016-06-15  7:08 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: linux-gpio@vger.kernel.org

On Wed, Jun 15, 2016 at 12:57 AM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> Intel Edison board has 4 GPIO expanders PCA9555a connected to I2C bus. Add an
> ID to support them.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 1/1] gpio: pca953x: enable driver on Intel Edison
  2016-06-14 22:57 [PATCH v1 1/1] gpio: pca953x: enable driver on Intel Edison Andy Shevchenko
  2016-06-15  7:08 ` Linus Walleij
@ 2016-06-15  7:11 ` Linus Walleij
  2016-06-15  9:19   ` Andy Shevchenko
  1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2016-06-15  7:11 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: linux-gpio@vger.kernel.org

On Wed, Jun 15, 2016 at 12:57 AM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> Intel Edison board has 4 GPIO expanders PCA9555a connected to I2C bus. Add an
> ID to support them.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

BTW Andy, if you have PCA95x hardware you're playing with, any chance
you could implement .get_direction() for this driver?

I'd really like for that to be supported on all major hardware.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 1/1] gpio: pca953x: enable driver on Intel Edison
  2016-06-15  7:11 ` Linus Walleij
@ 2016-06-15  9:19   ` Andy Shevchenko
  0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2016-06-15  9:19 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-gpio@vger.kernel.org

On Wed, 2016-06-15 at 09:11 +0200, Linus Walleij wrote:
> On Wed, Jun 15, 2016 at 12:57 AM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> 
> > Intel Edison board has 4 GPIO expanders PCA9555a connected to I2C
> > bus. Add an
> > ID to support them.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> BTW Andy, if you have PCA95x hardware you're playing with, any chance
> you could implement .get_direction() for this driver?
> 
> I'd really like for that to be supported on all major hardware.

I can put it to my TODO list with low priority.

If someone has more time and eagerness I would be okay to review and-or
test it.

-- 

Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-06-15  9:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-14 22:57 [PATCH v1 1/1] gpio: pca953x: enable driver on Intel Edison Andy Shevchenko
2016-06-15  7:08 ` Linus Walleij
2016-06-15  7:11 ` Linus Walleij
2016-06-15  9:19   ` Andy Shevchenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.