Re: [PATCH] matroxfb: add Matrox MGA-G200eW board support

From: Thomas Zimmermann <tzimmermann@suse.de>
To: Rich Felker <dalias@libc.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-fbdev@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] matroxfb: add Matrox MGA-G200eW board support
Date: Mon, 27 Jan 2020 07:36:07 +0000	[thread overview]
Message-ID: <1466259e-efe7-df52-c05b-80042628d577@suse.de> (raw)
In-Reply-To: <20200125195506.GA16638@brightrain.aerifal.cx>

[-- Attachment #1.1: Type: text/plain, Size: 2288 bytes --]

Hi

Am 25.01.20 um 20:55 schrieb Rich Felker:
> Signed-off-by: Rich Felker <dalias@libc.org>
> --
> I've had this lying around a while and figure I should send it
> upsteam; it's needed to support the onboard video on my Spectre-free
> Atom S1260 server board.

This HW is supported by mgag200, which is maintained. Can't you use that?

Best regards
Thomas

> 
> ---
>  drivers/video/fbdev/matrox/matroxfb_base.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c
> index 1a555f70923a..ff344313860c 100644
> --- a/drivers/video/fbdev/matrox/matroxfb_base.c
> +++ b/drivers/video/fbdev/matrox/matroxfb_base.c
> @@ -1376,6 +1376,12 @@ static struct video_board vbG200 = {
>  	.accelID = FB_ACCEL_MATROX_MGAG200,
>  	.lowlevel = &matrox_G100
>  };
> +static struct video_board vbG200eW = {
> +	.maxvram = 0x800000,
> +	.maxdisplayable = 0x800000,
> +	.accelID = FB_ACCEL_MATROX_MGAG200,
> +	.lowlevel = &matrox_G100
> +};
>  /* from doc it looks like that accelerator can draw only to low 16MB :-( Direct accesses & displaying are OK for
>     whole 32MB */
>  static struct video_board vbG400 = {
> @@ -1494,6 +1500,13 @@ static struct board {
>  		MGA_G200,
>  		&vbG200,
>  		"MGA-G200 (PCI)"},
> +	{PCI_VENDOR_ID_MATROX,	0x0532,	0xFF,
> +		0,			0,
> +		DEVF_G200,
> +		250000,
> +		MGA_G200,
> +		&vbG200eW,
> +		"MGA-G200eW (PCI)"},
>  	{PCI_VENDOR_ID_MATROX,	PCI_DEVICE_ID_MATROX_G200_AGP,	0xFF,
>  		PCI_SS_VENDOR_ID_MATROX,	PCI_SS_ID_MATROX_GENERIC,
>  		DEVF_G200,
> @@ -2136,6 +2149,8 @@ static const struct pci_device_id matroxfb_devices[] = {
>  		PCI_ANY_ID,	PCI_ANY_ID,	0, 0, 0},
>  	{PCI_VENDOR_ID_MATROX,	PCI_DEVICE_ID_MATROX_G200_PCI,
>  		PCI_ANY_ID,	PCI_ANY_ID,	0, 0, 0},
> +	{PCI_VENDOR_ID_MATROX,	0x0532,
> +		PCI_ANY_ID,	PCI_ANY_ID,	0, 0, 0},
>  	{PCI_VENDOR_ID_MATROX,	PCI_DEVICE_ID_MATROX_G200_AGP,
>  		PCI_ANY_ID,	PCI_ANY_ID,	0, 0, 0},
>  	{PCI_VENDOR_ID_MATROX,	PCI_DEVICE_ID_MATROX_G400,
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]