From: Sinan Kaya <okaya@codeaurora.org>
To: kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org,
jcm@redhat.com, alex.williamson@redhat.com,
eric.auger@redhat.com
Cc: linux-acpi@vger.kernel.org, agross@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sinan Kaya <okaya@codeaurora.org>,
Baptiste Reynal <b.reynal@virtualopensystems.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH V8 5/9] vfio: platform: add extra debug info argument to call reset
Date: Mon, 20 Jun 2016 11:51:15 -0400 [thread overview]
Message-ID: <1466437879-32182-6-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1466437879-32182-1-git-send-email-okaya@codeaurora.org>
Getting ready to bring out extra debug information to the caller
so that more verbose information can be printed when an error is
observed.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Reviewed-by: Baptiste Reynal <b.reynal@virtualopensystems.com>
---
drivers/vfio/platform/vfio_platform_common.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
index fbf4565..e7ce2c2 100644
--- a/drivers/vfio/platform/vfio_platform_common.c
+++ b/drivers/vfio/platform/vfio_platform_common.c
@@ -171,7 +171,8 @@ static void vfio_platform_regions_cleanup(struct vfio_platform_device *vdev)
kfree(vdev->regions);
}
-static int vfio_platform_call_reset(struct vfio_platform_device *vdev)
+static int vfio_platform_call_reset(struct vfio_platform_device *vdev,
+ const char **extra_dbg)
{
if (vdev->of_reset) {
dev_info(vdev->device, "reset\n");
@@ -189,7 +190,7 @@ static void vfio_platform_release(void *device_data)
mutex_lock(&driver_lock);
if (!(--vdev->refcnt)) {
- vfio_platform_call_reset(vdev);
+ vfio_platform_call_reset(vdev, NULL);
vfio_platform_regions_cleanup(vdev);
vfio_platform_irq_cleanup(vdev);
}
@@ -218,7 +219,7 @@ static int vfio_platform_open(void *device_data)
if (ret)
goto err_irq;
- vfio_platform_call_reset(vdev);
+ vfio_platform_call_reset(vdev, NULL);
}
vdev->refcnt++;
@@ -350,7 +351,7 @@ static long vfio_platform_ioctl(void *device_data,
return ret;
} else if (cmd == VFIO_DEVICE_RESET) {
- return vfio_platform_call_reset(vdev);
+ return vfio_platform_call_reset(vdev, NULL);
}
return -ENOTTY;
--
1.8.2.1
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V8 5/9] vfio: platform: add extra debug info argument to call reset
Date: Mon, 20 Jun 2016 11:51:15 -0400 [thread overview]
Message-ID: <1466437879-32182-6-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1466437879-32182-1-git-send-email-okaya@codeaurora.org>
Getting ready to bring out extra debug information to the caller
so that more verbose information can be printed when an error is
observed.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Reviewed-by: Baptiste Reynal <b.reynal@virtualopensystems.com>
---
drivers/vfio/platform/vfio_platform_common.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
index fbf4565..e7ce2c2 100644
--- a/drivers/vfio/platform/vfio_platform_common.c
+++ b/drivers/vfio/platform/vfio_platform_common.c
@@ -171,7 +171,8 @@ static void vfio_platform_regions_cleanup(struct vfio_platform_device *vdev)
kfree(vdev->regions);
}
-static int vfio_platform_call_reset(struct vfio_platform_device *vdev)
+static int vfio_platform_call_reset(struct vfio_platform_device *vdev,
+ const char **extra_dbg)
{
if (vdev->of_reset) {
dev_info(vdev->device, "reset\n");
@@ -189,7 +190,7 @@ static void vfio_platform_release(void *device_data)
mutex_lock(&driver_lock);
if (!(--vdev->refcnt)) {
- vfio_platform_call_reset(vdev);
+ vfio_platform_call_reset(vdev, NULL);
vfio_platform_regions_cleanup(vdev);
vfio_platform_irq_cleanup(vdev);
}
@@ -218,7 +219,7 @@ static int vfio_platform_open(void *device_data)
if (ret)
goto err_irq;
- vfio_platform_call_reset(vdev);
+ vfio_platform_call_reset(vdev, NULL);
}
vdev->refcnt++;
@@ -350,7 +351,7 @@ static long vfio_platform_ioctl(void *device_data,
return ret;
} else if (cmd == VFIO_DEVICE_RESET) {
- return vfio_platform_call_reset(vdev);
+ return vfio_platform_call_reset(vdev, NULL);
}
return -ENOTTY;
--
1.8.2.1
next prev parent reply other threads:[~2016-06-20 15:51 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 15:51 [PATCH V8 0/9] vfio, platform: add ACPI support Sinan Kaya
2016-06-20 15:51 ` Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 1/9] vfio: platform: rename reset function Sinan Kaya
2016-06-20 15:51 ` Sinan Kaya
2016-06-20 15:51 ` Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 2/9] vfio: platform: move reset call to a common function Sinan Kaya
2016-06-20 15:51 ` Sinan Kaya
2016-06-20 15:51 ` Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 3/9] vfio: platform: determine reset capability Sinan Kaya
2016-06-20 15:51 ` Sinan Kaya
2016-06-20 15:51 ` Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 4/9] vfio: platform: add support for ACPI probe Sinan Kaya
2016-06-20 15:51 ` Sinan Kaya
2016-06-23 18:34 ` Alex Williamson
2016-06-23 18:34 ` Alex Williamson
2016-07-13 19:36 ` Sinan Kaya
2016-07-13 19:36 ` Sinan Kaya
2016-07-13 20:09 ` Alex Williamson
2016-07-13 20:09 ` Alex Williamson
2016-07-13 21:01 ` Sinan Kaya
2016-07-13 21:01 ` Sinan Kaya
2016-06-20 15:51 ` Sinan Kaya [this message]
2016-06-20 15:51 ` [PATCH V8 5/9] vfio: platform: add extra debug info argument to call reset Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 6/9] vfio: platform: call _RST method when using ACPI Sinan Kaya
2016-06-20 15:51 ` Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 7/9] vfio, platform: make reset driver a requirement by default Sinan Kaya
2016-06-20 15:51 ` Sinan Kaya
2016-06-23 18:59 ` Alex Williamson
2016-06-23 18:59 ` Alex Williamson
2016-07-13 20:12 ` Sinan Kaya
2016-07-13 20:12 ` Sinan Kaya
2016-07-13 20:55 ` Alex Williamson
2016-07-13 20:55 ` Alex Williamson
2016-07-13 21:34 ` Sinan Kaya
2016-07-13 21:34 ` Sinan Kaya
2016-07-13 20:48 ` Sinan Kaya
2016-07-13 20:48 ` Sinan Kaya
2016-07-13 21:18 ` Alex Williamson
2016-07-13 21:18 ` Alex Williamson
2016-06-20 15:51 ` [PATCH V8 8/9] vfio: platform: check reset call return code during open Sinan Kaya
2016-06-20 15:51 ` Sinan Kaya
2016-06-20 15:51 ` [PATCH V8 9/9] vfio: platform: check reset call return code during release Sinan Kaya
2016-06-20 15:51 ` Sinan Kaya
2016-06-23 7:58 ` [PATCH V8 0/9] vfio, platform: add ACPI support Auger Eric
2016-06-23 7:58 ` Auger Eric
2016-06-23 15:03 ` Sinan Kaya
2016-06-23 15:03 ` Sinan Kaya
2016-06-23 15:03 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466437879-32182-6-git-send-email-okaya@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=alex.williamson@redhat.com \
--cc=b.reynal@virtualopensystems.com \
--cc=cov@codeaurora.org \
--cc=eric.auger@redhat.com \
--cc=jcm@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.