All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lekensteyn <lekensteyn@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] i915: initialize CADL in opregion
Date: Thu, 28 Jun 2012 01:24:37 +0200	[thread overview]
Message-ID: <1466476.5JoFf03NtD@al> (raw)
In-Reply-To: <20120627162737.GF5326@phenom.ffwll.local>

On Wednesday 27 June 2012 18:27:37 Daniel Vetter wrote:
> On Wed, Jun 27, 2012 at 05:09:02PM +0200, Lekensteyn wrote:
> > On Wednesday 27 June 2012 17:03:02 Daniel Vetter wrote:
> > > On Tue, Jun 26, 2012 at 11:07:55PM +0200, Daniel Vetter wrote:
> > > > On Tue, Jun 26, 2012 at 02:04:00PM -0700, Jesse Barnes wrote:
> > > > > On Tue, 26 Jun 2012 00:36:24 +0200
> > > > > 
> > > > > Lekensteyn <lekensteyn@gmail.com> wrote:
> > > > > > This is rather a hack to fix brightness hotkeys on a Clevo laptop.
> > > > > > CADL is not used anywhere in the driver code at the moment, but it
> > > > > > could be used in BIOS as is the case with the Clevo laptop.
> > > > > > 
> > > > > > The Clevo B7130 requires the CADL field to contain at least the ID
> > > > > > of
> > > > > > the LCD device. If this field is empty, the ACPI methods that are
> > > > > > called
> > > > > > on pressing brightness / display switching hotkeys will not
> > > > > > trigger a
> > > > > > notification. As a result, it appears as no hotkey has been
> > > > > > pressed.
> > > > > 
> > > > > Not ideal, but definitely better than nothing.
> > > > > 
> > > > > Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > > > 
> > > > Queued for -next, thanks for the patch.
> > > 
> > > Unfortunately this results in a neat black screen on my ivb zenbook.
> > > Until
> > > I've figured out what exactly's going on, I have to drop this from -next
> > > again.
> > > -Daniel
> > 
> > Can you share your acpidump on
> > https://bugs.freedesktop.org/show_bug.cgi?id=45452 ?
> 
> Attached.
> -Daniel

Thank you, I've now written a partial analysis which is available at 
https://github.com/Lekensteyn/acpi-
stuff/blob/HEAD/dsl/Asus_Zenbook_DanielVetter/analysis.txt (note: URL is cut in 
two parts in this mail, concat them as needed).

Question: can you try disabling the asus-laptop module and try booting again 
w/ and w/o the CADL patch applied?
- Does it boot in both cases?
- Do the brightness hotkeys work?
- Can you change brightness via /sys/class/backlight?

Can you SSH in it and check the logs? Any ACPI warnings/errors or messages 
from the asus-laptop module? (or whatever asus module(s) is/are loaded)

Can you also generate dmidecode.txt? (peek in http://lekensteyn.nl/files/get-
acpi-info.sh, you do not have to run all of the commands since I already have 
your acpidump)

Thanks,
Peter

  parent reply	other threads:[~2012-06-27 23:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25 22:36 [PATCH] i915: initialize CADL in opregion Lekensteyn
2012-06-26 21:04 ` Jesse Barnes
2012-06-26 21:07   ` Daniel Vetter
2012-06-26 21:34     ` Paul Menzel
2012-06-27 15:03     ` Daniel Vetter
2012-06-27 15:09       ` Lekensteyn
     [not found]         ` <20120627162737.GF5326@phenom.ffwll.local>
2012-06-27 23:24           ` Lekensteyn [this message]
2012-06-28 11:05             ` Daniel Vetter
2012-06-28 11:22               ` Daniel Vetter
2012-06-28 11:58                 ` Lekensteyn
2012-06-28 12:38                   ` Daniel Vetter
2012-06-29 14:48               ` Daniel Vetter
2012-09-13 21:17   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466476.5JoFf03NtD@al \
    --to=lekensteyn@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.