From: Joe Perches <joe@perches.com>
To: Arnd Bergmann <arnd@arndb.de>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: wd7000: print sector number as 64-bit
Date: Tue, 21 Jun 2016 02:14:58 -0700 [thread overview]
Message-ID: <1466500498.26558.12.camel@perches.com> (raw)
In-Reply-To: <20160621090249.774301-1-arnd@arndb.de>
On Tue, 2016-06-21 at 11:02 +0200, Arnd Bergmann wrote:
> Enabling format checking in dprintk() shows that wd7000_biosparam
> uses an incorrect format string for sector_t:
trivia:
> diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c
[]
> @@ -192,7 +192,7 @@
> #ifdef WD7000_DEBUG
> #define dprintk printk
> #else
> -#define dprintk(format,args...)
> +#define dprintk no_printk
> #endif
It'd be nicer if both defines were the same form
#ifdef WD7000_DEBUG
#define dprintk printk
#else
#define dprintk no_printk
#endif
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Arnd Bergmann <arnd@arndb.de>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: wd7000: print sector number as 64-bit
Date: Tue, 21 Jun 2016 02:14:58 -0700 [thread overview]
Message-ID: <1466500498.26558.12.camel@perches.com> (raw)
In-Reply-To: <20160621090249.774301-1-arnd@arndb.de>
On Tue, 2016-06-21 at 11:02 +0200, Arnd Bergmann wrote:
> Enabling format checking in dprintk() shows that wd7000_biosparam
> uses an incorrect format string for sector_t:
trivia:
> diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c
[]
> @@ -192,7 +192,7 @@
> #ifdef WD7000_DEBUG
> #define dprintk printk
> #else
> -#define dprintk(format,args...)
> +#define dprintk no_printk
> #endif
It'd be nicer if both defines were the same form
#ifdef WD7000_DEBUG
#define dprintk printk
#else
#define dprintk no_printk
#endif
next prev parent reply other threads:[~2016-06-21 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 9:02 [PATCH v2] scsi: wd7000: print sector number as 64-bit Arnd Bergmann
2016-06-21 9:14 ` Joe Perches [this message]
2016-06-21 9:14 ` Joe Perches
2016-06-22 2:22 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466500498.26558.12.camel@perches.com \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.