From: mcgrof@kernel.org (Luis R. Rodriguez)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH v3 4/8] coccicheck: replace --very-quiet with --quit when debugging
Date: Tue, 21 Jun 2016 12:21:29 -0700 [thread overview]
Message-ID: <1466536893-23355-5-git-send-email-mcgrof@kernel.org> (raw)
In-Reply-To: <1466536893-23355-1-git-send-email-mcgrof@kernel.org>
When debugging (using --profile or --show-trying) you want to
avoid supressing output, use --quiet instead. While at it, extend
documentation for SPFLAGS use.
For instance one can use:
$ export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci
$ make coccicheck DEBUG_FILE="poo.err" MODE=report SPFLAGS="--profile --show-trying" M=./drivers/mfd/arizona-irq.c
v3: rebased, resolve conflicts
v2: use egrep instead of the *"=--option"* check, this doesn't work for
disjunctions.
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
scripts/coccicheck | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index a77f0f246405..998d764636e0 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -32,6 +32,29 @@ fi
FLAGS="--very-quiet"
+# You can use SPFLAGS to append extra arguments to coccicheck or override any
+# heuristics done in this file as Coccinelle accepts the last options when
+# options conflict.
+#
+# A good example for use of SPFLAGS is if you want to debug your cocci script,
+# you can for instance use the following:
+#
+# $ export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci
+# $ make coccicheck MODE=report DEBUG_FILE="all.err" SPFLAGS="--profile --show-trying" M=./drivers/mfd/arizona-irq.c
+#
+# "--show-trying" should show you what rule is being processed as it goes to
+# stdout, you do not need a debug file for that. The profile output will be
+# be sent to stdout, if you provide a DEBUG_FILE the profiling data can be
+# inspected there.
+#
+# --profile will not output if --very-quiet is used, so avoid it.
+echo $SPFLAGS | egrep -e "--profile|--show-trying" 2>&1 > /dev/null
+if [ $? -eq 0 ]; then
+ FLAGS="--quiet"
+else
+ FLAGS="--very-quiet"
+fi
+
# spatch only allows include directories with the syntax "-I include"
# while gcc also allows "-Iinclude" and "-include include"
COCCIINCLUDE=${LINUXINCLUDE//-I/-I }
--
2.8.2
WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Julia.Lawall@lip6.fr, Gilles.Muller@lip6.fr,
nicolas.palix@imag.fr, mmarek@suse.com
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
gregkh@linuxfoundation.org, markivx@codeaurora.org,
stephen.boyd@linaro.org, zohar@linux.vnet.ibm.com,
broonie@kernel.org, ming.lei@canonical.com, tiwai@suse.de,
johannes@sipsolutions.net, chunkeey@googlemail.com,
hauke@hauke-m.de, jwboyer@fedoraproject.org,
dmitry.torokhov@gmail.com, dwmw2@infradead.org, jslaby@suse.com,
torvalds@linux-foundation.org, deepa.kernel@gmail.com,
cocci@systeme.lip6.fr, "Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH v3 4/8] coccicheck: replace --very-quiet with --quit when debugging
Date: Tue, 21 Jun 2016 12:21:29 -0700 [thread overview]
Message-ID: <1466536893-23355-5-git-send-email-mcgrof@kernel.org> (raw)
In-Reply-To: <1466536893-23355-1-git-send-email-mcgrof@kernel.org>
When debugging (using --profile or --show-trying) you want to
avoid supressing output, use --quiet instead. While at it, extend
documentation for SPFLAGS use.
For instance one can use:
$ export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci
$ make coccicheck DEBUG_FILE="poo.err" MODE=report SPFLAGS="--profile --show-trying" M=./drivers/mfd/arizona-irq.c
v3: rebased, resolve conflicts
v2: use egrep instead of the *"=--option"* check, this doesn't work for
disjunctions.
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
scripts/coccicheck | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index a77f0f246405..998d764636e0 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -32,6 +32,29 @@ fi
FLAGS="--very-quiet"
+# You can use SPFLAGS to append extra arguments to coccicheck or override any
+# heuristics done in this file as Coccinelle accepts the last options when
+# options conflict.
+#
+# A good example for use of SPFLAGS is if you want to debug your cocci script,
+# you can for instance use the following:
+#
+# $ export COCCI=scripts/coccinelle/misc/irqf_oneshot.cocci
+# $ make coccicheck MODE=report DEBUG_FILE="all.err" SPFLAGS="--profile --show-trying" M=./drivers/mfd/arizona-irq.c
+#
+# "--show-trying" should show you what rule is being processed as it goes to
+# stdout, you do not need a debug file for that. The profile output will be
+# be sent to stdout, if you provide a DEBUG_FILE the profiling data can be
+# inspected there.
+#
+# --profile will not output if --very-quiet is used, so avoid it.
+echo $SPFLAGS | egrep -e "--profile|--show-trying" 2>&1 > /dev/null
+if [ $? -eq 0 ]; then
+ FLAGS="--quiet"
+else
+ FLAGS="--very-quiet"
+fi
+
# spatch only allows include directories with the syntax "-I include"
# while gcc also allows "-Iinclude" and "-include include"
COCCIINCLUDE=${LINUXINCLUDE//-I/-I }
--
2.8.2
next prev parent reply other threads:[~2016-06-21 19:21 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 19:21 [Cocci] [PATCH v3 0/8] coccicheck: modernize Luis R. Rodriguez
2016-06-21 19:21 ` Luis R. Rodriguez
2016-06-21 19:21 ` [Cocci] [PATCH v3 1/8] coccicheck: move spatch binary check up Luis R. Rodriguez
2016-06-21 19:21 ` Luis R. Rodriguez
2016-06-21 20:34 ` [Cocci] " Nicolas Palix (LIG)
2016-06-21 20:34 ` Nicolas Palix (LIG)
2016-06-21 19:21 ` [Cocci] [PATCH v3 2/8] coccicheck: make SPFLAGS more useful Luis R. Rodriguez
2016-06-21 19:21 ` Luis R. Rodriguez
2016-06-22 20:39 ` [Cocci] " Nicolas Palix (LIG)
2016-06-22 20:39 ` Nicolas Palix (LIG)
2016-06-21 19:21 ` [Cocci] [PATCH v3 3/8] coccicheck: enable parmap support Luis R. Rodriguez
2016-06-21 19:21 ` Luis R. Rodriguez
2016-06-21 20:17 ` [Cocci] " Julia Lawall
2016-06-21 20:17 ` Julia Lawall
2016-06-21 20:39 ` [Cocci] " Luis R. Rodriguez
2016-06-21 20:39 ` Luis R. Rodriguez
2016-06-21 20:43 ` [Cocci] " Julia Lawall
2016-06-21 20:43 ` Julia Lawall
2016-06-21 20:54 ` [Cocci] " Luis R. Rodriguez
2016-06-21 20:54 ` Luis R. Rodriguez
2016-06-21 21:10 ` [Cocci] " Julia Lawall
2016-06-21 21:10 ` Julia Lawall
2016-06-21 21:27 ` [Cocci] " Luis R. Rodriguez
2016-06-21 21:27 ` Luis R. Rodriguez
2016-06-21 21:31 ` [Cocci] " Julia Lawall
2016-06-21 21:31 ` Julia Lawall
2016-06-21 21:00 ` [Cocci] " Nicolas Palix (LIG)
2016-06-21 21:00 ` Nicolas Palix (LIG)
2016-06-21 21:28 ` [Cocci] " Luis R. Rodriguez
2016-06-21 21:28 ` Luis R. Rodriguez
2016-06-21 21:32 ` [Cocci] " Julia Lawall
2016-06-21 21:32 ` Julia Lawall
2016-06-21 21:39 ` [Cocci] " Luis R. Rodriguez
2016-06-21 21:39 ` Luis R. Rodriguez
2016-06-21 21:44 ` [Cocci] " Julia Lawall
2016-06-21 21:44 ` Julia Lawall
2016-06-21 22:14 ` [Cocci] " Luis R. Rodriguez
2016-06-21 22:14 ` Luis R. Rodriguez
2016-06-22 5:25 ` [Cocci] " Julia Lawall
2016-06-22 5:25 ` Julia Lawall
2016-06-22 15:10 ` [Cocci] " Luis R. Rodriguez
2016-06-22 15:10 ` Luis R. Rodriguez
2016-06-22 19:47 ` Julia Lawall
2016-06-22 19:47 ` Julia Lawall
2016-06-21 19:21 ` Luis R. Rodriguez [this message]
2016-06-21 19:21 ` [PATCH v3 4/8] coccicheck: replace --very-quiet with --quit when debugging Luis R. Rodriguez
2016-06-21 19:21 ` [Cocci] [PATCH v3 5/8] scripts: add Linux .cocciconfig for coccinelle Luis R. Rodriguez
2016-06-21 19:21 ` Luis R. Rodriguez
2016-06-21 20:29 ` [Cocci] " Julia Lawall
2016-06-21 20:29 ` Julia Lawall
2016-06-21 23:43 ` [Cocci] " Luis R. Rodriguez
2016-06-21 23:43 ` Luis R. Rodriguez
2016-06-22 5:53 ` [Cocci] " Julia Lawall
2016-06-22 5:53 ` Julia Lawall
2016-06-21 21:07 ` [Cocci] " Nicolas Palix (LIG)
2016-06-21 21:07 ` Nicolas Palix (LIG)
2016-06-21 21:12 ` [Cocci] " Julia Lawall
2016-06-21 21:12 ` Julia Lawall
2016-06-21 23:38 ` [Cocci] " Luis R. Rodriguez
2016-06-21 23:38 ` Luis R. Rodriguez
2016-06-22 5:51 ` [Cocci] " Julia Lawall
2016-06-22 5:51 ` Julia Lawall
2016-06-21 19:21 ` [Cocci] [PATCH v3 6/8] coccicheck: add support for requring a coccinelle version Luis R. Rodriguez
2016-06-21 19:21 ` Luis R. Rodriguez
2016-06-21 21:11 ` [Cocci] " Nicolas Palix (LIG)
2016-06-21 21:11 ` Nicolas Palix (LIG)
2016-06-21 19:21 ` [Cocci] [PATCH v3 7/8] coccicheck: refer to coccicheck bottest wiki for documentation Luis R. Rodriguez
2016-06-21 19:21 ` Luis R. Rodriguez
2016-06-21 21:14 ` [Cocci] " Nicolas Palix (LIG)
2016-06-21 21:14 ` Nicolas Palix (LIG)
2016-06-21 21:18 ` [Cocci] " Julia Lawall
2016-06-21 21:18 ` Julia Lawall
2016-06-22 0:07 ` [Cocci] " Luis R. Rodriguez
2016-06-22 0:07 ` Luis R. Rodriguez
2016-06-22 5:56 ` [Cocci] " Julia Lawall
2016-06-22 5:56 ` Julia Lawall
2016-06-21 19:21 ` [Cocci] [PATCH v3 8/8] scripts/coccinelle: require coccinelle >= 1.0.4 on device_node_continue.cocci Luis R. Rodriguez
2016-06-21 19:21 ` Luis R. Rodriguez
2016-06-21 20:36 ` [Cocci] " Julia Lawall
2016-06-21 20:36 ` Julia Lawall
2016-06-21 21:17 ` [Cocci] " Nicolas Palix (LIG)
2016-06-21 21:17 ` Nicolas Palix (LIG)
2016-06-21 20:13 ` [Cocci] [PATCH v3 0/8] coccicheck: modernize Julia Lawall
2016-06-21 20:13 ` Julia Lawall
2016-06-21 20:51 ` [Cocci] " Luis R. Rodriguez
2016-06-21 20:51 ` Luis R. Rodriguez
2016-06-21 21:02 ` Julia Lawall
2016-06-21 21:02 ` Julia Lawall
2016-06-21 21:21 ` Luis R. Rodriguez
2016-06-21 21:21 ` Luis R. Rodriguez
2016-06-21 21:30 ` Julia Lawall
2016-06-21 21:30 ` Julia Lawall
2016-06-21 21:34 ` Luis R. Rodriguez
2016-06-21 21:34 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466536893-23355-5-git-send-email-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.