[meta-fsl-arm][RFC PATCH] libimxvpuapi: use libdir from cross environment

[meta-fsl-arm][RFC PATCH] libimxvpuapi: use libdir from cross environment

[Max Krummenacher]

Pass $libdir to 'waf configure' to prevent using the build hosts libdir.

Fixes:
WARNING: libimxvpuapi-0.10.2-r0 do_package: QA Issue: libimxvpuapi: Files/directories were installed but not shipped in any package:
  /usr/lib64/libimxvpuapi.so
  /usr/lib64/libimxvpuapi.so.0
  /usr/lib64/libimxvpuapi.so.0.10.2
  /usr/lib64/pkgconfig
  /usr/lib64/pkgconfig/libimxvpuapi.pc

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
 recipes-multimedia/libimxvpuapi/libimxvpuapi_0.10.2.bb | 2 ++
 1 file changed, 2 insertions(+)

Hi

I'm seeing the above warning when building libimxvpuapi (both in master and
jethro) on an x86-64 build host. Looks like the recipe is picking up the lib
installation path from the build host and not from the build targets setting.

Is someone else seeing this? While the patch fixes it I'm a bit concerned
I'm doing something wrong because no one else reported this.

Regards
Max

diff --git a/recipes-multimedia/libimxvpuapi/libimxvpuapi_0.10.2.bb b/recipes-multimedia/libimxvpuapi/libimxvpuapi_0.10.2.bb
index bd30b12..26d46d5 100644
--- a/recipes-multimedia/libimxvpuapi/libimxvpuapi_0.10.2.bb
+++ b/recipes-multimedia/libimxvpuapi/libimxvpuapi_0.10.2.bb
@@ -14,3 +14,5 @@ S = "${WORKDIR}/git"
 inherit waf pkgconfig
 
 COMPATIBLE_MACHINE = "(mx6q|mx6dl)"
+
+EXTRA_OECONF = "--libdir=${libdir}"
-- 
2.6.6

Re: [meta-fsl-arm][RFC PATCH] libimxvpuapi: use libdir from cross environment

[Otavio Salvador]

On Thu, Jun 23, 2016 at 7:52 PM, Max Krummenacher <max.oss.09@gmail.com> wrote:
> Pass $libdir to 'waf configure' to prevent using the build hosts libdir.
>
> Fixes:
> WARNING: libimxvpuapi-0.10.2-r0 do_package: QA Issue: libimxvpuapi: Files/directories were installed but not shipped in any package:
>   /usr/lib64/libimxvpuapi.so
>   /usr/lib64/libimxvpuapi.so.0
>   /usr/lib64/libimxvpuapi.so.0.10.2
>   /usr/lib64/pkgconfig
>   /usr/lib64/pkgconfig/libimxvpuapi.pc
>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

I agree with the fix however I think this ought to be done on the waf class, no?



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm][RFC PATCH] libimxvpuapi: use libdir from cross environment

[Max Krummenacher]

Hi Otavio

2016-06-24 16:49 GMT+02:00 Otavio Salvador <otavio.salvador@ossystems.com.br>:
> On Thu, Jun 23, 2016 at 7:52 PM, Max Krummenacher <max.oss.09@gmail.com> wrote:
>> Pass $libdir to 'waf configure' to prevent using the build hosts libdir.
>>
>> Fixes:
>> WARNING: libimxvpuapi-0.10.2-r0 do_package: QA Issue: libimxvpuapi: Files/directories were installed but not shipped in any package:
>>   /usr/lib64/libimxvpuapi.so
>>   /usr/lib64/libimxvpuapi.so.0
>>   /usr/lib64/libimxvpuapi.so.0.10.2
>>   /usr/lib64/pkgconfig
>>   /usr/lib64/pkgconfig/libimxvpuapi.pc
>>
>> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
>
> I agree with the fix however I think this ought to be done on the waf class, no?

I'm unsure.
My understanding is that if the wscript file uses
<var>.load('gnu_dirs') then waf evaluates the --libdir <dir> parameter
given.

If that is true then one should not move the directory configuration
to the waf class, as each project may or may not have the
load('gnu_dirs')

https://github.com/Freescale/libimxvpuapi/blob/master/wscript#L61

It looks that samba also uses waf and the waf-samba.bbclass is
actually doing what you propose:
http://cgit.openembedded.org/meta-openembedded/tree/meta-networking/classes/waf-samba.bbclass

I'll check some more and report back.

Max

Re: [meta-fsl-arm][RFC PATCH] libimxvpuapi: use libdir from cross environment

[Max Krummenacher]

Hi Otavio

Am Freitag, den 24.06.2016, 11:49 -0300 schrieb Otavio Salvador:
> On Thu, Jun 23, 2016 at 7:52 PM, Max Krummenacher <
> max.oss.09@gmail.com> wrote:
> > Pass $libdir to 'waf configure' to prevent using the build hosts
> > libdir.
> > 
> > Fixes:
> > WARNING: libimxvpuapi-0.10.2-r0 do_package: QA Issue: libimxvpuapi:
> > Files/directories were installed but not shipped in any package:
> >   /usr/lib64/libimxvpuapi.so
> >   /usr/lib64/libimxvpuapi.so.0
> >   /usr/lib64/libimxvpuapi.so.0.10.2
> >   /usr/lib64/pkgconfig
> >   /usr/lib64/pkgconfig/libimxvpuapi.pc
> > 
> > Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> 
> I agree with the fix however I think this ought to be done on the waf
> class, no?

I tried it but this is causing build errors with other packages.

Adding --libdir=${libdir} to waf.bbclass fixes the issue with
 libimxvpuapi, but breaks eglinfo-x11 and glcompbench.

(libimxvpuapi, glmark2, gstreamer1.0-plugins-imx succeeded)

ERROR: Logfile of failure stored in: ../glcompbench/2012.08
-0/temp/log.do_configure.20606
Log data follows:
| DEBUG: Executing python function sysroot_cleansstate
| DEBUG: Python function sysroot_cleansstate finished
| DEBUG: Executing shell function do_configure
| waf [commands] [options]|
| Main commands (example: ./waf build -j4)
|   build    : executes the build
|   clean    : cleans the project
|   configure: configures the project
|   dist     :
|   distcheck: checks if the project compiles (tarball from 'dist')
|   distclean: removes the build directory
|   install  : installs the targets on the system
|   list     : lists the targets to execute
|   step     : executes tasks in a step-by-step fashion, for debugging
|   uninstall: removes the targets installed
|   update   : updates the plugins from the *waflib/extras* directory
|
| waf: error: no such option: --libdir

So a fix in waf.bbclass is not possible because --libdir is only
allowed if a package's wscript file is set up for it.

Max

> 
>