From: Joe Perches <joe@perches.com>
To: Anton Blanchard <anton@ozlabs.org>,
akpm@linux-foundation.org, oleg@redhat.com, hannes@cmpxchg.org,
mingo@kernel.org, fweisbec@gmail.com, jkosina@suse.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: workingset: printk missing log level, use pr_info()
Date: Sun, 26 Jun 2016 21:01:30 -0700 [thread overview]
Message-ID: <1467000090.1847.81.camel@perches.com> (raw)
In-Reply-To: <1466982072-29836-2-git-send-email-anton@ozlabs.org>
On Mon, 2016-06-27 at 09:01 +1000, Anton Blanchard wrote:
> commit 612e44939c3c ("mm: workingset: eviction buckets for bigmem/lowbit
> machines") added a printk without a log level. Quieten it by using
> pr_info().
[]
> diff --git a/mm/workingset.c b/mm/workingset.c
[]
> @@ -491,7 +491,7 @@ static int __init workingset_init(void)
> max_order = fls_long(totalram_pages - 1);
> if (max_order > timestamp_bits)
> bucket_order = max_order - timestamp_bits;
> - printk("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
> + pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
> timestamp_bits, max_order, bucket_order);
Because it's possible to have more printks added,
perhaps it's better to add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before any #include and remove the "workingset: "
prefix here.
next prev parent reply other threads:[~2016-06-27 4:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-26 23:01 [PATCH 1/2] exit: Quieten greatest stack depth printk Anton Blanchard
2016-06-26 23:01 ` [PATCH 2/2] mm: workingset: printk missing log level, use pr_info() Anton Blanchard
2016-06-27 4:01 ` Joe Perches [this message]
2016-07-06 13:57 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467000090.1847.81.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=anton@ozlabs.org \
--cc=fweisbec@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=jkosina@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.