All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ganesh Mahendran <opensource.ganesh@gmail.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, minchan@kernel.org, ngupta@vflare.org,
	sergey.senozhatsky.work@gmail.com, rostedt@goodmis.org,
	mingo@redhat.com, Ganesh Mahendran <opensource.ganesh@gmail.com>
Subject: [PATCH v2 3/8] mm/zsmalloc: take obj index back from find_alloced_obj
Date: Mon,  4 Jul 2016 14:49:54 +0800	[thread overview]
Message-ID: <1467614999-4326-3-git-send-email-opensource.ganesh@gmail.com> (raw)
In-Reply-To: <1467614999-4326-1-git-send-email-opensource.ganesh@gmail.com>

the obj index value should be updated after return from
find_alloced_obj() to avoid CPU buring caused by unnecessary
object scanning.

Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
----
v2:
  - update commit description

Hi, Minchan:
find_alloced_obj() already has the argument which use the obj_idx
name. So I use index as the local variable name in this function.
Is this OK?
---
 mm/zsmalloc.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 8915a1d..92b043c 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1744,10 +1744,11 @@ static void zs_object_copy(struct size_class *class, unsigned long dst,
  * return handle.
  */
 static unsigned long find_alloced_obj(struct size_class *class,
-					struct page *page, int index)
+					struct page *page, int *obj_idx)
 {
 	unsigned long head;
 	int offset = 0;
+	int index = *obj_idx;
 	unsigned long handle = 0;
 	void *addr = kmap_atomic(page);
 
@@ -1768,6 +1769,9 @@ static unsigned long find_alloced_obj(struct size_class *class,
 	}
 
 	kunmap_atomic(addr);
+
+	*obj_idx = index;
+
 	return handle;
 }
 
@@ -1793,7 +1797,7 @@ static int migrate_zspage(struct zs_pool *pool, struct size_class *class,
 	int ret = 0;
 
 	while (1) {
-		handle = find_alloced_obj(class, s_page, obj_idx);
+		handle = find_alloced_obj(class, s_page, &obj_idx);
 		if (!handle) {
 			s_page = get_next_page(s_page);
 			if (!s_page)
-- 
1.9.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Ganesh Mahendran <opensource.ganesh@gmail.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, minchan@kernel.org, ngupta@vflare.org,
	sergey.senozhatsky.work@gmail.com, rostedt@goodmis.org,
	mingo@redhat.com, Ganesh Mahendran <opensource.ganesh@gmail.com>
Subject: [PATCH v2 3/8] mm/zsmalloc: take obj index back from find_alloced_obj
Date: Mon,  4 Jul 2016 14:49:54 +0800	[thread overview]
Message-ID: <1467614999-4326-3-git-send-email-opensource.ganesh@gmail.com> (raw)
In-Reply-To: <1467614999-4326-1-git-send-email-opensource.ganesh@gmail.com>

the obj index value should be updated after return from
find_alloced_obj() to avoid CPU buring caused by unnecessary
object scanning.

Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
----
v2:
  - update commit description

Hi, Minchan:
find_alloced_obj() already has the argument which use the obj_idx
name. So I use index as the local variable name in this function.
Is this OK?
---
 mm/zsmalloc.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 8915a1d..92b043c 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1744,10 +1744,11 @@ static void zs_object_copy(struct size_class *class, unsigned long dst,
  * return handle.
  */
 static unsigned long find_alloced_obj(struct size_class *class,
-					struct page *page, int index)
+					struct page *page, int *obj_idx)
 {
 	unsigned long head;
 	int offset = 0;
+	int index = *obj_idx;
 	unsigned long handle = 0;
 	void *addr = kmap_atomic(page);
 
@@ -1768,6 +1769,9 @@ static unsigned long find_alloced_obj(struct size_class *class,
 	}
 
 	kunmap_atomic(addr);
+
+	*obj_idx = index;
+
 	return handle;
 }
 
@@ -1793,7 +1797,7 @@ static int migrate_zspage(struct zs_pool *pool, struct size_class *class,
 	int ret = 0;
 
 	while (1) {
-		handle = find_alloced_obj(class, s_page, obj_idx);
+		handle = find_alloced_obj(class, s_page, &obj_idx);
 		if (!handle) {
 			s_page = get_next_page(s_page);
 			if (!s_page)
-- 
1.9.1

  parent reply	other threads:[~2016-07-04  6:51 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04  6:49 [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface Ganesh Mahendran
2016-07-04  6:49 ` Ganesh Mahendran
2016-07-04  6:49 ` [PATCH v2 2/8] mm/zsmalloc: use obj_index to keep consistent with others Ganesh Mahendran
2016-07-04  6:49   ` Ganesh Mahendran
2016-07-05  1:25   ` Sergey Senozhatsky
2016-07-05  1:25     ` Sergey Senozhatsky
2016-07-06  2:37   ` Minchan Kim
2016-07-06  2:37     ` Minchan Kim
2016-07-04  6:49 ` Ganesh Mahendran [this message]
2016-07-04  6:49   ` [PATCH v2 3/8] mm/zsmalloc: take obj index back from find_alloced_obj Ganesh Mahendran
2016-07-05  1:32   ` Sergey Senozhatsky
2016-07-05  1:32     ` Sergey Senozhatsky
2016-07-06  2:40   ` Minchan Kim
2016-07-06  2:40     ` Minchan Kim
2016-07-04  6:49 ` [PATCH v2 4/8] mm/zsmalloc: use class->objs_per_zspage to get num of max objects Ganesh Mahendran
2016-07-04  6:49   ` Ganesh Mahendran
2016-07-05  1:30   ` Sergey Senozhatsky
2016-07-05  1:30     ` Sergey Senozhatsky
2016-07-04  6:49 ` [PATCH v2 5/8] mm/zsmalloc: avoid calculate max objects of zspage twice Ganesh Mahendran
2016-07-04  6:49   ` Ganesh Mahendran
2016-07-05  1:18   ` Sergey Senozhatsky
2016-07-05  1:18     ` Sergey Senozhatsky
2016-07-06  2:41   ` Minchan Kim
2016-07-06  2:41     ` Minchan Kim
2016-07-04  6:49 ` [PATCH v2 6/8] mm/zsmalloc: keep comments consistent with code Ganesh Mahendran
2016-07-04  6:49   ` Ganesh Mahendran
2016-07-05  1:11   ` Sergey Senozhatsky
2016-07-05  1:11     ` Sergey Senozhatsky
2016-07-06  2:41   ` Minchan Kim
2016-07-06  2:41     ` Minchan Kim
2016-07-04  6:49 ` [PATCH v2 7/8] mm/zsmalloc: add __init,__exit attribute Ganesh Mahendran
2016-07-04  6:49   ` Ganesh Mahendran
2016-07-04  8:43   ` Sergey Senozhatsky
2016-07-04  8:43     ` Sergey Senozhatsky
2016-07-04  9:21     ` Ganesh Mahendran
2016-07-04  9:21       ` Ganesh Mahendran
2016-07-05  1:00       ` Sergey Senozhatsky
2016-07-05  1:00         ` Sergey Senozhatsky
2016-07-06  2:48         ` Minchan Kim
2016-07-06  2:48           ` Minchan Kim
2016-07-06  6:21           ` Ganesh Mahendran
2016-07-06  6:21             ` Ganesh Mahendran
2016-07-04  6:49 ` [PATCH v2 8/8] mm/zsmalloc: use helper to clear page->flags bit Ganesh Mahendran
2016-07-04  6:49   ` Ganesh Mahendran
2016-07-04  8:45   ` Sergey Senozhatsky
2016-07-04  8:45     ` Sergey Senozhatsky
2016-07-05 16:50 ` [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface Steven Rostedt
2016-07-05 16:50   ` Steven Rostedt
2016-07-06  2:32 ` Minchan Kim
2016-07-06  2:32   ` Minchan Kim
2016-07-06  6:20   ` Ganesh Mahendran
2016-07-06  6:20     ` Ganesh Mahendran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467614999-4326-3-git-send-email-opensource.ganesh@gmail.com \
    --to=opensource.ganesh@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=mingo@redhat.com \
    --cc=ngupta@vflare.org \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.