From: slemieux.tyco@gmail.com (Sylvain Lemieux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next] lpc_eth: remove unused variable
Date: Mon, 04 Jul 2016 11:50:54 -0400 [thread overview]
Message-ID: <1467647454.28674.1.camel@localhost> (raw)
In-Reply-To: <20160704132018.1130907-1-arnd@arndb.de>
On Mon, 2016-07-04 at 15:19 +0200, Arnd Bergmann wrote:
> A cleanup patch removed the only user of a local variable, as
> indicated by a gcc warning.
>
> drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_eth_ioctl':
> drivers/net/ethernet/nxp/lpc_eth.c:1183:24: error: unused variable 'pldat' [-Werror=unused-variable]
>
> This removes the variable as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: f786f3564c4f ("net: ethernet: lpc_eth: use phydev from struct net_device")
> ---
> drivers/net/ethernet/nxp/lpc_eth.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
> index ad5464fa8ac7..660d113f8b9a 100644
> --- a/drivers/net/ethernet/nxp/lpc_eth.c
> +++ b/drivers/net/ethernet/nxp/lpc_eth.c
> @@ -1180,7 +1180,6 @@ static void lpc_eth_set_multicast_list(struct net_device *ndev)
>
> static int lpc_eth_ioctl(struct net_device *ndev, struct ifreq *req, int cmd)
> {
> - struct netdata_local *pldat = netdev_priv(ndev);
> struct phy_device *phydev = ndev->phydev;
>
> if (!netif_running(ndev))
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Sylvain Lemieux <slemieux.tyco@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Vladimir Zapolskiy <vz@mleia.com>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, Philippe Reynes <tremyfr@gmail.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] lpc_eth: remove unused variable
Date: Mon, 04 Jul 2016 11:50:54 -0400 [thread overview]
Message-ID: <1467647454.28674.1.camel@localhost> (raw)
In-Reply-To: <20160704132018.1130907-1-arnd@arndb.de>
On Mon, 2016-07-04 at 15:19 +0200, Arnd Bergmann wrote:
> A cleanup patch removed the only user of a local variable, as
> indicated by a gcc warning.
>
> drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_eth_ioctl':
> drivers/net/ethernet/nxp/lpc_eth.c:1183:24: error: unused variable 'pldat' [-Werror=unused-variable]
>
> This removes the variable as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: f786f3564c4f ("net: ethernet: lpc_eth: use phydev from struct net_device")
> ---
> drivers/net/ethernet/nxp/lpc_eth.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
> index ad5464fa8ac7..660d113f8b9a 100644
> --- a/drivers/net/ethernet/nxp/lpc_eth.c
> +++ b/drivers/net/ethernet/nxp/lpc_eth.c
> @@ -1180,7 +1180,6 @@ static void lpc_eth_set_multicast_list(struct net_device *ndev)
>
> static int lpc_eth_ioctl(struct net_device *ndev, struct ifreq *req, int cmd)
> {
> - struct netdata_local *pldat = netdev_priv(ndev);
> struct phy_device *phydev = ndev->phydev;
>
> if (!netif_running(ndev))
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>
next prev parent reply other threads:[~2016-07-04 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 13:19 [PATCH net-next] lpc_eth: remove unused variable Arnd Bergmann
2016-07-04 13:19 ` Arnd Bergmann
2016-07-04 15:50 ` Sylvain Lemieux [this message]
2016-07-04 15:50 ` Sylvain Lemieux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467647454.28674.1.camel@localhost \
--to=slemieux.tyco@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.