* [Buildroot] hostapd: default hostapd.conf on target
@ 2016-07-05 8:43 Alexey Brodkin
2016-07-05 8:48 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Brodkin @ 2016-07-05 8:43 UTC (permalink / raw)
To: buildroot
Hello,
I'm wondering if there's a reason default/example hostapd.conf is not installed on target?
IMHO it would be pretty convenient to have that config as a starting point.
Otherwise user has to create it manually from scratch.
Technically this is just a matter of:
------------------------>8-------------------------
diff --git a/package/hostapd/hostapd.mk b/package/hostapd/hostapd.mk
index dca07c1..40a21ff 100644
--- a/package/hostapd/hostapd.mk
+++ b/package/hostapd/hostapd.mk
@@ -85,7 +85,9 @@ define HOSTAPD_INSTALL_TARGET_CMDS
????????$(INSTALL) -m 0755 -D $(@D)/$(HOSTAPD_SUBDIR)/hostapd \
????????????????$(TARGET_DIR)/usr/sbin/hostapd
????????$(INSTALL) -m 0755 -D $(@D)/$(HOSTAPD_SUBDIR)/hostapd_cli \
-???????????????$(TARGET_DIR)/usr/bin/hostapd_cli
+???????????????$(TARGET_DIR)/usr/bin/hostapd_cli \
+???????$(INSTALL) -m 0644 -D $(@D)/$(HOSTAPD_SUBDIR)/hostapd/hostapd.conf \
+???????????????$(TARGET_DIR)/etc/hostapd.conf
?endef
?
?$(eval $(generic-package))
------------------------>8-------------------------
If there's no real reason to not have this I'll send a patch happily.
-Alexey
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] hostapd: default hostapd.conf on target
2016-07-05 8:43 [Buildroot] hostapd: default hostapd.conf on target Alexey Brodkin
@ 2016-07-05 8:48 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2016-07-05 8:48 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 5 Jul 2016 08:43:39 +0000, Alexey Brodkin wrote:
> I'm wondering if there's a reason default/example hostapd.conf is not installed on target?
> IMHO it would be pretty convenient to have that config as a starting point.
> Otherwise user has to create it manually from scratch.
>
> Technically this is just a matter of:
> ------------------------>8-------------------------
> diff --git a/package/hostapd/hostapd.mk b/package/hostapd/hostapd.mk
> index dca07c1..40a21ff 100644
> --- a/package/hostapd/hostapd.mk
> +++ b/package/hostapd/hostapd.mk
> @@ -85,7 +85,9 @@ define HOSTAPD_INSTALL_TARGET_CMDS
> ????????$(INSTALL) -m 0755 -D $(@D)/$(HOSTAPD_SUBDIR)/hostapd \
> ????????????????$(TARGET_DIR)/usr/sbin/hostapd
> ????????$(INSTALL) -m 0755 -D $(@D)/$(HOSTAPD_SUBDIR)/hostapd_cli \
> -???????????????$(TARGET_DIR)/usr/bin/hostapd_cli
> +???????????????$(TARGET_DIR)/usr/bin/hostapd_cli \
> +???????$(INSTALL) -m 0644 -D $(@D)/$(HOSTAPD_SUBDIR)/hostapd/hostapd.conf \
> +???????????????$(TARGET_DIR)/etc/hostapd.conf
> ?endef
> ?
> ?$(eval $(generic-package))
> ------------------------>8-------------------------
Thanks for your proposal, looks good to me. Gustavo, what do you think?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-05 8:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-05 8:43 [Buildroot] hostapd: default hostapd.conf on target Alexey Brodkin
2016-07-05 8:48 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.