All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Cc: autofs@vger.kernel.org
Subject: Re: [PATCH] automount: Drop redundant \n in logerr()
Date: Wed, 06 Jul 2016 17:31:19 +0800	[thread overview]
Message-ID: <1467797479.4580.52.camel@themaw.net> (raw)
In-Reply-To: <1467629332-8581-1-git-send-email-kusumi.tomohiro@gmail.com>

On Mon, 2016-07-04 at 19:48 +0900, Tomohiro Kusumi wrote:
> Line break isn't necessary from the way logerr (and logmsg) is implemented,
> and these two probably aren't intentional.

Also added to the list.

> 
> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
> ---
>  daemon/module.c | 2 +-
>  lib/nss_parse.y | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/daemon/module.c b/daemon/module.c
> index bed8f7a..db01db8 100644
> --- a/daemon/module.c
> +++ b/daemon/module.c
> @@ -34,7 +34,7 @@ int load_autofs4_module(void)
>  	 */
>  	fp = open_fopen_r("/proc/filesystems");
>  	if (!fp) {
> -		logerr("cannot open /proc/filesystems\n");
> +		logerr("cannot open /proc/filesystems");
>  		return 0;
>  	}
>  
> diff --git a/lib/nss_parse.y b/lib/nss_parse.y
> index 055e9d7..0721ba1 100644
> --- a/lib/nss_parse.y
> +++ b/lib/nss_parse.y
> @@ -169,7 +169,7 @@ int nsswitch_parse(struct list_head *list)
>  
>  	nsswitch = open_fopen_r(NSSWITCH_FILE);
>  	if (!nsswitch) {
> -		logerr("couldn't open %s\n", NSSWITCH_FILE);
> +		logerr("couldn't open %s", NSSWITCH_FILE);
>  		return 1;
>  	}
>  
--
To unsubscribe from this list: send the line "unsubscribe autofs" in

  reply	other threads:[~2016-07-06  9:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04 10:48 [PATCH] automount: Drop redundant \n in logerr() Tomohiro Kusumi
2016-07-06  9:31 ` Ian Kent [this message]
2016-07-06  9:55 ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467797479.4580.52.camel@themaw.net \
    --to=raven@themaw.net \
    --cc=autofs@vger.kernel.org \
    --cc=kusumi.tomohiro@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.