* [PATCH] automount: Drop redundant \n in logerr()
@ 2016-07-04 10:48 Tomohiro Kusumi
2016-07-06 9:31 ` Ian Kent
2016-07-06 9:55 ` Ian Kent
0 siblings, 2 replies; 3+ messages in thread
From: Tomohiro Kusumi @ 2016-07-04 10:48 UTC (permalink / raw)
To: raven; +Cc: autofs, Tomohiro Kusumi
Line break isn't necessary from the way logerr (and logmsg) is implemented,
and these two probably aren't intentional.
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
---
daemon/module.c | 2 +-
lib/nss_parse.y | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/daemon/module.c b/daemon/module.c
index bed8f7a..db01db8 100644
--- a/daemon/module.c
+++ b/daemon/module.c
@@ -34,7 +34,7 @@ int load_autofs4_module(void)
*/
fp = open_fopen_r("/proc/filesystems");
if (!fp) {
- logerr("cannot open /proc/filesystems\n");
+ logerr("cannot open /proc/filesystems");
return 0;
}
diff --git a/lib/nss_parse.y b/lib/nss_parse.y
index 055e9d7..0721ba1 100644
--- a/lib/nss_parse.y
+++ b/lib/nss_parse.y
@@ -169,7 +169,7 @@ int nsswitch_parse(struct list_head *list)
nsswitch = open_fopen_r(NSSWITCH_FILE);
if (!nsswitch) {
- logerr("couldn't open %s\n", NSSWITCH_FILE);
+ logerr("couldn't open %s", NSSWITCH_FILE);
return 1;
}
--
2.5.5
--
To unsubscribe from this list: send the line "unsubscribe autofs" in
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] automount: Drop redundant \n in logerr()
2016-07-04 10:48 [PATCH] automount: Drop redundant \n in logerr() Tomohiro Kusumi
@ 2016-07-06 9:31 ` Ian Kent
2016-07-06 9:55 ` Ian Kent
1 sibling, 0 replies; 3+ messages in thread
From: Ian Kent @ 2016-07-06 9:31 UTC (permalink / raw)
To: Tomohiro Kusumi; +Cc: autofs
On Mon, 2016-07-04 at 19:48 +0900, Tomohiro Kusumi wrote:
> Line break isn't necessary from the way logerr (and logmsg) is implemented,
> and these two probably aren't intentional.
Also added to the list.
>
> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
> ---
> daemon/module.c | 2 +-
> lib/nss_parse.y | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/daemon/module.c b/daemon/module.c
> index bed8f7a..db01db8 100644
> --- a/daemon/module.c
> +++ b/daemon/module.c
> @@ -34,7 +34,7 @@ int load_autofs4_module(void)
> */
> fp = open_fopen_r("/proc/filesystems");
> if (!fp) {
> - logerr("cannot open /proc/filesystems\n");
> + logerr("cannot open /proc/filesystems");
> return 0;
> }
>
> diff --git a/lib/nss_parse.y b/lib/nss_parse.y
> index 055e9d7..0721ba1 100644
> --- a/lib/nss_parse.y
> +++ b/lib/nss_parse.y
> @@ -169,7 +169,7 @@ int nsswitch_parse(struct list_head *list)
>
> nsswitch = open_fopen_r(NSSWITCH_FILE);
> if (!nsswitch) {
> - logerr("couldn't open %s\n", NSSWITCH_FILE);
> + logerr("couldn't open %s", NSSWITCH_FILE);
> return 1;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe autofs" in
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] automount: Drop redundant \n in logerr()
2016-07-04 10:48 [PATCH] automount: Drop redundant \n in logerr() Tomohiro Kusumi
2016-07-06 9:31 ` Ian Kent
@ 2016-07-06 9:55 ` Ian Kent
1 sibling, 0 replies; 3+ messages in thread
From: Ian Kent @ 2016-07-06 9:55 UTC (permalink / raw)
To: Tomohiro Kusumi; +Cc: autofs
On Mon, 2016-07-04 at 19:48 +0900, Tomohiro Kusumi wrote:
> Line break isn't necessary from the way logerr (and logmsg) is implemented,
> and these two probably aren't intentional.
Added to the list, same as the previous in terms of pushing it to the repo.
>
> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
> ---
> daemon/module.c | 2 +-
> lib/nss_parse.y | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/daemon/module.c b/daemon/module.c
> index bed8f7a..db01db8 100644
> --- a/daemon/module.c
> +++ b/daemon/module.c
> @@ -34,7 +34,7 @@ int load_autofs4_module(void)
> */
> fp = open_fopen_r("/proc/filesystems");
> if (!fp) {
> - logerr("cannot open /proc/filesystems\n");
> + logerr("cannot open /proc/filesystems");
> return 0;
> }
>
> diff --git a/lib/nss_parse.y b/lib/nss_parse.y
> index 055e9d7..0721ba1 100644
> --- a/lib/nss_parse.y
> +++ b/lib/nss_parse.y
> @@ -169,7 +169,7 @@ int nsswitch_parse(struct list_head *list)
>
> nsswitch = open_fopen_r(NSSWITCH_FILE);
> if (!nsswitch) {
> - logerr("couldn't open %s\n", NSSWITCH_FILE);
> + logerr("couldn't open %s", NSSWITCH_FILE);
> return 1;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe autofs" in
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-06 9:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-04 10:48 [PATCH] automount: Drop redundant \n in logerr() Tomohiro Kusumi
2016-07-06 9:31 ` Ian Kent
2016-07-06 9:55 ` Ian Kent
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.