From: Joe Perches <joe@perches.com>
To: Mike Marshall <hubcap@omnibond.com>
Cc: weiyj_lk@163.com, Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0)
Date: Wed, 06 Jul 2016 11:11:23 -0700 [thread overview]
Message-ID: <1467828683.8360.36.camel@perches.com> (raw)
In-Reply-To: <CAOg9mSSUe+u7kYAkD-Z8qCrf99Q+1-=tLf0=gtNmPBSe+U=nsA@mail.gmail.com>
On Wed, 2016-07-06 at 14:00 -0400, Mike Marshall wrote:
> Hi Joe...
Hi Mike.
> I looked around at other code to see how they were using vzalloc...
> even if it is just the caller of the function that uses vzalloc, most
> fs's that use vzalloc print an error message when vzalloc fails...
That's incorrect.
There are 72 v.alloc calls in fs/
2 of those calls have a specific OOM message.
There's 1 in reiserfs (old and unsupported) and 1 in orangefs
> I sure do
> like to follow the flow of our kernel module all in one place
> with the gossip statements...
I don't see how that matters here as there's
already an OOM on v.alloc failure.
cheers, Joe
next prev parent reply other threads:[~2016-07-06 18:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 13:23 [PATCH -next] orangefs: use vzalloc() instead of vmalloc()/memset(0) weiyj_lk
2016-07-06 17:28 ` Mike Marshall
2016-07-06 17:49 ` Joe Perches
2016-07-06 18:00 ` Mike Marshall
2016-07-06 18:11 ` Joe Perches [this message]
2016-07-06 19:01 ` Mike Marshall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467828683.8360.36.camel@perches.com \
--to=joe@perches.com \
--cc=hubcap@omnibond.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyj_lk@163.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.