From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/runc: fix shared only build when libseccomp is enabled.
Date: Thu, 7 Jul 2016 20:39:36 +0200 [thread overview]
Message-ID: <1467916777-29220-2-git-send-email-romain.naour@gmail.com> (raw)
In-Reply-To: <1467916777-29220-1-git-send-email-romain.naour@gmail.com>
When BR2_PACKAGE_LIBSECCOMP is set, the go build system will try to
find static library libseccomp.a since "static_build" and
"extldflags '-static'" are used.
Link runc statically only for static only build and prefer dynamic
linking otherwise.
Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Christian Stewart <christian@paral.in>
---
package/runc/runc.mk | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/package/runc/runc.mk b/package/runc/runc.mk
index 1396e0c..66f234f 100644
--- a/package/runc/runc.mk
+++ b/package/runc/runc.mk
@@ -19,10 +19,14 @@ RUNC_MAKE_ENV = $(HOST_GO_TARGET_ENV) \
PATH=$(BR_PATH)
RUNC_GLDFLAGS = \
- -X main.gitCommit=$(RUNC_VERSION) \
- -extldflags '-static'
+ -X main.gitCommit=$(RUNC_VERSION)
-RUNC_GOTAGS = cgo static_build
+RUNC_GOTAGS = cgo
+
+ifeq ($(BR2_STATIC_LIBS),y)
+RUNC_GOTAGS += static_build
+RUNC_GLDFLAGS += -extldflags '-static'
+endif
ifeq ($(BR2_PACKAGE_LIBSECCOMP),y)
RUNC_GOTAGS += seccomp
--
2.5.5
next prev parent reply other threads:[~2016-07-07 18:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 18:39 [Buildroot] [PATCH 1/3] package/runc: use BR_PATH to find pkg-config Romain Naour
2016-07-07 18:39 ` Romain Naour [this message]
2016-07-08 19:27 ` [Buildroot] [PATCH 2/3] package/runc: fix shared only build when libseccomp is enabled Thomas Petazzoni
2016-07-08 19:32 ` Christian Stewart
2016-07-08 19:50 ` Thomas Petazzoni
2016-07-08 19:55 ` Christian Stewart
2016-07-11 9:47 ` Thomas Petazzoni
2016-07-13 21:18 ` Romain Naour
2016-07-24 14:45 ` Thomas Petazzoni
2016-07-07 18:39 ` [Buildroot] [PATCH 3/3] package/runc: disable for static only build Romain Naour
2016-07-08 19:47 ` Thomas Petazzoni
2016-07-24 14:49 ` Thomas Petazzoni
2016-07-08 19:22 ` [Buildroot] [PATCH 1/3] package/runc: use BR_PATH to find pkg-config Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467916777-29220-2-git-send-email-romain.naour@gmail.com \
--to=romain.naour@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.