All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/runc: fix shared only build when libseccomp is enabled.
Date: Fri, 8 Jul 2016 21:50:31 +0200	[thread overview]
Message-ID: <20160708215031.17fe15de@free-electrons.com> (raw)
In-Reply-To: <1468006361981-b8d5773f-c47578b5-9b1f9581@mixmax.com>

Hello,


On Fri, 08 Jul 2016 19:32:41 +0000, Christian Stewart wrote:

> In my latest revision of docker-engine I removed the -static flag for CGO
> because btrfs would not link for the same reason.
> I think it's fine to remove the ?-static? extldflag on everything for Go. I have
> had no trouble doing so with docker-engine and I don't see why there would be a
> problem with the other packages.
> We want to statically link the Go code to other go code, yes, but linking the Go
> code to C libraries should be fine dynamically.

OK. Can we remove unconditionally, or should we still keep it for
BR2_STATIC_LIBS=y builds?

Perhaps we should pass -extldflags '$(TARGET_LDFLAGS)', since
TARGET_LDFLAGS will automatically contain -static when
BR2_STATIC_LIBS=y.

For the specific case of runc, is "RUNC_GOTAGS = static_build" needed
when BR2_STATIC_LIBS=y ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-07-08 19:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07 18:39 [Buildroot] [PATCH 1/3] package/runc: use BR_PATH to find pkg-config Romain Naour
2016-07-07 18:39 ` [Buildroot] [PATCH 2/3] package/runc: fix shared only build when libseccomp is enabled Romain Naour
2016-07-08 19:27   ` Thomas Petazzoni
2016-07-08 19:32     ` Christian Stewart
2016-07-08 19:50       ` Thomas Petazzoni [this message]
2016-07-08 19:55         ` Christian Stewart
2016-07-11  9:47           ` Thomas Petazzoni
2016-07-13 21:18           ` Romain Naour
2016-07-24 14:45   ` Thomas Petazzoni
2016-07-07 18:39 ` [Buildroot] [PATCH 3/3] package/runc: disable for static only build Romain Naour
2016-07-08 19:47   ` Thomas Petazzoni
2016-07-24 14:49     ` Thomas Petazzoni
2016-07-08 19:22 ` [Buildroot] [PATCH 1/3] package/runc: use BR_PATH to find pkg-config Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160708215031.17fe15de@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.