* Patch "ARM: dts: sun6i: primo81: Drop constraints on dc1sw regulator" has been added to the 4.6-stable tree
@ 2016-07-11 23:39 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-07-11 23:39 UTC (permalink / raw)
To: wens, gregkh, hdegoede, maxime.ripard, olof; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
ARM: dts: sun6i: primo81: Drop constraints on dc1sw regulator
to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
arm-dts-sun6i-primo81-drop-constraints-on-dc1sw-regulator.patch
and it can be found in the queue-4.6 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From cb84f6c0a25eb76b1f838eb63e212705c0c06b5f Mon Sep 17 00:00:00 2001
From: Chen-Yu Tsai <wens@csie.org>
Date: Wed, 11 May 2016 13:23:13 +0800
Subject: ARM: dts: sun6i: primo81: Drop constraints on dc1sw regulator
From: Chen-Yu Tsai <wens@csie.org>
commit cb84f6c0a25eb76b1f838eb63e212705c0c06b5f upstream.
This is the same issue fixed in commit dcf5341f0150 ("ARM: dts:
sun8i-q8-common: Do not set constraints on dc1sw regulator").
Commit message copied:
dc1sw is an on/off only regulator and as such it cannot have constraints.
This is a limitation of the kernel regulator implementation which resolves
supplies on the first regulator_get(), which is done after applying
constraints, and applying the constrains will fail because it calls
_regulator_get_voltage() and _regulator_do_set_voltage() both of which
will fail on a switch regulator when there is no supply (yet).
This causes registering of all axp22x regulators to fail with the
following errors:
[ 1.395249] vcc-lcd: failed to get the current voltage(-22)
[ 1.405131] axp20x-regulator axp20x-regulator: Failed to register dc1sw
[ 1.412436] axp20x-regulator: probe of axp20x-regulator failed with error -22
This commit removes the constrains on dc1sw / vcc-lcd fixing this problem.
Note that dcdc1 itself is contrained to the exact same values, so this
does not change anything.
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
arch/arm/boot/dts/sun6i-a31s-primo81.dts | 2 --
1 file changed, 2 deletions(-)
--- a/arch/arm/boot/dts/sun6i-a31s-primo81.dts
+++ b/arch/arm/boot/dts/sun6i-a31s-primo81.dts
@@ -176,8 +176,6 @@
};
®_dc1sw {
- regulator-min-microvolt = <3000000>;
- regulator-max-microvolt = <3000000>;
regulator-name = "vcc-lcd";
};
Patches currently in stable-queue which might be from wens@csie.org are
queue-4.6/arm-dts-sun6i-primo81-drop-constraints-on-dc1sw-regulator.patch
queue-4.6/arm-dts-sun6i-yones-toptech-bs1078-v2-drop-constraints-on-dc1sw-regulator.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-07-12 0:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-11 23:39 Patch "ARM: dts: sun6i: primo81: Drop constraints on dc1sw regulator" has been added to the 4.6-stable tree gregkh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.