All of lore.kernel.org
 help / color / mirror / Atom feed
* [yocto-autobuilder][PATCH] PublishLayerTarballs.py: don't change directories for Eclipse builds
@ 2016-07-08 18:43 Bill Randle
  2016-07-12 16:15 ` Joshua G Lock
  0 siblings, 1 reply; 2+ messages in thread
From: Bill Randle @ 2016-07-08 18:43 UTC (permalink / raw)
  To: yocto

When publishing eclipse tarballs, we are already in the correct directory,
so skip the change direction operation (which will generate an error).

Signed-off-by: Bill Randle <william.c.randle@intel.com>
---
 .../site-packages/autobuilder/buildsteps/PublishLayerTarballs.py       | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/python2.7/site-packages/autobuilder/buildsteps/PublishLayerTarballs.py b/lib/python2.7/site-packages/autobuilder/buildsteps/PublishLayerTarballs.py
index c140725..7c1ce4a 100644
--- a/lib/python2.7/site-packages/autobuilder/buildsteps/PublishLayerTarballs.py
+++ b/lib/python2.7/site-packages/autobuilder/buildsteps/PublishLayerTarballs.py
@@ -38,7 +38,8 @@ class PublishLayerTarballs(ShellCommand):
         snapshot = ""
         self.basedir=os.path.join(os.path.join(os.path.join(
                                     self.workerdir, buildername), self.workdir))
-        if self.layername is not "poky":
+        if self.layername is not "poky"
+           and "eclipse" is not in self.layername:
             command = "cd " + self.layername + ";"
         else:
             command = ""
-- 
2.5.5



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [yocto-autobuilder][PATCH] PublishLayerTarballs.py: don't change directories for Eclipse builds
  2016-07-08 18:43 [yocto-autobuilder][PATCH] PublishLayerTarballs.py: don't change directories for Eclipse builds Bill Randle
@ 2016-07-12 16:15 ` Joshua G Lock
  0 siblings, 0 replies; 2+ messages in thread
From: Joshua G Lock @ 2016-07-12 16:15 UTC (permalink / raw)
  To: Bill Randle, yocto

On Fri, 2016-07-08 at 11:43 -0700, Bill Randle wrote:
> When publishing eclipse tarballs, we are already in the correct
> directory,
> so skip the change direction operation (which will generate an
> error).
> 
> Signed-off-by: Bill Randle <william.c.randle@intel.com>
> ---
>  .../site-
> packages/autobuilder/buildsteps/PublishLayerTarballs.py       | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/python2.7/site-
> packages/autobuilder/buildsteps/PublishLayerTarballs.py
> b/lib/python2.7/site-
> packages/autobuilder/buildsteps/PublishLayerTarballs.py
> index c140725..7c1ce4a 100644
> --- a/lib/python2.7/site-
> packages/autobuilder/buildsteps/PublishLayerTarballs.py
> +++ b/lib/python2.7/site-
> packages/autobuilder/buildsteps/PublishLayerTarballs.py
> @@ -38,7 +38,8 @@ class PublishLayerTarballs(ShellCommand):
>          snapshot = ""
>          self.basedir=os.path.join(os.path.join(os.path.join(
>                                      self.workerdir, buildername),
> self.workdir))
> -        if self.layername is not "poky":
> +        if self.layername is not "poky"
> +           and "eclipse" is not in self.layername:

That's not valid Python syntax, you want `foo not in bar`:

[joshuagl@munchkin ~]
$ python3
Python 3.5.1 (default, Jun 20 2016, 14:48:22) 
[GCC 6.1.1 20160510 (Red Hat 6.1.1-2)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> "eclipse" is not in "foo"
  File "<stdin>", line 1
    "eclipse" is not in "foo"
                      ^
SyntaxError: invalid syntax
>>> "eclipse" not in "foo"
True

Regards,

Joshua

>              command = "cd " + self.layername + ";"
>          else:
>              command = ""


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-12 16:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-08 18:43 [yocto-autobuilder][PATCH] PublishLayerTarballs.py: don't change directories for Eclipse builds Bill Randle
2016-07-12 16:15 ` Joshua G Lock

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.