From: Gerd Hoffmann <kraxel@redhat.com>
To: Isaac Lozano <109lozanoi@gmail.com>
Cc: qemu-devel@nongnu.org, bsd@redhat.com
Subject: Re: [Qemu-devel] [PATCH] usb-mtp: added support for files larger than 4gb
Date: Thu, 14 Jul 2016 16:34:04 +0200 [thread overview]
Message-ID: <1468506844.26657.21.camel@redhat.com> (raw)
In-Reply-To: <20160714114956.GA5245@gmail.com>
On Do, 2016-07-14 at 04:49 -0700, Isaac Lozano wrote:
> Added support for sending data larger than 4gb.
> Also implemented
> object properties so that Windows can receive >4gb files.
Can you please split those into two separate patches?
> + case PROP_PERSISTENT_UNIQUE_OBJECT_IDENTIFIER:
> + /* Should be persistant between sessions,
> + * but using our objedt ID is "good enough"
> + * for now */
> + usb_mtp_add_u64(d, 0x0000000000000000);
> + usb_mtp_add_u64(d, o->handle);
> + break;
Maybe use the inode number here?
cheers,
Gerd
next prev parent reply other threads:[~2016-07-14 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 11:49 [Qemu-devel] [PATCH] usb-mtp: added support for files larger than 4gb Isaac Lozano
2016-07-14 14:34 ` Gerd Hoffmann [this message]
2016-07-14 18:48 ` Bandan Das
2016-07-14 18:46 ` Bandan Das
2016-07-15 11:30 ` Isaac Lozano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468506844.26657.21.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=109lozanoi@gmail.com \
--cc=bsd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.