From: Sinan Kaya <okaya@codeaurora.org>
To: kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org,
jcm@redhat.com, alex.williamson@redhat.com,
eric.auger@redhat.com
Cc: linux-acpi@vger.kernel.org, agross@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sinan Kaya <okaya@codeaurora.org>,
Baptiste Reynal <b.reynal@virtualopensystems.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH V10 6/9] vfio: platform: call _RST method when using ACPI
Date: Mon, 18 Jul 2016 19:09:24 -0400 [thread overview]
Message-ID: <1468883367-2854-7-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1468883367-2854-1-git-send-email-okaya@codeaurora.org>
The device tree code checks for the presence of a reset driver and calls
the of_reset function pointer by looking up the reset driver as a module.
ACPI defines _RST method to perform device level reset. After the _RST
method is executed, the OS can resume using the device. _RST method is
expected to stop DMA transfers and IRQs.
This patch introduces two functions as vfio_platform_acpi_has_reset and
vfio_platform_acpi_call_reset. The has reset method is used to declare
reset capability via the ioctl flag VFIO_DEVICE_FLAGS_RESET. The call
reset function is used to execute the _RST ACPI method.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/vfio/platform/vfio_platform_common.c | 50 +++++++++++++++++++++++++++-
1 file changed, 49 insertions(+), 1 deletion(-)
diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
index f6025c9..b1e5801 100644
--- a/drivers/vfio/platform/vfio_platform_common.c
+++ b/drivers/vfio/platform/vfio_platform_common.c
@@ -28,6 +28,8 @@
#define DRIVER_AUTHOR "Antonios Motakis <a.motakis@virtualopensystems.com>"
#define DRIVER_DESC "VFIO platform base module"
+#define VFIO_PLATFORM_IS_ACPI(vdev) ((vdev)->acpihid != NULL)
+
static LIST_HEAD(reset_list);
static DEFINE_MUTEX(driver_lock);
@@ -76,13 +78,53 @@ static int vfio_platform_acpi_probe(struct vfio_platform_device *vdev,
return WARN_ON(!vdev->acpihid) ? -ENOENT : 0;
}
+int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev,
+ const char **extra_dbg)
+{
+#ifdef CONFIG_ACPI
+ struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
+ struct device *dev = vdev->device;
+ acpi_handle handle = ACPI_HANDLE(dev);
+ acpi_status acpi_ret;
+
+ acpi_ret = acpi_evaluate_object(handle, "_RST", NULL, &buffer);
+ if (ACPI_FAILURE(acpi_ret)) {
+ if (extra_dbg)
+ *extra_dbg = acpi_format_exception(acpi_ret);
+ return -EINVAL;
+ }
+
+ return 0;
+#else
+ return -ENOENT;
+#endif
+}
+
+bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev)
+{
+#ifdef CONFIG_ACPI
+ struct device *dev = vdev->device;
+ acpi_handle handle = ACPI_HANDLE(dev);
+
+ return acpi_has_method(handle, "_RST");
+#else
+ return false;
+#endif
+}
+
static bool vfio_platform_has_reset(struct vfio_platform_device *vdev)
{
+ if (VFIO_PLATFORM_IS_ACPI(vdev))
+ return vfio_platform_acpi_has_reset(vdev);
+
return vdev->of_reset ? true : false;
}
static void vfio_platform_get_reset(struct vfio_platform_device *vdev)
{
+ if (VFIO_PLATFORM_IS_ACPI(vdev))
+ return;
+
vdev->of_reset = vfio_platform_lookup_reset(vdev->compat,
&vdev->reset_module);
if (!vdev->of_reset) {
@@ -94,6 +136,9 @@ static void vfio_platform_get_reset(struct vfio_platform_device *vdev)
static void vfio_platform_put_reset(struct vfio_platform_device *vdev)
{
+ if (VFIO_PLATFORM_IS_ACPI(vdev))
+ return;
+
if (vdev->of_reset)
module_put(vdev->reset_module);
}
@@ -169,7 +214,10 @@ static void vfio_platform_regions_cleanup(struct vfio_platform_device *vdev)
static int vfio_platform_call_reset(struct vfio_platform_device *vdev,
const char **extra_dbg)
{
- if (vdev->of_reset) {
+ if (VFIO_PLATFORM_IS_ACPI(vdev)) {
+ dev_info(vdev->device, "reset\n");
+ return vfio_platform_acpi_call_reset(vdev, extra_dbg);
+ } else if (vdev->of_reset) {
dev_info(vdev->device, "reset\n");
return vdev->of_reset(vdev);
}
--
1.8.2.1
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V10 6/9] vfio: platform: call _RST method when using ACPI
Date: Mon, 18 Jul 2016 19:09:24 -0400 [thread overview]
Message-ID: <1468883367-2854-7-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1468883367-2854-1-git-send-email-okaya@codeaurora.org>
The device tree code checks for the presence of a reset driver and calls
the of_reset function pointer by looking up the reset driver as a module.
ACPI defines _RST method to perform device level reset. After the _RST
method is executed, the OS can resume using the device. _RST method is
expected to stop DMA transfers and IRQs.
This patch introduces two functions as vfio_platform_acpi_has_reset and
vfio_platform_acpi_call_reset. The has reset method is used to declare
reset capability via the ioctl flag VFIO_DEVICE_FLAGS_RESET. The call
reset function is used to execute the _RST ACPI method.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/vfio/platform/vfio_platform_common.c | 50 +++++++++++++++++++++++++++-
1 file changed, 49 insertions(+), 1 deletion(-)
diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
index f6025c9..b1e5801 100644
--- a/drivers/vfio/platform/vfio_platform_common.c
+++ b/drivers/vfio/platform/vfio_platform_common.c
@@ -28,6 +28,8 @@
#define DRIVER_AUTHOR "Antonios Motakis <a.motakis@virtualopensystems.com>"
#define DRIVER_DESC "VFIO platform base module"
+#define VFIO_PLATFORM_IS_ACPI(vdev) ((vdev)->acpihid != NULL)
+
static LIST_HEAD(reset_list);
static DEFINE_MUTEX(driver_lock);
@@ -76,13 +78,53 @@ static int vfio_platform_acpi_probe(struct vfio_platform_device *vdev,
return WARN_ON(!vdev->acpihid) ? -ENOENT : 0;
}
+int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev,
+ const char **extra_dbg)
+{
+#ifdef CONFIG_ACPI
+ struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
+ struct device *dev = vdev->device;
+ acpi_handle handle = ACPI_HANDLE(dev);
+ acpi_status acpi_ret;
+
+ acpi_ret = acpi_evaluate_object(handle, "_RST", NULL, &buffer);
+ if (ACPI_FAILURE(acpi_ret)) {
+ if (extra_dbg)
+ *extra_dbg = acpi_format_exception(acpi_ret);
+ return -EINVAL;
+ }
+
+ return 0;
+#else
+ return -ENOENT;
+#endif
+}
+
+bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev)
+{
+#ifdef CONFIG_ACPI
+ struct device *dev = vdev->device;
+ acpi_handle handle = ACPI_HANDLE(dev);
+
+ return acpi_has_method(handle, "_RST");
+#else
+ return false;
+#endif
+}
+
static bool vfio_platform_has_reset(struct vfio_platform_device *vdev)
{
+ if (VFIO_PLATFORM_IS_ACPI(vdev))
+ return vfio_platform_acpi_has_reset(vdev);
+
return vdev->of_reset ? true : false;
}
static void vfio_platform_get_reset(struct vfio_platform_device *vdev)
{
+ if (VFIO_PLATFORM_IS_ACPI(vdev))
+ return;
+
vdev->of_reset = vfio_platform_lookup_reset(vdev->compat,
&vdev->reset_module);
if (!vdev->of_reset) {
@@ -94,6 +136,9 @@ static void vfio_platform_get_reset(struct vfio_platform_device *vdev)
static void vfio_platform_put_reset(struct vfio_platform_device *vdev)
{
+ if (VFIO_PLATFORM_IS_ACPI(vdev))
+ return;
+
if (vdev->of_reset)
module_put(vdev->reset_module);
}
@@ -169,7 +214,10 @@ static void vfio_platform_regions_cleanup(struct vfio_platform_device *vdev)
static int vfio_platform_call_reset(struct vfio_platform_device *vdev,
const char **extra_dbg)
{
- if (vdev->of_reset) {
+ if (VFIO_PLATFORM_IS_ACPI(vdev)) {
+ dev_info(vdev->device, "reset\n");
+ return vfio_platform_acpi_call_reset(vdev, extra_dbg);
+ } else if (vdev->of_reset) {
dev_info(vdev->device, "reset\n");
return vdev->of_reset(vdev);
}
--
1.8.2.1
next prev parent reply other threads:[~2016-07-18 23:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 23:09 [PATCH V10 0/9] vfio, platform: add ACPI support Sinan Kaya
2016-07-18 23:09 ` Sinan Kaya
2016-07-18 23:09 ` [PATCH V10 1/9] vfio: platform: rename reset function Sinan Kaya
2016-07-18 23:09 ` Sinan Kaya
2016-07-18 23:09 ` [PATCH V10 2/9] vfio: platform: move reset call to a common function Sinan Kaya
2016-07-18 23:09 ` Sinan Kaya
2016-07-18 23:09 ` [PATCH V10 3/9] vfio: platform: determine reset capability Sinan Kaya
2016-07-18 23:09 ` Sinan Kaya
2016-07-18 23:09 ` [PATCH V10 4/9] vfio: platform: add support for ACPI probe Sinan Kaya
2016-07-18 23:09 ` Sinan Kaya
2016-07-19 0:00 ` Alex Williamson
2016-07-19 0:00 ` Alex Williamson
2016-07-19 0:16 ` okaya
2016-07-19 0:16 ` okaya at codeaurora.org
2016-07-19 0:24 ` Alex Williamson
2016-07-19 0:24 ` Alex Williamson
2016-07-19 14:49 ` Sinan Kaya
2016-07-19 14:49 ` Sinan Kaya
2016-07-19 15:28 ` Alex Williamson
2016-07-19 15:28 ` Alex Williamson
2016-07-19 15:29 ` Sinan Kaya
2016-07-19 15:29 ` Sinan Kaya
2016-07-18 23:09 ` [PATCH V10 5/9] vfio: platform: add extra debug info argument to call reset Sinan Kaya
2016-07-18 23:09 ` Sinan Kaya
2016-07-18 23:09 ` Sinan Kaya [this message]
2016-07-18 23:09 ` [PATCH V10 6/9] vfio: platform: call _RST method when using ACPI Sinan Kaya
2016-07-18 23:09 ` [PATCH V10 7/9] vfio, platform: make reset driver a requirement by default Sinan Kaya
2016-07-18 23:09 ` Sinan Kaya
2016-07-18 23:09 ` Sinan Kaya
2016-07-18 23:09 ` [PATCH V10 8/9] vfio: platform: check reset call return code during open Sinan Kaya
2016-07-18 23:09 ` Sinan Kaya
2016-07-18 23:09 ` Sinan Kaya
2016-07-18 23:09 ` [PATCH V10 9/9] vfio: platform: check reset call return code during release Sinan Kaya
2016-07-18 23:09 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468883367-2854-7-git-send-email-okaya@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=alex.williamson@redhat.com \
--cc=b.reynal@virtualopensystems.com \
--cc=cov@codeaurora.org \
--cc=eric.auger@redhat.com \
--cc=jcm@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.