From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Tristan Gingold <gingold@adacore.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>,
Paul Mackerras <pmac@au1.ibm.com>,
Anton Blanchard <anton@au1.ibm.com>,
Fabien Chouteau <chouteau@adacore.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] ppc: TCG and FP exceptions, is it right ?
Date: Tue, 26 Jul 2016 07:50:33 +1000 [thread overview]
Message-ID: <1469483433.5978.59.camel@kernel.crashing.org> (raw)
In-Reply-To: <F9EA185B-897B-47A5-A52F-C6DF2417F111@adacore.com>
On Mon, 2016-07-25 at 17:12 +0200, Tristan Gingold wrote:
> >
> > The code as writte will take the exception before the FPR is
> > updated,
> > I *think*, or am I missing something here ?
>
> This looks like an oversight. In our tests, we don't read the fpr.
BTW. Do you happen to have some tests I could run to verify that my
changes don't break your code ?
Cheers,
Ben.
prev parent reply other threads:[~2016-07-25 22:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 9:44 [Qemu-devel] ppc: TCG and FP exceptions, is it right ? Benjamin Herrenschmidt
2016-07-25 13:35 ` Richard Henderson
2016-07-25 21:38 ` Benjamin Herrenschmidt
2016-07-25 15:12 ` Tristan Gingold
2016-07-25 21:50 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469483433.5978.59.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=anton@au1.ibm.com \
--cc=chouteau@adacore.com \
--cc=david@gibson.dropbear.id.au \
--cc=gingold@adacore.com \
--cc=pmac@au1.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.