From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2
Date: Tue, 26 Jul 2016 10:53:55 -0700 [thread overview]
Message-ID: <1469555635.2851.10.camel@intel.com> (raw)
In-Reply-To: <1469554746-410-1-git-send-email-jarod@redhat.com>
On Tue, 2016-07-26 at 13:39 -0400, Jarod Wilson wrote:
> Per Jesse Brandeburg, e1000e should be using flags for this sort of
> thing.
>
> Littering functional code with device-specific checks is much messier
> than
> simply checking a flag, and having device-specific init set flags as
> needed.
> There are probably a number of other cases in the e1000e code that
> could/should be converted similarly.
>
> At present, this patch is a follow-up to the previously submitted 2
> patches, but I can redo the series to omit the conversion to a switch
> entirely, if so desired.
>
> Suggested-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> CC: Jesse Brandeburg <jesse.brandeburg@intel.com>
> CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> CC: intel-wired-lan at lists.osuosl.org
> CC: netdev at vger.kernel.org
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
> ---
> ?drivers/net/ethernet/intel/e1000e/82571.c?? |? 6 ++++--
> ?drivers/net/ethernet/intel/e1000e/e1000.h?? |? 1 +
> ?drivers/net/ethernet/intel/e1000e/ich8lan.c |? 3 ++-
> ?drivers/net/ethernet/intel/e1000e/netdev.c? | 10 ++--------
> ?4 files changed, 9 insertions(+), 11 deletions(-)
This generates a compile issue, so I will be dropping this patch and will
await an update.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160726/3055a5ca/attachment-0001.asc>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Jarod Wilson <jarod@redhat.com>, linux-kernel@vger.kernel.org
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2
Date: Tue, 26 Jul 2016 10:53:55 -0700 [thread overview]
Message-ID: <1469555635.2851.10.camel@intel.com> (raw)
In-Reply-To: <1469554746-410-1-git-send-email-jarod@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]
On Tue, 2016-07-26 at 13:39 -0400, Jarod Wilson wrote:
> Per Jesse Brandeburg, e1000e should be using flags for this sort of
> thing.
>
> Littering functional code with device-specific checks is much messier
> than
> simply checking a flag, and having device-specific init set flags as
> needed.
> There are probably a number of other cases in the e1000e code that
> could/should be converted similarly.
>
> At present, this patch is a follow-up to the previously submitted 2
> patches, but I can redo the series to omit the conversion to a switch
> entirely, if so desired.
>
> Suggested-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> CC: Jesse Brandeburg <jesse.brandeburg@intel.com>
> CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> CC: intel-wired-lan@lists.osuosl.org
> CC: netdev@vger.kernel.org
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
> ---
> drivers/net/ethernet/intel/e1000e/82571.c | 6 ++++--
> drivers/net/ethernet/intel/e1000e/e1000.h | 1 +
> drivers/net/ethernet/intel/e1000e/ich8lan.c | 3 ++-
> drivers/net/ethernet/intel/e1000e/netdev.c | 10 ++--------
> 4 files changed, 9 insertions(+), 11 deletions(-)
This generates a compile issue, so I will be dropping this patch and will
await an update.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-26 17:53 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 20:25 [Intel-wired-lan] [PATCH net] e1000e: fix PTP on e1000_pch_lpt variants Jarod Wilson
2016-07-19 20:25 ` Jarod Wilson
2016-07-19 20:49 ` [Intel-wired-lan] " Rustad, Mark D
2016-07-19 20:49 ` Rustad, Mark D
2016-07-20 17:05 ` Jarod Wilson
2016-07-20 17:05 ` Jarod Wilson
2016-07-20 11:01 ` Sergei Shtylyov
2016-07-20 11:01 ` Sergei Shtylyov
2016-07-23 16:44 ` [Intel-wired-lan] [PATCH v2 net-next 0/2] e1000e: fix PTP on e1000_pch_variants Jarod Wilson
2016-07-23 16:44 ` Jarod Wilson
2016-07-23 16:44 ` [Intel-wired-lan] [PATCH net-next 1/2] e1000e: factor out systim sanitization Jarod Wilson
2016-07-23 16:44 ` Jarod Wilson
2016-07-23 16:44 ` [Intel-wired-lan] [PATCH net-next 2/2] e1000e: fix PTP on e1000_pch_lpt variants Jarod Wilson
2016-07-23 16:44 ` Jarod Wilson
2016-07-25 17:56 ` [Intel-wired-lan] [PATCH v2 net-next 0/2] e1000e: fix PTP on e1000_pch_variants Jesse Brandeburg
2016-07-25 17:56 ` Jesse Brandeburg
2016-07-26 17:39 ` [Intel-wired-lan] [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2 Jarod Wilson
2016-07-26 17:39 ` Jarod Wilson
2016-07-26 17:53 ` Jeff Kirsher [this message]
2016-07-26 17:53 ` Jeff Kirsher
2016-07-26 17:58 ` [Intel-wired-lan] " Jarod Wilson
2016-07-26 17:58 ` Jarod Wilson
2016-07-26 18:25 ` [Intel-wired-lan] [PATCH v3 net-next 0/2] e1000e: fix PTP on e1000_pch_variants Jarod Wilson
2016-07-26 18:25 ` Jarod Wilson
2016-07-26 18:25 ` [Intel-wired-lan] [PATCH net-next v3 1/2] e1000e: factor out systim sanitization Jarod Wilson
2016-07-26 18:25 ` Jarod Wilson
2016-07-27 14:09 ` [Intel-wired-lan] " Avargil, Raanan
2016-07-27 14:09 ` Avargil, Raanan
2016-07-27 15:01 ` Jarod Wilson
2016-07-27 15:01 ` Jarod Wilson
2016-08-02 1:32 ` Jarod Wilson
2016-08-02 1:32 ` Jarod Wilson
2016-08-02 7:33 ` Brown, Aaron F
2016-08-02 7:33 ` Brown, Aaron F
2016-08-11 15:48 ` Jarod Wilson
2016-08-11 15:48 ` Jarod Wilson
2016-07-27 21:15 ` Woodford, Timothy W.
2016-07-27 21:15 ` Woodford, Timothy W.
2016-07-29 14:40 ` Woodford, Timothy W.
2016-07-29 14:40 ` Woodford, Timothy W.
2016-08-04 19:34 ` Brown, Aaron F
2016-08-04 19:34 ` Brown, Aaron F
2016-08-04 19:30 ` Brown, Aaron F
2016-08-04 19:30 ` Brown, Aaron F
2016-07-26 18:25 ` [Intel-wired-lan] [PATCH net-next v3 2/2] e1000e: fix PTP on e1000_pch_lpt variants Jarod Wilson
2016-07-26 18:25 ` Jarod Wilson
2016-08-04 19:31 ` [Intel-wired-lan] " Brown, Aaron F
2016-08-04 19:31 ` Brown, Aaron F
2016-07-24 20:30 ` [Intel-wired-lan] [PATCH net] " kbuild test robot
2016-07-24 20:30 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469555635.2851.10.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.