All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg <gvrose8192@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 1/1] ixgbevf: replace integer number with bool value
Date: Thu, 28 Jul 2016 07:29:06 -0700	[thread overview]
Message-ID: <1469716146.14256.1.camel@gmail.com> (raw)
In-Reply-To: <1469626117-3669-1-git-send-email-zyjzyj2000@gmail.com>

On Wed, 2016-07-27 at 21:28 +0800, Zhu Yanjun wrote:
> The variable get_mac_status is a bool variable. So a bool value is
> better than an integer number.
> 
> Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>

Looks good to me.

Reviewed-by: Greg Rose <grose@lightfleet.com>

> ---
>  drivers/net/ethernet/intel/ixgbevf/ethtool.c      | 2 +-
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ethtool.c b/drivers/net/ethernet/intel/ixgbevf/ethtool.c
> index 508e72c..ce221d1 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ethtool.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ethtool.c
> @@ -104,7 +104,7 @@ static int ixgbevf_get_settings(struct net_device *netdev,
>  	ecmd->transceiver = XCVR_DUMMY1;
>  	ecmd->port = -1;
>  
> -	hw->mac.get_link_status = 1;
> +	hw->mac.get_link_status = true;
>  	hw->mac.ops.check_link(hw, &link_speed, &link_up, false);
>  
>  	if (link_up) {
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> index acc2401..a98e7c2 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> @@ -1285,7 +1285,7 @@ static irqreturn_t ixgbevf_msix_other(int irq, void *data)
>  	struct ixgbevf_adapter *adapter = data;
>  	struct ixgbe_hw *hw = &adapter->hw;
>  
> -	hw->mac.get_link_status = 1;
> +	hw->mac.get_link_status = true;
>  
>  	ixgbevf_service_event_schedule(adapter);
>  
> @@ -2109,7 +2109,7 @@ static void ixgbevf_up_complete(struct ixgbevf_adapter *adapter)
>  	ixgbevf_save_reset_stats(adapter);
>  	ixgbevf_init_last_counter_stats(adapter);
>  
> -	hw->mac.get_link_status = 1;
> +	hw->mac.get_link_status = true;
>  	mod_timer(&adapter->service_timer, jiffies);
>  }
>  



WARNING: multiple messages have this Message-ID (diff)
From: Greg <gvrose8192@gmail.com>
To: Zhu Yanjun <zyjzyj2000@gmail.com>
Cc: jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ixgbevf: replace integer number with bool value
Date: Thu, 28 Jul 2016 07:29:06 -0700	[thread overview]
Message-ID: <1469716146.14256.1.camel@gmail.com> (raw)
In-Reply-To: <1469626117-3669-1-git-send-email-zyjzyj2000@gmail.com>

On Wed, 2016-07-27 at 21:28 +0800, Zhu Yanjun wrote:
> The variable get_mac_status is a bool variable. So a bool value is
> better than an integer number.
> 
> Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>

Looks good to me.

Reviewed-by: Greg Rose <grose@lightfleet.com>

> ---
>  drivers/net/ethernet/intel/ixgbevf/ethtool.c      | 2 +-
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ethtool.c b/drivers/net/ethernet/intel/ixgbevf/ethtool.c
> index 508e72c..ce221d1 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ethtool.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ethtool.c
> @@ -104,7 +104,7 @@ static int ixgbevf_get_settings(struct net_device *netdev,
>  	ecmd->transceiver = XCVR_DUMMY1;
>  	ecmd->port = -1;
>  
> -	hw->mac.get_link_status = 1;
> +	hw->mac.get_link_status = true;
>  	hw->mac.ops.check_link(hw, &link_speed, &link_up, false);
>  
>  	if (link_up) {
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> index acc2401..a98e7c2 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> @@ -1285,7 +1285,7 @@ static irqreturn_t ixgbevf_msix_other(int irq, void *data)
>  	struct ixgbevf_adapter *adapter = data;
>  	struct ixgbe_hw *hw = &adapter->hw;
>  
> -	hw->mac.get_link_status = 1;
> +	hw->mac.get_link_status = true;
>  
>  	ixgbevf_service_event_schedule(adapter);
>  
> @@ -2109,7 +2109,7 @@ static void ixgbevf_up_complete(struct ixgbevf_adapter *adapter)
>  	ixgbevf_save_reset_stats(adapter);
>  	ixgbevf_init_last_counter_stats(adapter);
>  
> -	hw->mac.get_link_status = 1;
> +	hw->mac.get_link_status = true;
>  	mod_timer(&adapter->service_timer, jiffies);
>  }
>  

  reply	other threads:[~2016-07-28 14:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27 13:28 [PATCH 1/1] ixgbevf: replace integer number with bool value Zhu Yanjun
2016-07-28 14:29 ` Greg [this message]
2016-07-28 14:29   ` Greg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469716146.14256.1.camel@gmail.com \
    --to=gvrose8192@gmail.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.