From: Joe Perches <joe@perches.com>
To: Kirill Marinushkin <k.marinushkin@gmail.com>, dhowells@redhat.com
Cc: zer0mem@yahoo.com, gregkh@linuxfoundation.org, serge@hallyn.com,
james.l.morris@oracle.com, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] KEYS: Sort out big_key initialisation
Date: Sat, 30 Jul 2016 13:12:30 -0700 [thread overview]
Message-ID: <1469909550.3998.123.camel@perches.com> (raw)
In-Reply-To: <1469909004-28618-1-git-send-email-k.marinushkin@gmail.com>
On Sat, 2016-07-30 at 22:03 +0200, Kirill Marinushkin wrote:
> big_key has two separate initialisation functions, one that registers the
> key type and one that registers the crypto. If the key type fails to
> register, there's no problem if the crypto registers successfully because
> there's no way to reach the crypto except through the key type.
trivia:
> diff --git a/security/keys/big_key.c b/security/keys/big_key.c
[]
> @@ -9,6 +9,7 @@
> * 2 of the Licence, or (at your option) any later version.
> */
>
> +#define pr_fmt(fmt) "big_key: "fmt
It's much more common to use
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Kirill Marinushkin <k.marinushkin@gmail.com>, dhowells@redhat.com
Cc: zer0mem@yahoo.com, gregkh@linuxfoundation.org, serge@hallyn.com,
james.l.morris@oracle.com, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] KEYS: Sort out big_key initialisation
Date: Sat, 30 Jul 2016 13:12:30 -0700 [thread overview]
Message-ID: <1469909550.3998.123.camel@perches.com> (raw)
In-Reply-To: <1469909004-28618-1-git-send-email-k.marinushkin@gmail.com>
On Sat, 2016-07-30 at 22:03 +0200, Kirill Marinushkin wrote:
> big_key has two separate initialisation functions, one that registers the
> key type and one that registers the crypto.��If the key type fails to
> register, there's no problem if the crypto registers successfully because
> there's no way to reach the crypto except through the key type.
trivia:
> diff --git a/security/keys/big_key.c b/security/keys/big_key.c
[]
> @@ -9,6 +9,7 @@
> � * 2 of the Licence, or (at your option) any later version.
> � */
> �
> +#define pr_fmt(fmt) "big_key: "fmt
It's much more common to use
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
next prev parent reply other threads:[~2016-07-30 20:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 20:03 [PATCH] KEYS: Sort out big_key initialisation Kirill Marinushkin
2016-07-30 20:12 ` Joe Perches [this message]
2016-07-30 20:12 ` Joe Perches
2016-08-11 19:17 ` Kirill Marinushkin
-- strict thread matches above, loose matches on Subject: below --
2016-07-30 16:21 Kirill Marinushkin
2016-07-30 17:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469909550.3998.123.camel@perches.com \
--to=joe@perches.com \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.l.morris@oracle.com \
--cc=k.marinushkin@gmail.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
--cc=zer0mem@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.