[Qemu-devel] [Qemu-ppc] [PATCH] ppc: Add MacOS VGA driver ROM

[Qemu-devel] [Qemu-ppc] [PATCH] ppc: Add MacOS VGA driver ROM

[Programmingkid]

> 
> The project is at https://github.com/ozbenh/QemuMacDrivers
> 
> This adds a native MacOS driver in ROM (which can be picked up
> by MacOS once OpenBIOS has been updated if Mark accepts
> the patches I sent him) which allows MacOS classic
> (tested 9.2.1) and MacOS X (tested 10.1.4 and 10.4)
> to properly use QEMU std VGA (10.1.x doesn't work at all
> without it, the others get the ability to change resolution
> and color depth).
> 
> Building the ROM is tricky and requires CodeWarrior for MacOS
> so I include a pre-built binary.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Could we see the patches you sent to Mark? Right now when I try to boot QEMU with your patch I see this message: qemu-system-ppc: Initialization of device VGA failed: failed to find romfile "qemu_vga.ndrv"

Thanks

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Add MacOS VGA driver ROM

[Programmingkid]

On Jul 27, 2016, at 5:49 PM, Benjamin Herrenschmidt wrote:

> On Wed, 2016-07-27 at 10:33 -0400, Programmingkid wrote:
>> Could we see the patches you sent to Mark? Right now when I try to
>> boot QEMU with your patch I see this message: qemu-system-ppc:
>> Initialization of device VGA failed: failed to find romfile
>> "qemu_vga.ndrv"
> 
> Hrm, that error is something else. My commit should have added that
> file, maybe your version of "patch" doesn't grab binary files ?

After updating my patch command to 2.7.5, I saw this error message when I tried applying your patch again:

patching file hw/ppc/mac_newworld.c
File pc-bios/qemu_vga.ndrv: git binary diffs are not supported.

What is your output on "patch -v"?

I think I can just copy and paste the binary into a file and try things that way if necessary.

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Add MacOS VGA driver ROM

[Alexander Graf]

> On 30 Jul 2016, at 17:42, Programmingkid <programmingkidx@gmail.com> wrote:
> 
> 
> On Jul 27, 2016, at 5:49 PM, Benjamin Herrenschmidt wrote:
> 
>> On Wed, 2016-07-27 at 10:33 -0400, Programmingkid wrote:
>>> Could we see the patches you sent to Mark? Right now when I try to
>>> boot QEMU with your patch I see this message: qemu-system-ppc:
>>> Initialization of device VGA failed: failed to find romfile
>>> "qemu_vga.ndrv"
>> 
>> Hrm, that error is something else. My commit should have added that
>> file, maybe your version of "patch" doesn't grab binary files ?
> 
> After updating my patch command to 2.7.5, I saw this error message when I tried applying your patch again:
> 
> patching file hw/ppc/mac_newworld.c
> File pc-bios/qemu_vga.ndrv: git binary diffs are not supported.
> 
> What is your output on "patch -v"?
> 
> I think I can just copy and paste the binary into a file and try things that way if necessary.
> 
> 

Just use “git am” to apply an mbox :)


Alex

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Add MacOS VGA driver ROM

[Benjamin Herrenschmidt]

On Sat, 2016-07-30 at 11:42 -0400, Programmingkid wrote:
> 
> I think I can just copy and paste the binary into a file and try
> things that way if necessary.

Nah, just use git am

Cheers,
Ben.

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Add MacOS VGA driver ROM

[Programmingkid]

I was wondering if you could add the 1200x700 resolution to the list in https://github.com/ozbenh/QemuMacDrivers/blob/master/QemuVGADriver/src/QemuVga.c. This is the perfect resolution for someone using  QEMU on a 13" MacBook Pro. QEMU's window fills most of the screen but still allows for easy access to the dock. Maybe a command-line option could be added that allows the user to specify their own resolutions for QEMU to support.

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Add MacOS VGA driver ROM

[Benjamin Herrenschmidt]

On Sat, 2016-07-30 at 16:28 -0400, Programmingkid wrote:
> I was wondering if you could add the 1200x700 resolution to the list
> in https://github.com/ozbenh/QemuMacDrivers/blob/master/QemuVGADriver
> /src/QemuVga.c. This is the perfect resolution for someone
> using  QEMU on a 13" MacBook Pro. QEMU's window fills most of the
> screen but still allows for easy access to the dock. Maybe a command-
> line option could be added that allows the user to specify their own
> resolutions for QEMU to support.

I can, though I was thinking of being a bit smarter and have qemu
(well, in our case openbios) pass the list of resolutions via the DT. 

If anything, it makes it easier for anybody to change that list without
having to rebuild the MacOS portions.

We'll see what time permits.

Cheers,
Ben.