* [PATCH] drm/i915/debugfs: Take runtime_pm ref for sseu
@ 2016-08-01 14:33 David Weinehall
2016-08-01 14:48 ` Joonas Lahtinen
2016-08-01 14:53 ` ✗ Ro.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 4+ messages in thread
From: David Weinehall @ 2016-08-01 14:33 UTC (permalink / raw)
To: intel-gfx
When reading the SSEU statistics, we need to call
intel_runtime_pm_get() first, otherwise we might end up
triggering "Device suspended during HW access".
Signed-off-by: David Weinehall <david.weinehall@linux.intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 9aa62c5b5f65..531ca0221c7f 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -5238,7 +5238,8 @@ static void broadwell_sseu_device_status(struct drm_device *dev,
static int i915_sseu_status(struct seq_file *m, void *unused)
{
struct drm_info_node *node = (struct drm_info_node *) m->private;
- struct drm_device *dev = node->minor->dev;
+ struct drm_i915_private *dev_priv = to_i915(node->minor->dev);
+ struct drm_device *dev = &dev_priv->drm;
struct sseu_dev_status stat;
if (INTEL_INFO(dev)->gen < 8)
@@ -5268,6 +5269,9 @@ static int i915_sseu_status(struct seq_file *m, void *unused)
seq_puts(m, "SSEU Device Status\n");
memset(&stat, 0, sizeof(stat));
+
+ intel_runtime_pm_get(dev_priv);
+
if (IS_CHERRYVIEW(dev)) {
cherryview_sseu_device_status(dev, &stat);
} else if (IS_BROADWELL(dev)) {
@@ -5275,6 +5279,9 @@ static int i915_sseu_status(struct seq_file *m, void *unused)
} else if (INTEL_INFO(dev)->gen >= 9) {
gen9_sseu_device_status(dev, &stat);
}
+
+ intel_runtime_pm_put(dev_priv);
+
seq_printf(m, " Enabled Slice Total: %u\n",
stat.slice_total);
seq_printf(m, " Enabled Subslice Total: %u\n",
--
2.8.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/debugfs: Take runtime_pm ref for sseu
2016-08-01 14:33 [PATCH] drm/i915/debugfs: Take runtime_pm ref for sseu David Weinehall
@ 2016-08-01 14:48 ` Joonas Lahtinen
2016-08-01 14:54 ` Chris Wilson
2016-08-01 14:53 ` ✗ Ro.CI.BAT: failure for " Patchwork
1 sibling, 1 reply; 4+ messages in thread
From: Joonas Lahtinen @ 2016-08-01 14:48 UTC (permalink / raw)
To: David Weinehall, intel-gfx
On ma, 2016-08-01 at 17:33 +0300, David Weinehall wrote:
> When reading the SSEU statistics, we need to call
> intel_runtime_pm_get() first, otherwise we might end up
> triggering "Device suspended during HW access".
>
> Signed-off-by: David Weinehall <david.weinehall@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 9aa62c5b5f65..531ca0221c7f 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -5238,7 +5238,8 @@ static void broadwell_sseu_device_status(struct drm_device *dev,
> static int i915_sseu_status(struct seq_file *m, void *unused)
> {
> struct drm_info_node *node = (struct drm_info_node *) m->private;
> - struct drm_device *dev = node->minor->dev;
> + struct drm_i915_private *dev_priv = to_i915(node->minor->dev);
> + struct drm_device *dev = &dev_priv->drm;
> struct sseu_dev_status stat;
>
> if (INTEL_INFO(dev)->gen < 8)
> @@ -5268,6 +5269,9 @@ static int i915_sseu_status(struct seq_file *m, void *unused)
>
> seq_puts(m, "SSEU Device Status\n");
> memset(&stat, 0, sizeof(stat));
> +
> + intel_runtime_pm_get(dev_priv);
> +
> if (IS_CHERRYVIEW(dev)) {
> cherryview_sseu_device_status(dev, &stat);
> } else if (IS_BROADWELL(dev)) {
> @@ -5275,6 +5279,9 @@ static int i915_sseu_status(struct seq_file *m, void *unused)
> } else if (INTEL_INFO(dev)->gen >= 9) {
> gen9_sseu_device_status(dev, &stat);
> }
> +
> + intel_runtime_pm_put(dev_priv);
> +
> seq_printf(m, " Enabled Slice Total: %u\n",
> stat.slice_total);
> seq_printf(m, " Enabled Subslice Total: %u\n",
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/debugfs: Take runtime_pm ref for sseu
2016-08-01 14:48 ` Joonas Lahtinen
@ 2016-08-01 14:54 ` Chris Wilson
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2016-08-01 14:54 UTC (permalink / raw)
To: Joonas Lahtinen; +Cc: intel-gfx
On Mon, Aug 01, 2016 at 05:48:51PM +0300, Joonas Lahtinen wrote:
> On ma, 2016-08-01 at 17:33 +0300, David Weinehall wrote:
> > When reading the SSEU statistics, we need to call
> > intel_runtime_pm_get() first, otherwise we might end up
> > triggering "Device suspended during HW access".
> >
> > Signed-off-by: David Weinehall <david.weinehall@linux.intel.com>
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Confidently pushed, thanks.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✗ Ro.CI.BAT: failure for drm/i915/debugfs: Take runtime_pm ref for sseu
2016-08-01 14:33 [PATCH] drm/i915/debugfs: Take runtime_pm ref for sseu David Weinehall
2016-08-01 14:48 ` Joonas Lahtinen
@ 2016-08-01 14:53 ` Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2016-08-01 14:53 UTC (permalink / raw)
To: David Weinehall; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/debugfs: Take runtime_pm ref for sseu
URL : https://patchwork.freedesktop.org/series/10455/
State : failure
== Summary ==
Series 10455v1 drm/i915/debugfs: Take runtime_pm ref for sseu
http://patchwork.freedesktop.org/api/1.0/series/10455/revisions/1/mbox
Test drv_module_reload_basic:
skip -> PASS (ro-ivb-i7-3770)
Test gem_exec_gttfill:
Subgroup basic:
skip -> PASS (fi-snb-i7-2600)
Test kms_cursor_legacy:
Subgroup basic-cursor-vs-flip-varying-size:
pass -> FAIL (ro-ilk1-i5-650)
Subgroup basic-flip-vs-cursor-legacy:
pass -> FAIL (fi-hsw-i7-4770k)
pass -> FAIL (fi-skl-i7-6700k)
Subgroup basic-flip-vs-cursor-varying-size:
fail -> PASS (ro-hsw-i7-4770r)
fail -> PASS (ro-bdw-i5-5250u)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
pass -> INCOMPLETE (fi-hsw-i7-4770k)
dmesg-warn -> PASS (ro-bdw-i7-5557U)
fi-hsw-i7-4770k total:200 pass:178 dwarn:0 dfail:0 fail:1 skip:20
fi-kbl-qkkr total:239 pass:180 dwarn:29 dfail:0 fail:4 skip:26
fi-skl-i5-6260u total:239 pass:223 dwarn:0 dfail:0 fail:2 skip:14
fi-skl-i7-6700k total:239 pass:207 dwarn:0 dfail:0 fail:4 skip:28
fi-snb-i7-2600 total:239 pass:197 dwarn:0 dfail:0 fail:0 skip:42
ro-bdw-i5-5250u total:239 pass:219 dwarn:4 dfail:0 fail:0 skip:16
ro-bdw-i7-5557U total:239 pass:223 dwarn:0 dfail:0 fail:0 skip:16
ro-bdw-i7-5600u total:239 pass:206 dwarn:0 dfail:0 fail:1 skip:32
ro-bsw-n3050 total:239 pass:193 dwarn:0 dfail:0 fail:4 skip:42
ro-hsw-i3-4010u total:239 pass:213 dwarn:0 dfail:0 fail:0 skip:26
ro-hsw-i7-4770r total:239 pass:213 dwarn:0 dfail:0 fail:0 skip:26
ro-ilk-i7-620lm total:239 pass:172 dwarn:1 dfail:0 fail:1 skip:65
ro-ilk1-i5-650 total:234 pass:172 dwarn:0 dfail:0 fail:2 skip:60
ro-ivb-i7-3770 total:239 pass:204 dwarn:0 dfail:0 fail:0 skip:35
ro-ivb2-i7-3770 total:239 pass:208 dwarn:0 dfail:0 fail:0 skip:31
ro-skl3-i5-6260u total:239 pass:221 dwarn:0 dfail:0 fail:4 skip:14
ro-snb-i7-2620M total:239 pass:197 dwarn:0 dfail:0 fail:1 skip:41
ro-byt-n2820 failed to connect after reboot
Results at /archive/results/CI_IGT_test/RO_Patchwork_1655/
f1b78d2 drm-intel-nightly: 2016y-07m-29d-19h-16m-57s UTC integration manifest
a275fd2 drm/i915/debugfs: Take runtime_pm ref for sseu
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-01 14:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-01 14:33 [PATCH] drm/i915/debugfs: Take runtime_pm ref for sseu David Weinehall
2016-08-01 14:48 ` Joonas Lahtinen
2016-08-01 14:54 ` Chris Wilson
2016-08-01 14:53 ` ✗ Ro.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.