From: Gerd Hoffmann <kraxel@redhat.com>
To: Juergen Gross <jgross@suse.com>
Cc: qemu-devel@nongnu.org, xen-devel@lists.xensource.com,
sstabellini@kernel.org, anthony.perard@citrix.com
Subject: Re: [Qemu-devel] [PATCH 2/2] xen: drain submit queue in xen-usb before removing device
Date: Tue, 02 Aug 2016 13:37:36 +0200 [thread overview]
Message-ID: <1470137856.30562.92.camel@redhat.com> (raw)
In-Reply-To: <1469791051-680-3-git-send-email-jgross@suse.com>
On Fr, 2016-07-29 at 13:17 +0200, Juergen Gross wrote:
> When unplugging a device in the Xen pvusb backend drain the submit
> queue before deallocation of the control structures. Otherwise there
> will be bogus memory accesses when I/O contracts are finished.
>
> Correlated to this issue is the handling of cancel requests: a packet
> cancelled will still lead to the call of complete, so add a flag
> A
=== checkpatch complains ===
WARNING: braces {} are necessary for all arms of this statement
#105: FILE: hw/usb/xen-usb.c:696:
+ if (sched)
[...]
WARNING: braces {} are necessary for all arms of this statement
#111: FILE: hw/usb/xen-usb.c:702:
+ if (!usbif->ports[port - 1].attached)
[...]
WARNING: braces {} are necessary for all arms of this statement
#152: FILE: hw/usb/xen-usb.c:847:
+ if (usbif->ports[i].dev)
[...]
cheers,
Gerd
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Juergen Gross <jgross@suse.com>
Cc: anthony.perard@citrix.com, xen-devel@lists.xensource.com,
sstabellini@kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] xen: drain submit queue in xen-usb before removing device
Date: Tue, 02 Aug 2016 13:37:36 +0200 [thread overview]
Message-ID: <1470137856.30562.92.camel@redhat.com> (raw)
In-Reply-To: <1469791051-680-3-git-send-email-jgross@suse.com>
On Fr, 2016-07-29 at 13:17 +0200, Juergen Gross wrote:
> When unplugging a device in the Xen pvusb backend drain the submit
> queue before deallocation of the control structures. Otherwise there
> will be bogus memory accesses when I/O contracts are finished.
>
> Correlated to this issue is the handling of cancel requests: a packet
> cancelled will still lead to the call of complete, so add a flag
> A
=== checkpatch complains ===
WARNING: braces {} are necessary for all arms of this statement
#105: FILE: hw/usb/xen-usb.c:696:
+ if (sched)
[...]
WARNING: braces {} are necessary for all arms of this statement
#111: FILE: hw/usb/xen-usb.c:702:
+ if (!usbif->ports[port - 1].attached)
[...]
WARNING: braces {} are necessary for all arms of this statement
#152: FILE: hw/usb/xen-usb.c:847:
+ if (usbif->ports[i].dev)
[...]
cheers,
Gerd
next prev parent reply other threads:[~2016-08-02 11:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 11:17 [Qemu-devel] [PATCH 0/2] xen: bug fixes in Xen backend handling Juergen Gross
2016-07-29 11:17 ` Juergen Gross
2016-07-29 11:17 ` [Qemu-devel] [PATCH 1/2] xen: when removing a backend don't remove many of them Juergen Gross
2016-07-29 11:17 ` Juergen Gross
2016-08-02 1:26 ` [Qemu-devel] " Stefano Stabellini
2016-08-02 1:26 ` Stefano Stabellini
2016-07-29 11:17 ` [Qemu-devel] [PATCH 2/2] xen: drain submit queue in xen-usb before removing device Juergen Gross
2016-07-29 11:17 ` Juergen Gross
2016-08-02 11:37 ` Gerd Hoffmann [this message]
2016-08-02 11:37 ` Gerd Hoffmann
2016-08-02 11:49 ` [Qemu-devel] " Juergen Gross
2016-08-02 11:49 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470137856.30562.92.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=jgross@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.