All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Purushottam Kushwaha <pkushwah@qti.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, jouni@qca.qualcomm.com,
	usdutt@qti.qualcomm.com, ganeshk@qti.qualcomm.com,
	mkalikot@qca.qualcomm.com, amarnath@qca.qualcomm.com
Subject: Re: [PATCH] cfg80211: Add support for user configurable beacon data rate
Date: Fri, 05 Aug 2016 11:03:04 +0200	[thread overview]
Message-ID: <1470387784.2977.30.camel@sipsolutions.net> (raw)
In-Reply-To: <1470371701-13074-1-git-send-email-pkushwah@qti.qualcomm.com>

On Fri, 2016-08-05 at 10:05 +0530, Purushottam Kushwaha wrote:
> 
> +static int nl80211_parse_tx_bitrate_mask(struct genl_info *info,
> +					 struct cfg80211_bitrate_mask *mask);

I think you should move the function instead.

> @@ -3457,6 +3459,11 @@ static int nl80211_start_ap(struct sk_buff
> *skb, struct genl_info *info)
>  	err = cfg80211_validate_beacon_int(rdev,
> params.beacon_interval);
>  	if (err)
>  		return err;
> +	if (info->attrs[NL80211_ATTR_TX_RATES]) {
> +		err = nl80211_parse_tx_bitrate_mask(info,
> &params.beacon_rate);
> +		if (err)
> +			return err;
> +	}

Doesn't this have to check that it actually got information for the
right band?

johannes

  reply	other threads:[~2016-08-05  9:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-05  4:35 [PATCH] cfg80211: Add support for user configurable beacon data rate Purushottam Kushwaha
2016-08-05  9:03 ` Johannes Berg [this message]
2016-08-06  4:38   ` Undekari, Sunil Dutt
2016-08-06 19:57     ` Johannes Berg
2016-08-24 12:30       ` Undekari, Sunil Dutt
2016-08-26  8:14         ` Johannes Berg
  -- strict thread matches above, loose matches on Subject: below --
2016-07-08 10:28 Purushottam Kushwaha
2016-07-08 10:33 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470387784.2977.30.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=amarnath@qca.qualcomm.com \
    --cc=ganeshk@qti.qualcomm.com \
    --cc=jouni@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mkalikot@qca.qualcomm.com \
    --cc=pkushwah@qti.qualcomm.com \
    --cc=usdutt@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.