From: Johannes Berg <johannes@sipsolutions.net>
To: "Undekari, Sunil Dutt" <usdutt@qti.qualcomm.com>,
"Kushwaha, Purushottam" <pkushwah@qti.qualcomm.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Malinen, Jouni" <jouni@qca.qualcomm.com>,
"Kondabattini, Ganesh" <ganeshk@qti.qualcomm.com>,
"Kalikot Veetil, Mahesh Kumar" <mkalikot@qca.qualcomm.com>,
"Hullur Subramanyam, Amarnath" <amarnath@qca.qualcomm.com>
Subject: Re: [PATCH] cfg80211: Add support for user configurable beacon data rate
Date: Sat, 06 Aug 2016 21:57:34 +0200 [thread overview]
Message-ID: <1470513454.3374.1.camel@sipsolutions.net> (raw)
In-Reply-To: <92b06d4df5984e6ea91081126e096a96@aphydexm01f.ap.qualcomm.com>
On Sat, 2016-08-06 at 04:38 +0000, Undekari, Sunil Dutt wrote:
> >
> > Doesn't this have to check that it actually got information for the
> > right band?
> Hi Johannes ,
> nl80211_parse_tx_bitrate_mask ( a new wrapper to the existing
> functionality in nl80211_set_tx_bitrate_mask ) does this , isn't ?
>
It checks that everything matches up with capabilities, but it doesn't
check that if you specified NL80211_ATTR_TX_RATES you didn't do
something stupid like specifying it for 2.4GHz while your AP is
starting up on 5GHz.
It also doesn't check that you specified exactly one rate, but it's not
clear how else this would work?
johannes
next prev parent reply other threads:[~2016-08-06 20:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 4:35 [PATCH] cfg80211: Add support for user configurable beacon data rate Purushottam Kushwaha
2016-08-05 9:03 ` Johannes Berg
2016-08-06 4:38 ` Undekari, Sunil Dutt
2016-08-06 19:57 ` Johannes Berg [this message]
2016-08-24 12:30 ` Undekari, Sunil Dutt
2016-08-26 8:14 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2016-07-08 10:28 Purushottam Kushwaha
2016-07-08 10:33 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470513454.3374.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=amarnath@qca.qualcomm.com \
--cc=ganeshk@qti.qualcomm.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mkalikot@qca.qualcomm.com \
--cc=pkushwah@qti.qualcomm.com \
--cc=usdutt@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.