From: Johannes Berg <johannes@sipsolutions.net>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/11] net/fsl: use of_property_read_bool
Date: Fri, 05 Aug 2016 10:12:28 +0000 [thread overview]
Message-ID: <1470391948.2977.33.camel@sipsolutions.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1608051207510.2999@hadrien>
On Fri, 2016-08-05 at 12:08 +0200, Julia Lawall wrote:
>
> Can I do the same for:
>
> if (of_property_read_bool(np, "phy-clk-valid"))
> pdata->check_phy_clk_valid = 1;
> else
> pdata->check_phy_clk_valid = 0;
>
> The type is not bool, but:
>
> include/linux/fsl_devices.h: unsigned check_phy_clk_valid:1;
>
The type doesn't even matter, does it? Any bool->int conversion should
result in 0/1.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/11] net/fsl: use of_property_read_bool
Date: Fri, 05 Aug 2016 12:12:28 +0200 [thread overview]
Message-ID: <1470391948.2977.33.camel@sipsolutions.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1608051207510.2999@hadrien>
On Fri, 2016-08-05 at 12:08 +0200, Julia Lawall wrote:
>
> Can I do the same for:
>
> if (of_property_read_bool(np, "phy-clk-valid"))
> pdata->check_phy_clk_valid = 1;
> else
> pdata->check_phy_clk_valid = 0;
>
> The type is not bool, but:
>
> include/linux/fsl_devices.h: unsigned check_phy_clk_valid:1;
>
The type doesn't even matter, does it? Any bool->int conversion should
result in 0/1.
johannes
next prev parent reply other threads:[~2016-08-05 10:12 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-05 8:56 ` [PATCH 01/11] fsl/qe: " Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-05 8:56 ` [PATCH 02/11] usb: host: fsl-mph-dr-of: " Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-05 11:26 ` [PATCH 02/11 v2] " Julia Lawall
2016-08-05 11:26 ` Julia Lawall
2016-08-05 8:56 ` [PATCH 03/11] pinctrl: nomadik: " Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-05 11:26 ` [PATCH 03/11 v2] " Julia Lawall
2016-08-05 11:26 ` Julia Lawall
2016-08-05 11:26 ` Julia Lawall
2016-08-11 11:52 ` [PATCH 03/11] " Linus Walleij
2016-08-11 11:52 ` Linus Walleij
2016-08-11 11:52 ` Linus Walleij
2016-08-05 8:56 ` [PATCH 04/11] i2c: mpc: " Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2017-10-27 20:15 ` [04/11] " Wolfram Sang
2017-10-27 20:15 ` Wolfram Sang
2016-08-05 8:56 ` [PATCH 05/11] tty/serial: at91: " Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-05 8:56 ` [PATCH 06/11] mmc: sdhci-of-esdhc: " Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-18 7:36 ` Adrian Hunter
2016-08-18 7:36 ` Adrian Hunter
2016-08-22 13:39 ` Ulf Hansson
2016-08-22 13:39 ` Ulf Hansson
2016-08-05 8:56 ` [PATCH 07/11] phy: qcom-ufs: " Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-05 11:25 ` [PATCH 07/11 v2] " Julia Lawall
2016-08-05 11:25 ` Julia Lawall
2016-08-12 10:02 ` Kishon Vijay Abraham I
2016-08-12 10:14 ` Kishon Vijay Abraham I
2016-08-05 8:56 ` [PATCH 08/11] net/fsl: " Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-05 9:30 ` Johannes Berg
2016-08-05 9:30 ` Johannes Berg
2016-08-05 9:47 ` Julia Lawall
2016-08-05 9:47 ` Julia Lawall
2016-08-05 10:08 ` Julia Lawall
2016-08-05 10:08 ` Julia Lawall
2016-08-05 10:12 ` Johannes Berg [this message]
2016-08-05 10:12 ` Johannes Berg
2016-08-05 10:14 ` Julia Lawall
2016-08-05 10:14 ` Julia Lawall
2016-08-05 11:24 ` [PATCH 08/11 v2] " Julia Lawall
2016-08-05 11:24 ` Julia Lawall
2016-08-05 11:35 ` [PATCH 08/11] " Sergei Shtylyov
2016-08-05 11:35 ` Sergei Shtylyov
2016-08-05 11:38 ` Julia Lawall
2016-08-05 11:38 ` Julia Lawall
2016-08-05 11:40 ` Sergei Shtylyov
2016-08-05 11:40 ` Sergei Shtylyov
2016-08-05 8:56 ` [PATCH 09/11] powerpc/mpic: " Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-08 6:37 ` Michael Ellerman
2016-08-08 6:37 ` Michael Ellerman
2016-08-05 8:56 ` [PATCH 10/11] soc: ti: knav_qmss_queue: " Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-05 12:47 ` Robin Murphy
2016-08-05 12:47 ` Robin Murphy
2016-08-05 12:47 ` Robin Murphy
2016-08-05 12:47 ` Robin Murphy
2016-08-05 12:59 ` Julia Lawall
2016-08-05 12:59 ` Julia Lawall
2016-08-05 12:59 ` Julia Lawall
2016-08-05 8:56 ` [PATCH 11/11] ASoC: " Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-05 8:56 ` Julia Lawall
2016-08-05 12:09 ` Applied "ASoC: use of_property_read_bool" to the asoc tree Mark Brown
2016-08-05 12:09 ` Mark Brown
2016-08-05 12:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470391948.2977.33.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.