All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: c_mkenna@qti.qualcomm.com, ath10k@lists.infradead.org,
	Andrew Morton <akpm@linux-foundation.org>
Cc: mkenna@codeaurora.org, linux-wireless@vger.kernel.org,
	Kees Cook <keescook@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ath10k: hide kernel addresses from logs using %pK format specifier
Date: Fri, 05 Aug 2016 10:57:42 -0700	[thread overview]
Message-ID: <1470419862.28648.11.camel@perches.com> (raw)
In-Reply-To: <1470318711-28986-1-git-send-email-c_mkenna@qti.qualcomm.com>

On Thu, 2016-08-04 at 19:21 +0530, c_mkenna@qti.qualcomm.com wrote:
> From: Maharaja Kennadyrajan <c_mkenna@qti.qualcomm.com>
> 
> With the %pK format specifier we hide the kernel addresses
> with the help of kptr_restrict sysctl.
> In this patch, %p is changed to %pK in the driver code.
> 
> The sysctl is documented in Documentation/sysctl/kernel.txt.

Maybe %p should follow %pK and only show kernel .text addresses
by default and any other address as 0 unless the sysctl is set.


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: c_mkenna@qti.qualcomm.com, ath10k@lists.infradead.org,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-wireless@vger.kernel.org, mkenna@codeaurora.org,
	Kees Cook <keescook@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ath10k: hide kernel addresses from logs using %pK format specifier
Date: Fri, 05 Aug 2016 10:57:42 -0700	[thread overview]
Message-ID: <1470419862.28648.11.camel@perches.com> (raw)
In-Reply-To: <1470318711-28986-1-git-send-email-c_mkenna@qti.qualcomm.com>

On Thu, 2016-08-04 at 19:21 +0530, c_mkenna@qti.qualcomm.com wrote:
> From: Maharaja Kennadyrajan <c_mkenna@qti.qualcomm.com>
> 
> With the %pK format specifier we hide the kernel addresses
> with the help of kptr_restrict sysctl.
> In this patch, %p is changed to %pK in the driver code.
> 
> The sysctl is documented in Documentation/sysctl/kernel.txt.

Maybe %p should follow %pK and only show kernel .text addresses
by default and any other address as 0 unless the sysctl is set.


  reply	other threads:[~2016-08-05 17:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04 13:51 [PATCH] ath10k: hide kernel addresses from logs using %pK format specifier c_mkenna
2016-08-04 13:51 ` c_mkenna
2016-08-05 17:57 ` Joe Perches [this message]
2016-08-05 17:57   ` Joe Perches
2016-09-02 15:29 ` Kalle Valo
2016-09-02 15:29   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470419862.28648.11.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=ath10k@lists.infradead.org \
    --cc=c_mkenna@qti.qualcomm.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mkenna@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.