All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "can: fix handling of unmodifiable configuration options fix" has been added to the 4.4-stable tree
@ 2016-08-08 13:42 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-08-08 13:42 UTC (permalink / raw)
  To: socketcan, ajneu1, gregkh, mkl; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    can: fix handling of unmodifiable configuration options fix

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     can-fix-handling-of-unmodifiable-configuration-options-fix.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From bce271f255dae8335dc4d2ee2c4531e09cc67f5a Mon Sep 17 00:00:00 2001
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: Tue, 21 Jun 2016 12:14:07 +0200
Subject: can: fix handling of unmodifiable configuration options fix

From: Oliver Hartkopp <socketcan@hartkopp.net>

commit bce271f255dae8335dc4d2ee2c4531e09cc67f5a upstream.

With upstream commit bb208f144cf3f59 (can: fix handling of unmodifiable
configuration options) a new can_validate() function was introduced.

When invoking 'ip link set can0 type can' without any configuration data
can_validate() tries to validate the content without taking into account that
there's totally no content. This patch adds a check for missing content.

Reported-by: ajneu <ajneu1@gmail.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/net/can/dev.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/drivers/net/can/dev.c
+++ b/drivers/net/can/dev.c
@@ -798,6 +798,9 @@ static int can_validate(struct nlattr *t
 	 * - control mode with CAN_CTRLMODE_FD set
 	 */
 
+	if (!data)
+		return 0;
+
 	if (data[IFLA_CAN_CTRLMODE]) {
 		struct can_ctrlmode *cm = nla_data(data[IFLA_CAN_CTRLMODE]);
 


Patches currently in stable-queue which might be from socketcan@hartkopp.net are

queue-4.4/can-fix-oops-caused-by-wrong-rtnl-dellink-usage.patch
queue-4.4/can-fix-handling-of-unmodifiable-configuration-options-fix.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-08 13:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-08 13:42 Patch "can: fix handling of unmodifiable configuration options fix" has been added to the 4.4-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.