All of lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Dave Gordon <david.s.gordon@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Restore DMC required version for Skylake (1.26)
Date: Wed, 10 Aug 2016 15:41:20 +0300	[thread overview]
Message-ID: <1470832880.16187.1.camel@intel.com> (raw)
In-Reply-To: <2814bc5a-9a8c-cd08-f65b-81fa94fbe379@intel.com>

On ke, 2016-08-10 at 12:26 +0100, Dave Gordon wrote:
> On 10/08/16 06:57, Rodrigo Vivi wrote:
> > With commit 4aa7fb9c ("drm/i915/dmc: Step away from symbolic
> > links") we started loading the firmware version directly
> > instead of symbolic links.
> 
> However the pathnames in the patch context below are still the
> symlink 
> names -- is this correct? Or did some merge effectively revert
> Patrik's 
> changes by accident?

Yes, looks like 94558e265b95 reverted partially his changes.

> 
> > With this VERSION_REQUIRED variables changed the meaning
> > from minimal required to exact version required. Along
> > with this change we started using the latest stable
> > DMC firmware as the required one 1.26.
> > 
> > This patch is correct. However in some merge this
> > change got missed and it was overwritten by the old
> > version.
> > 
> > 1.23 is unstable and can cause blank screens so let's
> > avoid it.
> > 
> > Cc: stable@vger.kernel.org
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
> > Cc: Matthew Atwood <matthew.s.atwood@intel.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97182
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_csr.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_csr.c
> > b/drivers/gpu/drm/i915/intel_csr.c
> > index fb27d18..0efce3f 100644
> > --- a/drivers/gpu/drm/i915/intel_csr.c
> > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > @@ -40,7 +40,7 @@ MODULE_FIRMWARE(I915_CSR_KBL);
> > 
> >  #define I915_CSR_SKL "i915/skl_dmc_ver1.bin"
> 
> Major version only here?
> 
> >  MODULE_FIRMWARE(I915_CSR_SKL);
> > -#define SKL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 23)
> > +#define SKL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 26)
> > 
> >  #define I915_CSR_BXT "i915/bxt_dmc_ver1.bin"
> 
> And here too.
> 
> >  MODULE_FIRMWARE(I915_CSR_BXT);
> 
> .Dave.
> 
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Imre Deak <imre.deak@intel.com>
To: Dave Gordon <david.s.gordon@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Restore DMC required version for Skylake (1.26)
Date: Wed, 10 Aug 2016 15:41:20 +0300	[thread overview]
Message-ID: <1470832880.16187.1.camel@intel.com> (raw)
In-Reply-To: <2814bc5a-9a8c-cd08-f65b-81fa94fbe379@intel.com>

On ke, 2016-08-10 at 12:26 +0100, Dave Gordon wrote:
> On 10/08/16 06:57, Rodrigo Vivi wrote:
> > With commit 4aa7fb9c ("drm/i915/dmc: Step away from symbolic
> > links") we started loading the firmware version directly
> > instead of symbolic links.
> 
> However the pathnames in the patch context below are still the
> symlink 
> names -- is this correct? Or did some merge effectively revert
> Patrik's 
> changes by accident?

Yes, looks like 94558e265b95 reverted partially his changes.

> 
> > With this VERSION_REQUIRED variables changed the meaning
> > from minimal required to exact version required. Along
> > with this change we started using the latest stable
> > DMC firmware as the required one 1.26.
> > 
> > This patch is correct. However in some merge this
> > change got missed and it was overwritten by the old
> > version.
> > 
> > 1.23 is unstable and can cause blank screens so let's
> > avoid it.
> > 
> > Cc: stable@vger.kernel.org
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
> > Cc: Matthew Atwood <matthew.s.atwood@intel.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97182
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_csr.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_csr.c
> > b/drivers/gpu/drm/i915/intel_csr.c
> > index fb27d18..0efce3f 100644
> > --- a/drivers/gpu/drm/i915/intel_csr.c
> > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > @@ -40,7 +40,7 @@ MODULE_FIRMWARE(I915_CSR_KBL);
> > 
> >  #define I915_CSR_SKL "i915/skl_dmc_ver1.bin"
> 
> Major version only here?
> 
> >  MODULE_FIRMWARE(I915_CSR_SKL);
> > -#define SKL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 23)
> > +#define SKL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 26)
> > 
> >  #define I915_CSR_BXT "i915/bxt_dmc_ver1.bin"
> 
> And here too.
> 
> >  MODULE_FIRMWARE(I915_CSR_BXT);
> 
> .Dave.
> 
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-08-10 12:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10  5:57 [PATCH] drm/i915: Restore DMC required version for Skylake (1.26) Rodrigo Vivi
2016-08-10  5:57 ` Rodrigo Vivi
2016-08-10  7:55 ` Jani Nikula
2016-08-10  7:55   ` Jani Nikula
2016-08-11 15:48   ` Vivi, Rodrigo
2016-08-11 15:48     ` Vivi, Rodrigo
2016-08-10 11:24 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-08-10 11:26 ` [PATCH] " Dave Gordon
2016-08-10 11:26   ` [Intel-gfx] " Dave Gordon
2016-08-10 12:41   ` Imre Deak [this message]
2016-08-10 12:41     ` Imre Deak
2016-08-10 14:41   ` [PATCH] drm/i915: Restore DMC file names and the proper 1.26 for SKL Rodrigo Vivi
2016-08-10 14:41     ` Rodrigo Vivi
2016-08-10 15:23     ` Dave Gordon
2016-08-10 15:23       ` Dave Gordon
2016-08-10 16:05 ` ✗ Ro.CI.BAT: failure for drm/i915: Restore DMC required version for Skylake (1.26) (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470832880.16187.1.camel@intel.com \
    --to=imre.deak@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=david.s.gordon@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.