* [PATCH] kasan: remove the unnecessary WARN_ONCE from quarantine.c
@ 2016-08-11 15:26 ` Alexander Potapenko
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Potapenko @ 2016-08-11 15:26 UTC (permalink / raw)
To: dvyukov, kcc, aryabinin, adech.fo, cl, akpm, rostedt, js1304,
iamjoonsoo.kim, kuthonuzo.luruo
Cc: kasan-dev, linux-kernel, linux-mm
It's quite unlikely that the user will so little memory that the
per-CPU quarantines won't fit into the given fraction of the available
memory. Even in that case he won't be able to do anything with the
information given in the warning.
Signed-off-by: Alexander Potapenko <glider@google.com>
---
mm/kasan/quarantine.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c
index b6728a3..baabaad 100644
--- a/mm/kasan/quarantine.c
+++ b/mm/kasan/quarantine.c
@@ -217,11 +217,8 @@ void quarantine_reduce(void)
new_quarantine_size = (READ_ONCE(totalram_pages) << PAGE_SHIFT) /
QUARANTINE_FRACTION;
percpu_quarantines = QUARANTINE_PERCPU_SIZE * num_online_cpus();
- if (WARN_ONCE(new_quarantine_size < percpu_quarantines,
- "Too little memory, disabling global KASAN quarantine.\n"))
- new_quarantine_size = 0;
- else
- new_quarantine_size -= percpu_quarantines;
+ new_quarantine_size = (new_quarantine_size < percpu_quarantines) ?
+ 0 : new_quarantine_size - percpu_quarantines;
WRITE_ONCE(quarantine_size, new_quarantine_size);
last = global_quarantine.head;
--
2.8.0.rc3.226.g39d4020
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] kasan: remove the unnecessary WARN_ONCE from quarantine.c
@ 2016-08-11 15:26 ` Alexander Potapenko
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Potapenko @ 2016-08-11 15:26 UTC (permalink / raw)
To: dvyukov, kcc, aryabinin, adech.fo, cl, akpm, rostedt, js1304,
iamjoonsoo.kim, kuthonuzo.luruo
Cc: kasan-dev, linux-kernel, linux-mm
It's quite unlikely that the user will so little memory that the
per-CPU quarantines won't fit into the given fraction of the available
memory. Even in that case he won't be able to do anything with the
information given in the warning.
Signed-off-by: Alexander Potapenko <glider@google.com>
---
mm/kasan/quarantine.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c
index b6728a3..baabaad 100644
--- a/mm/kasan/quarantine.c
+++ b/mm/kasan/quarantine.c
@@ -217,11 +217,8 @@ void quarantine_reduce(void)
new_quarantine_size = (READ_ONCE(totalram_pages) << PAGE_SHIFT) /
QUARANTINE_FRACTION;
percpu_quarantines = QUARANTINE_PERCPU_SIZE * num_online_cpus();
- if (WARN_ONCE(new_quarantine_size < percpu_quarantines,
- "Too little memory, disabling global KASAN quarantine.\n"))
- new_quarantine_size = 0;
- else
- new_quarantine_size -= percpu_quarantines;
+ new_quarantine_size = (new_quarantine_size < percpu_quarantines) ?
+ 0 : new_quarantine_size - percpu_quarantines;
WRITE_ONCE(quarantine_size, new_quarantine_size);
last = global_quarantine.head;
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kasan: remove the unnecessary WARN_ONCE from quarantine.c
2016-08-11 15:26 ` Alexander Potapenko
@ 2016-08-11 15:32 ` Andrey Ryabinin
-1 siblings, 0 replies; 4+ messages in thread
From: Andrey Ryabinin @ 2016-08-11 15:32 UTC (permalink / raw)
To: Alexander Potapenko, dvyukov, kcc, adech.fo, cl, akpm, rostedt,
js1304, iamjoonsoo.kim, kuthonuzo.luruo
Cc: kasan-dev, linux-kernel, linux-mm
On 08/11/2016 06:26 PM, Alexander Potapenko wrote:
> It's quite unlikely that the user will so little memory that the
> per-CPU quarantines won't fit into the given fraction of the available
> memory. Even in that case he won't be able to do anything with the
> information given in the warning.
>
> Signed-off-by: Alexander Potapenko <glider@google.com>
Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kasan: remove the unnecessary WARN_ONCE from quarantine.c
@ 2016-08-11 15:32 ` Andrey Ryabinin
0 siblings, 0 replies; 4+ messages in thread
From: Andrey Ryabinin @ 2016-08-11 15:32 UTC (permalink / raw)
To: Alexander Potapenko, dvyukov, kcc, adech.fo, cl, akpm, rostedt,
js1304, iamjoonsoo.kim, kuthonuzo.luruo
Cc: kasan-dev, linux-kernel, linux-mm
On 08/11/2016 06:26 PM, Alexander Potapenko wrote:
> It's quite unlikely that the user will so little memory that the
> per-CPU quarantines won't fit into the given fraction of the available
> memory. Even in that case he won't be able to do anything with the
> information given in the warning.
>
> Signed-off-by: Alexander Potapenko <glider@google.com>
Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-11 15:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-11 15:26 [PATCH] kasan: remove the unnecessary WARN_ONCE from quarantine.c Alexander Potapenko
2016-08-11 15:26 ` Alexander Potapenko
2016-08-11 15:32 ` Andrey Ryabinin
2016-08-11 15:32 ` Andrey Ryabinin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.