All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev)
To: linux-snps-arc@lists.infradead.org
Subject: Wrong "nollp" DW DMAC parameter value on ARC SDP.
Date: Fri, 12 Aug 2016 08:03:14 +0000	[thread overview]
Message-ID: <1470988994.21247.33.camel@synopsys.com> (raw)

Hi,

"nollp" parameter defines if DW DMAC channel supports multi block
transfer or not.

It is calculated in runtime, but differently depending on on
availability of pdata. If pdata is absent "nollp" is calculated using
autoconfig hardware registers. Otherwise "nollp" is calculated using
the next code construction:
channel_writel(dwc, LLP, DWC_LLP_LOC(0xffffffff));
dwc->nollp = DWC_LLP_LOC(channel_readl(dwc, LLP)) == 0;
channel_writel(dwc, LLP, 0);

I realized that these methods give different results.
For example on ARC AXS101 SDP in case of using autoconfig "nollp" was
calculated as "true" (and DMAC works fine),?
otherwise "nollp" was calculated as "false" (and DMAC doesn't work).

So I'm wondering how the code in question really works?

WARNING: multiple messages have this Message-ID (diff)
From: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
To: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"andriy.shevchenko@linux.intel.com" 
	<andriy.shevchenko@linux.intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Nelson Pereira" <Nelson.Pereira@synopsys.com>,
	"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
	"vinod.koul@intel.com" <vinod.koul@intel.com>,
	"linux-snps-arc@lists.infradead.org" 
	<linux-snps-arc@lists.infradead.org>
Subject: Wrong "nollp" DW DMAC parameter value on ARC SDP.
Date: Fri, 12 Aug 2016 08:03:14 +0000	[thread overview]
Message-ID: <1470988994.21247.33.camel@synopsys.com> (raw)

Hi,

"nollp" parameter defines if DW DMAC channel supports multi block
transfer or not.

It is calculated in runtime, but differently depending on on
availability of pdata. If pdata is absent "nollp" is calculated using
autoconfig hardware registers. Otherwise "nollp" is calculated using
the next code construction:
channel_writel(dwc, LLP, DWC_LLP_LOC(0xffffffff));
dwc->nollp = DWC_LLP_LOC(channel_readl(dwc, LLP)) == 0;
channel_writel(dwc, LLP, 0);

I realized that these methods give different results.
For example on ARC AXS101 SDP in case of using autoconfig "nollp" was
calculated as "true" (and DMAC works fine), 
otherwise "nollp" was calculated as "false" (and DMAC doesn't work).

So I'm wondering how the code in question really works?
>From DW AHB DMAC databook I wasn't able to find anything relevant to
this tricky implementation. Could you please clarify a little but what
happens here?
Maybe we should add "nollp" field in pdata structure and receive it
from pdata/device tree (like we use "is_private" or "is_memcpu" fields)

-- 
 Paltsev Eugeniy

             reply	other threads:[~2016-08-12  8:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-12  8:03 Eugeniy Paltsev [this message]
2016-08-12  8:03 ` Wrong "nollp" DW DMAC parameter value on ARC SDP Eugeniy Paltsev
2016-08-12 10:59 ` Andy Shevchenko
2016-08-12 10:59   ` Andy Shevchenko
2016-08-12 13:36   ` Eugeniy Paltsev
2016-08-12 13:36     ` Eugeniy Paltsev
2016-08-12 14:08     ` Andy Shevchenko
2016-08-12 14:08       ` Andy Shevchenko
2016-08-15 11:10       ` Eugeniy Paltsev
2016-08-15 11:10         ` Eugeniy Paltsev
2016-08-15 12:41         ` Andy Shevchenko
2016-08-15 12:41           ` Andy Shevchenko
2016-08-16 11:32           ` Eugeniy Paltsev
2016-08-16 11:32             ` Eugeniy Paltsev
2016-08-16 11:46             ` Andy Shevchenko
2016-08-16 11:46               ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470988994.21247.33.camel@synopsys.com \
    --to=eugeniy.paltsev@synopsys.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.