From: daniel.verkamp@intel.com (Verkamp, Daniel)
Subject: [PATCH v1 3/5] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize
Date: Mon, 15 Aug 2016 15:54:05 +0000 [thread overview]
Message-ID: <1471276442.3070.1.camel@intel.com> (raw)
In-Reply-To: <1471046692-15978-4-git-send-email-james_p_freyensee@linux.intel.com>
On Fri, 2016-08-12@17:04 -0700, Jay Freyensee wrote:
> Now that the host will be sending sqsize 0-based values,
> the target need to be adjusted as well.
>
> Signed-off-by: Jay Freyensee <james_p_freyensee at linux.intel.com>
> ---
> ?drivers/nvme/target/rdma.c | 8 ++++----
> ?1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
> index e06d504..d7cb98d 100644
> --- a/drivers/nvme/target/rdma.c
> +++ b/drivers/nvme/target/rdma.c
> @@ -1004,11 +1004,11 @@ nvmet_rdma_parse_cm_connect_req(struct
> rdma_conn_param *conn,
> ? queue->host_qid = le16_to_cpu(req->qid);
> ?
> ? /*
> - ?* req->hsqsize corresponds to our recv queue size
> - ?* req->hrqsize corresponds to our send queue size
> + ?* req->hsqsize corresponds to our recv queue size plus 1
> + ?* req->hrqsize corresponds to our send queue size plus 1
> ? ?*/
> - queue->recv_queue_size = le16_to_cpu(req->hsqsize);
> - queue->send_queue_size = le16_to_cpu(req->hrqsize);
> + queue->recv_queue_size = le16_to_cpu(req->hsqsize + 1);
> + queue->send_queue_size = le16_to_cpu(req->hrqsize + 1);
I think the + 1 needs to be outside le16_to_cpu() here so the math is
done in the native CPU byte order.
-- Daniel
next prev parent reply other threads:[~2016-08-15 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 0:04 [PATCH v1 0/5] sqsize fixes Jay Freyensee
2016-08-13 0:04 ` [PATCH v1 1/5] fabrics: define admin sqsize min default, per spec Jay Freyensee
2016-08-15 15:55 ` Verkamp, Daniel
2016-08-13 0:04 ` [PATCH v1 2/5] nvme-rdma: fix sqsize/hsqsize " Jay Freyensee
2016-08-13 0:04 ` [PATCH v1 3/5] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize Jay Freyensee
2016-08-15 15:54 ` Verkamp, Daniel [this message]
2016-08-15 16:15 ` J Freyensee
2016-08-13 0:04 ` [PATCH v1 4/5] nvme-loop: set sqsize to 0-based value, per spec Jay Freyensee
2016-08-13 0:04 ` [PATCH v1 5/5] nvme-rdma: adjust hrqsize to plus 1 Jay Freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471276442.3070.1.camel@intel.com \
--to=daniel.verkamp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.