From: daniel.verkamp@intel.com (Verkamp, Daniel)
Subject: [PATCH v1 1/5] fabrics: define admin sqsize min default, per spec
Date: Mon, 15 Aug 2016 15:55:48 +0000 [thread overview]
Message-ID: <1471276545.3070.3.camel@intel.com> (raw)
In-Reply-To: <1471046692-15978-2-git-send-email-james_p_freyensee@linux.intel.com>
On Fri, 2016-08-12@17:04 -0700, Jay Freyensee wrote:
> Upon admin queue connect(), the rdma qp was being
> set based on NVMF_AQ_DEPTH.??However, the fabrics layer was
> using the sqsize field value set for I/O queues for the admin
> queue, which through the nvme layer and rdma layer off-whack:
Minor grammar nit: "through" -> "threw".
Otherwise looks OK to me (given the following patches that fix up the
non-AQ case are also applied).
Thanks,
-- Daniel
next prev parent reply other threads:[~2016-08-15 15:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 0:04 [PATCH v1 0/5] sqsize fixes Jay Freyensee
2016-08-13 0:04 ` [PATCH v1 1/5] fabrics: define admin sqsize min default, per spec Jay Freyensee
2016-08-15 15:55 ` Verkamp, Daniel [this message]
2016-08-13 0:04 ` [PATCH v1 2/5] nvme-rdma: fix sqsize/hsqsize " Jay Freyensee
2016-08-13 0:04 ` [PATCH v1 3/5] nvmet-rdma: +1 to *queue_size from hsqsize/hrqsize Jay Freyensee
2016-08-15 15:54 ` Verkamp, Daniel
2016-08-15 16:15 ` J Freyensee
2016-08-13 0:04 ` [PATCH v1 4/5] nvme-loop: set sqsize to 0-based value, per spec Jay Freyensee
2016-08-13 0:04 ` [PATCH v1 5/5] nvme-rdma: adjust hrqsize to plus 1 Jay Freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471276545.3070.3.camel@intel.com \
--to=daniel.verkamp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.