From: Andrea Bolognani <abologna@redhat.com>
To: Andrew Jones <drjones@redhat.com>, Wei Huang <wei@redhat.com>
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org,
qemu-devel@nongnu.org, shannon.zhao@linaro.org
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH V1 1/1] arm64: Add an option to turn on/off host-backed vPMU support
Date: Mon, 15 Aug 2016 18:59:34 +0200 [thread overview]
Message-ID: <1471280374.3003.10.camel@redhat.com> (raw)
In-Reply-To: <20160815100938.vve6hknieytt2ys7@kamzik.localdomain>
On Mon, 2016-08-15 at 12:09 +0200, Andrew Jones wrote:
> Hmm... so now if the user doesn't specify pmu=on (off by default) then we
> silently disable it (I think that's a 2.6 compat issue), and if they do
> specify pmu=on, but KVM doesn't support it, then it's silently disabled,
> which isn't nice. I think QEMU should error out in that case, explaining
> that the user specified incompatible options, i.e. they selected accel=kvm
> and pmu=on, but their KVM version (or cpu model) doesn't support PMU
> emulation.
I agree. Asking qemu to provide a feature that it can't provide
should definitely result in a big fat error.
--
Andrea Bolognani / Red Hat / Virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Bolognani <abologna@redhat.com>
To: Andrew Jones <drjones@redhat.com>, Wei Huang <wei@redhat.com>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
peter.maydell@linaro.org, shannon.zhao@linaro.org
Subject: Re: [Qemu-devel] [PATCH V1 1/1] arm64: Add an option to turn on/off host-backed vPMU support
Date: Mon, 15 Aug 2016 18:59:34 +0200 [thread overview]
Message-ID: <1471280374.3003.10.camel@redhat.com> (raw)
In-Reply-To: <20160815100938.vve6hknieytt2ys7@kamzik.localdomain>
On Mon, 2016-08-15 at 12:09 +0200, Andrew Jones wrote:
> Hmm... so now if the user doesn't specify pmu=on (off by default) then we
> silently disable it (I think that's a 2.6 compat issue), and if they do
> specify pmu=on, but KVM doesn't support it, then it's silently disabled,
> which isn't nice. I think QEMU should error out in that case, explaining
> that the user specified incompatible options, i.e. they selected accel=kvm
> and pmu=on, but their KVM version (or cpu model) doesn't support PMU
> emulation.
I agree. Asking qemu to provide a feature that it can't provide
should definitely result in a big fat error.
--
Andrea Bolognani / Red Hat / Virtualization
next prev parent reply other threads:[~2016-08-15 16:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 5:52 [Qemu-arm] [PATCH V1 1/1] arm64: Add an option to turn on/off host-backed vPMU support Wei Huang
2016-08-13 5:52 ` [Qemu-devel] " Wei Huang
2016-08-15 9:31 ` [Qemu-arm] " Andrea Bolognani
2016-08-15 9:31 ` [Qemu-devel] " Andrea Bolognani
2016-08-15 16:12 ` [Qemu-arm] " Wei Huang
2016-08-15 16:12 ` [Qemu-devel] " Wei Huang
2016-08-15 17:24 ` [Qemu-arm] " Andrea Bolognani
2016-08-15 17:24 ` [Qemu-devel] " Andrea Bolognani
2016-08-15 10:09 ` [Qemu-arm] " Andrew Jones
2016-08-15 10:09 ` Andrew Jones
2016-08-15 16:59 ` Andrea Bolognani [this message]
2016-08-15 16:59 ` Andrea Bolognani
2016-08-15 21:05 ` [Qemu-arm] " Wei Huang
2016-08-15 21:05 ` Wei Huang
2016-08-15 16:13 ` [Qemu-arm] " Peter Maydell
2016-08-15 16:13 ` [Qemu-devel] " Peter Maydell
2016-08-15 21:15 ` Wei Huang
2016-08-15 21:15 ` Wei Huang
2016-08-19 17:05 ` [Qemu-arm] " Wei Huang
2016-08-19 17:05 ` Wei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471280374.3003.10.camel@redhat.com \
--to=abologna@redhat.com \
--cc=drjones@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.