From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH 1/2] staging: lustre: Add include path to Makefile
Date: Mon, 15 Aug 2016 14:14:18 -0700 [thread overview]
Message-ID: <1471295658.4075.117.camel@perches.com> (raw)
In-Reply-To: <20160815210420.GA30864@kroah.com>
On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
> > Start to rationalize include paths in source code files.
[]
> > diff --git a/drivers/staging/lustre/Makefile b/drivers/staging/lustre/Makefile
[]
> > @@ -1,2 +1,5 @@
> > +subdir-ccflags-y += -I$(srctree)/drivers/staging/lustre/include/
> > +subdir-ccflags-y += -I$(srctree)/drivers/staging/lustre/lustre/include/
> > +
> > ?obj-$(CONFIG_LNET) += lnet/
> > ?obj-$(CONFIG_LUSTRE_FS) += lustre/
> This is good, but does this break the subdir make command:
> make M=drivers/staging/lustre/foo_dir/
> ?
hmm, yeah, it does. ?Oh well, nevermind for awhile.
> I remember the last time I tried to clean this up, it took a while...
It seems like something the build tools should
handle correctly now, but I'll look at it.
No rush.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
lustre-devel@lists.lustre.org
Subject: Re: [PATCH 1/2] staging: lustre: Add include path to Makefile
Date: Mon, 15 Aug 2016 14:14:18 -0700 [thread overview]
Message-ID: <1471295658.4075.117.camel@perches.com> (raw)
In-Reply-To: <20160815210420.GA30864@kroah.com>
On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
> > Start to rationalize include paths in source code files.
[]
> > diff --git a/drivers/staging/lustre/Makefile b/drivers/staging/lustre/Makefile
[]
> > @@ -1,2 +1,5 @@
> > +subdir-ccflags-y += -I$(srctree)/drivers/staging/lustre/include/
> > +subdir-ccflags-y += -I$(srctree)/drivers/staging/lustre/lustre/include/
> > +
> > obj-$(CONFIG_LNET) += lnet/
> > obj-$(CONFIG_LUSTRE_FS) += lustre/
> This is good, but does this break the subdir make command:
> make M=drivers/staging/lustre/foo_dir/
> ?
hmm, yeah, it does. Oh well, nevermind for awhile.
> I remember the last time I tried to clean this up, it took a while...
It seems like something the build tools should
handle correctly now, but I'll look at it.
No rush.
next prev parent reply other threads:[~2016-08-15 21:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 19:33 [lustre-devel] [PATCH 0/2] staging: lustre: #include neatening Joe Perches
2016-08-15 19:33 ` Joe Perches
2016-08-15 19:33 ` [lustre-devel] [PATCH 1/2] staging: lustre: Add include path to Makefile Joe Perches
2016-08-15 19:33 ` Joe Perches
2016-08-15 21:04 ` [lustre-devel] " Greg Kroah-Hartman
2016-08-15 21:04 ` Greg Kroah-Hartman
2016-08-15 21:08 ` [lustre-devel] " James Simmons
2016-08-15 21:08 ` James Simmons
2016-08-15 21:14 ` Joe Perches [this message]
2016-08-15 21:14 ` Joe Perches
2016-08-15 21:29 ` Building a subdirectory ignores parent subdir-ccflags (was: Re: [PATCH 1/2] staging: lustre: Add include path to Makefile) Joe Perches
2016-08-15 21:29 ` [lustre-devel] " Joe Perches
2016-08-15 22:07 ` Building a subdirectory ignores parent subdir-ccflags Michal Marek
2016-08-15 22:46 ` Joe Perches
2016-08-15 22:46 ` [lustre-devel] " Joe Perches
2016-08-16 10:53 ` [lustre-devel] [PATCH 1/2] staging: lustre: Add include path to Makefile Greg Kroah-Hartman
2016-08-16 10:53 ` Greg Kroah-Hartman
2016-08-16 11:01 ` [lustre-devel] " Joe Perches
2016-08-16 11:01 ` Joe Perches
2016-08-15 19:33 ` [lustre-devel] [PATCH 2/2] staging: lustre: Remove .. paths from '#include "' uses Joe Perches
2016-08-15 19:33 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471295658.4075.117.camel@perches.com \
--to=joe@perches.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.