[PATCH] Specify extra paths

[PATCH] Specify extra paths

[Khem Raj]

Some layers have gstreamer plugin recipes which include
the .inc files from OE-Core but they do not get to find
the patch that is being forced by the .inc file and
ends up with errors like

WARNING: /mnt/oe/meta-qcom/recipes-multimedia/gstreamer/gstreamer1.0-plugins-v4l2.bb: Unable to get checksum for gstreamer1.0-plugins-v4l2 SRC_URI entry 0001-introspection.m4-prefix-pkgconfig-paths-with-PKG_CON.patch: file could not be fo
und

This path prepend fixes it

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
index 2dcec50..b066941 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
@@ -28,6 +28,7 @@ EXTRA_OECONF = " \
     --disable-examples \
 "
 
+FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
 SRC_URI_append = " file://0001-introspection.m4-prefix-pkgconfig-paths-with-PKG_CON.patch"
 
 delete_pkg_m4_file() {
-- 
1.8.3.1

Re: [PATCH] Specify extra paths

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

On 18 August 2016 at 17:41, Khem Raj <raj.khem@gmail.com> wrote:

> Some layers have gstreamer plugin recipes which include
> the .inc files from OE-Core but they do not get to find
> the patch that is being forced by the .inc file and
> ends up with errors like
>

Bad commit message as you don't specify the module.

But should this SRC_URI_append be in the common plugins.inc anyway?  Are
there out-of-tree modules that don't use gst-common and so the patch won't
apply?

Ross

[-- Attachment #2: Type: text/html, Size: 979 bytes --]

Re: [PATCH] Specify extra paths

[Khem Raj]

[-- Attachment #1.1: Type: text/plain, Size: 866 bytes --]


> On Aug 18, 2016, at 9:47 AM, Burton, Ross <ross.burton@intel.com> wrote:
> 
> 
> On 18 August 2016 at 17:41, Khem Raj <raj.khem@gmail.com <mailto:raj.khem@gmail.com>> wrote:
> Some layers have gstreamer plugin recipes which include
> the .inc files from OE-Core but they do not get to find
> the patch that is being forced by the .inc file and
> ends up with errors like
> 
> Bad commit message as you don't specify the module.
> 
> But should this SRC_URI_append be in the common plugins.inc anyway?  Are there out-of-tree modules that don't use gst-common and so the patch won't apply?

yes there are see
https://github.com/ndechesne/meta-qcom/blob/master/recipes-multimedia/gstreamer/gstreamer1.0-plugins-v4l2.bb <https://github.com/ndechesne/meta-qcom/blob/master/recipes-multimedia/gstreamer/gstreamer1.0-plugins-v4l2.bb>



> 
> Ross


[-- Attachment #1.2: Type: text/html, Size: 2045 bytes --]

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH] Specify extra paths

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

On Thu, Aug 18, 2016 at 04:41:01PM +0000, Khem Raj wrote:
> Some layers have gstreamer plugin recipes which include
> the .inc files from OE-Core but they do not get to find
> the patch that is being forced by the .inc file and
> ends up with errors like
> 
> WARNING: /mnt/oe/meta-qcom/recipes-multimedia/gstreamer/gstreamer1.0-plugins-v4l2.bb: Unable to get checksum for gstreamer1.0-plugins-v4l2 SRC_URI entry 0001-introspection.m4-prefix-pkgconfig-paths-with-PKG_CON.patch: file could not be fo
> und

Isn't it better to move this SRC_URI_append to the individual .bb files?

Other versions of plugins might not be able to apply this .patch and
such recipes will need to use SRC_URI_remove (or SRC_URI with override)
to get rid of this.

> 
> This path prepend fixes it
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
> index 2dcec50..b066941 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
> @@ -28,6 +28,7 @@ EXTRA_OECONF = " \
>      --disable-examples \
>  "
>  
> +FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
>  SRC_URI_append = " file://0001-introspection.m4-prefix-pkgconfig-paths-with-PKG_CON.patch"
>  
>  delete_pkg_m4_file() {
> -- 
> 1.8.3.1
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH] Specify extra paths

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2234 bytes --]


> On Aug 18, 2016, at 10:08 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> 
> On Thu, Aug 18, 2016 at 04:41:01PM +0000, Khem Raj wrote:
>> Some layers have gstreamer plugin recipes which include
>> the .inc files from OE-Core but they do not get to find
>> the patch that is being forced by the .inc file and
>> ends up with errors like
>> 
>> WARNING: /mnt/oe/meta-qcom/recipes-multimedia/gstreamer/gstreamer1.0-plugins-v4l2.bb: Unable to get checksum for gstreamer1.0-plugins-v4l2 SRC_URI entry 0001-introspection.m4-prefix-pkgconfig-paths-with-PKG_CON.patch: file could not be fo
>> und
> 
> Isn't it better to move this SRC_URI_append to the individual .bb files?
> 
> Other versions of plugins might not be able to apply this .patch and
> such recipes will need to use SRC_URI_remove (or SRC_URI with override)
> to get rid of this.

I thought of doing that, but then this patch is needed for g-ir to work in cross env.
may be its better to also expose the SRCREV and SRC_URI or common repo in the inc file
in case where external plugins would like to override that, then they will automatically
remove the patch too.

> 
>> 
>> This path prepend fixes it
>> 
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
>> index 2dcec50..b066941 100644
>> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
>> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
>> @@ -28,6 +28,7 @@ EXTRA_OECONF = " \
>>     --disable-examples \
>> "
>> 
>> +FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
>> SRC_URI_append = " file://0001-introspection.m4-prefix-pkgconfig-paths-with-PKG_CON.patch"
>> 
>> delete_pkg_m4_file() {
>> --
>> 1.8.3.1
>> 
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]