From: Joe Perches <joe@perches.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/gma500: dont expose bytes from kernel stack
Date: Sun, 21 Aug 2016 11:46:01 -0700 [thread overview]
Message-ID: <1471805161.3746.10.camel@perches.com> (raw)
In-Reply-To: <1471804778-3656-1-git-send-email-xypron.glpk@gmx.de>
On Sun, 2016-08-21 at 20:39 +0200, Heinrich Schuchardt wrote:
> Components m1, m2, p2, dot, vco of variable clock should be
> initialized to avoid bytes from the kernel stack to be
> exposed.
How was this found? visual code inspection?
And isn't this true for mrst_lvds_find_best_pll as well?
> a@@ -138,6 +138,7 @@ static bool mrst_sdvo_find_best_pll(const struct gma_limit_t *limit,
> u32 target_vco, actual_freq;
> s32 freq_error, min_error = 100000;
>
> + memset(clock, 0, sizeof(struct gma_clock_t));
> memset(best_clock, 0, sizeof(*best_clock));
>
> for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) {
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/gma500: dont expose bytes from kernel stack
Date: Sun, 21 Aug 2016 11:46:01 -0700 [thread overview]
Message-ID: <1471805161.3746.10.camel@perches.com> (raw)
In-Reply-To: <1471804778-3656-1-git-send-email-xypron.glpk@gmx.de>
On Sun, 2016-08-21 at 20:39 +0200, Heinrich Schuchardt wrote:
> Components m1, m2, p2, dot, vco of variable clock should be
> initialized to avoid bytes from the kernel stack to be
> exposed.
How was this found? visual code inspection?
And isn't this true for mrst_lvds_find_best_pll as well?
> a@@ -138,6 +138,7 @@ static bool mrst_sdvo_find_best_pll(const struct gma_limit_t *limit,
> u32 target_vco, actual_freq;
> s32 freq_error, min_error = 100000;
>
> + memset(clock, 0, sizeof(struct gma_clock_t));
> memset(best_clock, 0, sizeof(*best_clock));
>
> for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) {
next prev parent reply other threads:[~2016-08-21 18:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 18:39 [PATCH] drm/gma500: dont expose bytes from kernel stack Heinrich Schuchardt
2016-08-21 18:46 ` Joe Perches [this message]
2016-08-21 18:46 ` Joe Perches
2016-08-21 19:35 ` Heinrich Schuchardt
2016-08-21 19:38 ` Joe Perches
2016-08-21 19:38 ` Joe Perches
2016-08-22 7:29 ` Daniel Vetter
2016-08-22 9:16 ` One Thousand Gnomes
2016-08-22 9:16 ` One Thousand Gnomes
2016-08-22 8:32 ` Jani Nikula
2016-08-22 8:32 ` Jani Nikula
2016-08-22 13:45 ` kbuild test robot
2016-08-22 13:45 ` kbuild test robot
2016-08-22 17:18 ` kbuild test robot
2016-08-22 17:18 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471805161.3746.10.camel@perches.com \
--to=joe@perches.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.