* [PATCH] drm/i915: free intel_fb
@ 2016-08-23 15:00 Matthew Auld
2016-08-23 15:16 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Matthew Auld @ 2016-08-23 15:00 UTC (permalink / raw)
To: intel-gfx
We need to free the allocated intel_fb in the error path, not
intel_fb->base. Otherwise we risk calling kfree with a non-kmalloc'd
address, which is bound to give us grief at some point.
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index a5c80cb5..79bc99d 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9798,7 +9798,7 @@ skylake_get_initial_plane_config(struct intel_crtc *crtc,
return;
error:
- kfree(fb);
+ kfree(intel_fb);
}
static void ironlake_get_pfit_config(struct intel_crtc *crtc,
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915: free intel_fb
2016-08-23 15:00 [PATCH] drm/i915: free intel_fb Matthew Auld
@ 2016-08-23 15:16 ` Chris Wilson
2016-08-23 19:21 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-08-24 11:08 ` ✓ Fi.CI.BAT: success " Patchwork
2 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2016-08-23 15:16 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
On Tue, Aug 23, 2016 at 04:00:44PM +0100, Matthew Auld wrote:
> We need to free the allocated intel_fb in the error path, not
> intel_fb->base. Otherwise we risk calling kfree with a non-kmalloc'd
> address, which is bound to give us grief at some point.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: free intel_fb
2016-08-23 15:00 [PATCH] drm/i915: free intel_fb Matthew Auld
2016-08-23 15:16 ` Chris Wilson
@ 2016-08-23 19:21 ` Patchwork
2016-08-24 10:06 ` Matthew Auld
2016-08-24 11:08 ` ✓ Fi.CI.BAT: success " Patchwork
2 siblings, 1 reply; 7+ messages in thread
From: Patchwork @ 2016-08-23 19:21 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: free intel_fb
URL : https://patchwork.freedesktop.org/series/11477/
State : failure
== Summary ==
Series 11477v1 drm/i915: free intel_fb
http://patchwork.freedesktop.org/api/1.0/series/11477/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
incomplete -> DMESG-WARN (fi-hsw-4770k)
Test kms_cursor_legacy:
Subgroup basic-cursor-vs-flip-legacy:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-cursor-vs-flip-varying-size:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-flip-vs-cursor-legacy:
fail -> PASS (fi-bdw-5557u)
Subgroup basic-flip-vs-cursor-varying-size:
fail -> PASS (fi-bsw-n3050)
Test prime_busy:
Subgroup basic-after-default:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-before-default:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-wait-after-default:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-wait-before-default:
pass -> FAIL (fi-bsw-n3050)
Test prime_vgem:
Subgroup basic-busy-default:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-gtt:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-sync-default:
pass -> FAIL (fi-bsw-n3050)
Subgroup basic-wait-default:
pass -> FAIL (fi-bsw-n3050)
fi-bdw-5557u total:249 pass:232 dwarn:0 dfail:0 fail:1 skip:16
fi-bsw-n3050 total:249 pass:194 dwarn:0 dfail:0 fail:11 skip:44
fi-byt-n2820 total:249 pass:204 dwarn:0 dfail:0 fail:4 skip:41
fi-hsw-4770k total:249 pass:220 dwarn:6 dfail:0 fail:1 skip:22
fi-hsw-4770r total:249 pass:222 dwarn:0 dfail:0 fail:1 skip:26
fi-ivb-3520m total:249 pass:217 dwarn:0 dfail:0 fail:1 skip:31
fi-skl-6260u total:249 pass:234 dwarn:0 dfail:0 fail:1 skip:14
fi-skl-6700k total:249 pass:214 dwarn:4 dfail:0 fail:3 skip:28
fi-snb-2520m total:249 pass:201 dwarn:4 dfail:0 fail:2 skip:42
fi-snb-2600 total:249 pass:202 dwarn:4 dfail:0 fail:1 skip:42
Results at /archive/results/CI_IGT_test/Patchwork_2411/
d05ed1828321404c7fdf369ca17fa958938913bc drm-intel-nightly: 2016y-08m-23d-16h-32m-14s UTC integration manifest
b9253f5 drm/i915: free intel_fb
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: free intel_fb
2016-08-23 15:00 [PATCH] drm/i915: free intel_fb Matthew Auld
2016-08-23 15:16 ` Chris Wilson
2016-08-23 19:21 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2016-08-24 11:08 ` Patchwork
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2016-08-24 11:08 UTC (permalink / raw)
To: Matthew Auld; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: free intel_fb
URL : https://patchwork.freedesktop.org/series/11477/
State : success
== Summary ==
Series 11477v1 drm/i915: free intel_fb
http://patchwork.freedesktop.org/api/1.0/series/11477/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
incomplete -> DMESG-WARN (fi-hsw-4770k)
Test kms_cursor_legacy:
Subgroup basic-flip-vs-cursor-legacy:
fail -> PASS (fi-bdw-5557u)
fi-bdw-5557u total:249 pass:232 dwarn:0 dfail:0 fail:1 skip:16
fi-byt-n2820 total:249 pass:204 dwarn:0 dfail:0 fail:4 skip:41
fi-hsw-4770k total:249 pass:220 dwarn:6 dfail:0 fail:1 skip:22
fi-hsw-4770r total:249 pass:222 dwarn:0 dfail:0 fail:1 skip:26
fi-ivb-3520m total:249 pass:217 dwarn:0 dfail:0 fail:1 skip:31
fi-skl-6260u total:249 pass:234 dwarn:0 dfail:0 fail:1 skip:14
fi-skl-6700k total:249 pass:214 dwarn:4 dfail:0 fail:3 skip:28
fi-snb-2520m total:249 pass:201 dwarn:4 dfail:0 fail:2 skip:42
fi-snb-2600 total:249 pass:202 dwarn:4 dfail:0 fail:1 skip:42
Results at /archive/results/CI_IGT_test/Patchwork_2411/
d05ed1828321404c7fdf369ca17fa958938913bc drm-intel-nightly: 2016y-08m-23d-16h-32m-14s UTC integration manifest
b9253f5 drm/i915: free intel_fb
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-08-24 13:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-23 15:00 [PATCH] drm/i915: free intel_fb Matthew Auld
2016-08-23 15:16 ` Chris Wilson
2016-08-23 19:21 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-08-24 10:06 ` Matthew Auld
2016-08-24 13:08 ` Joonas Lahtinen
2016-08-24 13:11 ` Chris Wilson
2016-08-24 11:08 ` ✓ Fi.CI.BAT: success " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.