All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] kernel.bbclass: include signing keys when copying files required for module builds
@ 2016-08-25 15:13 Waldo Mattias
  2016-08-25 15:52 ` Bruce Ashfield
  0 siblings, 1 reply; 2+ messages in thread
From: Waldo Mattias @ 2016-08-25 15:13 UTC (permalink / raw)
  To: openembedded-core@lists.openembedded.org

The absence of certs/signing_key.* in $kerneldir made signing of
out-of-tree kernel modules fail (silently). Add copying of these
files during the shared_workdir task.

Signed-off-by: Mattias Waldo <mattias.waldo@saabgroup.com>
---
 meta/classes/kernel.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index db42744..07761e7 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -364,6 +364,8 @@ do_shared_workdir () {
        cp .config $kerneldir/
        mkdir -p $kerneldir/include/config
        cp include/config/kernel.release $kerneldir/include/config/kernel.release
+       mkdir -p $kerneldir/certs
+       cp certs/signing_key.* $kerneldir/certs

        # We can also copy over all the generated files and avoid special cases
        # like version.h, but we've opted to keep this small until file creep starts
--
2.9.3





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] kernel.bbclass: include signing keys when copying files required for module builds
  2016-08-25 15:13 [PATCH v3] kernel.bbclass: include signing keys when copying files required for module builds Waldo Mattias
@ 2016-08-25 15:52 ` Bruce Ashfield
  0 siblings, 0 replies; 2+ messages in thread
From: Bruce Ashfield @ 2016-08-25 15:52 UTC (permalink / raw)
  To: Waldo Mattias; +Cc: openembedded-core@lists.openembedded.org

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

On Thu, Aug 25, 2016 at 11:13 AM, Waldo Mattias <Mattias.Waldo@saabgroup.com
> wrote:

> The absence of certs/signing_key.* in $kerneldir made signing of
> out-of-tree kernel modules fail (silently). Add copying of these
> files during the shared_workdir task.
>

I had been pinged on one of the earlier revisions of this, and I can say
that this looks
fine to me.

Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>

Bruce


>
> Signed-off-by: Mattias Waldo <mattias.waldo@saabgroup.com>
> ---
>  meta/classes/kernel.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index db42744..07761e7 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -364,6 +364,8 @@ do_shared_workdir () {
>         cp .config $kerneldir/
>         mkdir -p $kerneldir/include/config
>         cp include/config/kernel.release $kerneldir/include/config/
> kernel.release
> +       mkdir -p $kerneldir/certs
> +       cp certs/signing_key.* $kerneldir/certs
>
>         # We can also copy over all the generated files and avoid special
> cases
>         # like version.h, but we've opted to keep this small until file
> creep starts
> --
> 2.9.3
>
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 2692 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-25 15:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-25 15:13 [PATCH v3] kernel.bbclass: include signing keys when copying files required for module builds Waldo Mattias
2016-08-25 15:52 ` Bruce Ashfield

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.