From: Jeff Layton <jlayton@poochiereds.net>
To: Julia Lawall <Julia.Lawall@lip6.fr>,
"J. Bruce Fields" <bfields@fieldses.org>
Cc: kernel-janitors@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfsd: constify reply_cache_stats_operations structure
Date: Mon, 29 Aug 2016 10:57:47 +0000 [thread overview]
Message-ID: <1472468267.2597.0.camel@poochiereds.net> (raw)
In-Reply-To: <1472416615-24079-1-git-send-email-Julia.Lawall@lip6.fr>
On Sun, 2016-08-28 at 22:36 +0200, Julia Lawall wrote:
> reply_cache_stats_operations, of type struct file_operations, is
> never
> modified, so declare it as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> fs/nfsd/nfsctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 65ad016..3bc9693 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -217,7 +217,7 @@ static const struct file_operations
> pool_stats_operations = {
> .release = nfsd_pool_stats_release,
> };
>
> -static struct file_operations reply_cache_stats_operations = {
> +static const struct file_operations reply_cache_stats_operations = {
> .open = nfsd_reply_cache_stats_open,
> .read = seq_read,
> .llseek = seq_lseek,
>
I'm pretty sure Bruce will pick this up for v4.9:
Reviewed-by: Jeff Layton <jlayton@poochiereds.net>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jlayton@poochiereds.net>
To: Julia Lawall <Julia.Lawall@lip6.fr>,
"J. Bruce Fields" <bfields@fieldses.org>
Cc: kernel-janitors@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfsd: constify reply_cache_stats_operations structure
Date: Mon, 29 Aug 2016 06:57:47 -0400 [thread overview]
Message-ID: <1472468267.2597.0.camel@poochiereds.net> (raw)
In-Reply-To: <1472416615-24079-1-git-send-email-Julia.Lawall@lip6.fr>
On Sun, 2016-08-28 at 22:36 +0200, Julia Lawall wrote:
> reply_cache_stats_operations, of type struct file_operations, is
> never
> modified, so declare it as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> fs/nfsd/nfsctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 65ad016..3bc9693 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -217,7 +217,7 @@ static const struct file_operations
> pool_stats_operations = {
> .release = nfsd_pool_stats_release,
> };
>
> -static struct file_operations reply_cache_stats_operations = {
> +static const struct file_operations reply_cache_stats_operations = {
> .open = nfsd_reply_cache_stats_open,
> .read = seq_read,
> .llseek = seq_lseek,
>
I'm pretty sure Bruce will pick this up for v4.9:
Reviewed-by: Jeff Layton <jlayton@poochiereds.net>
next prev parent reply other threads:[~2016-08-29 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 20:36 [PATCH] nfsd: constify reply_cache_stats_operations structure Julia Lawall
2016-08-28 20:36 ` Julia Lawall
2016-08-29 10:57 ` Jeff Layton [this message]
2016-08-29 10:57 ` Jeff Layton
2016-11-08 20:36 ` J. Bruce Fields
2016-11-08 20:36 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472468267.2597.0.camel@poochiereds.net \
--to=jlayton@poochiereds.net \
--cc=Julia.Lawall@lip6.fr \
--cc=bfields@fieldses.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.