From: Joe Perches <joe@perches.com>
To: "Luck, Tony" <tony.luck@intel.com>,
"Levin, Alexander" <alexander.levin@verizon.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Sasha Levin <levinsasha928@gmail.com>,
"ksummit-discuss@lists.linuxfoundation.org"
<ksummit-discuss@lists.linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Ksummit-discuss] checkkpatch (in)sanity ?
Date: Mon, 29 Aug 2016 11:47:00 -0700 [thread overview]
Message-ID: <1472496420.3425.77.camel@perches.com> (raw)
In-Reply-To: <1472493700.3425.67.camel@perches.com>
On Mon, 2016-08-29 at 11:01 -0700, Joe Perches wrote:
> On Mon, 2016-08-29 at 17:46 +0000, Luck, Tony wrote:
> > [checkpatch] offered the advice
> > to restructure the code with helper functions etc. to avoid deep
> > indentation?
> It suggests that already for 6+ leading tabs,
And here's an inexact little histogram of the code that
expands indent levels in the -next kernel source tree.
$ grep -rP --include=*.[ch] -oh "^[\t]+(do|while|for|if|else|return|goto|continue|switch|default|case|break)\b" * | \
sed -r 's/^(\t+).*$/\1/' | awk '{print length($0)}' | sort -n | uniq -c
1217165 1
783085 2
249655 3
59775 4
11653 5
1993 6
444 7
158 8
50 9
19 10
10 11
4 12
1 13
Some of that code, as Linus once put it, is eye-gouging.
Luckily, almost all of the 7+ tab indent code is prehistoric.
next prev parent reply other threads:[~2016-08-29 18:47 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 20:40 [Ksummit-discuss] checkkpatch (in)sanity ? Joe Perches
2016-08-27 20:40 ` Joe Perches
2016-08-28 1:06 ` [Ksummit-discuss] " Levin, Alexander
2016-08-28 1:06 ` Levin, Alexander
2016-08-28 1:42 ` [Ksummit-discuss] " Joe Perches
2016-08-28 1:42 ` Joe Perches
2016-08-28 2:20 ` [Ksummit-discuss] " Joe Perches
2016-08-28 2:20 ` Joe Perches
2016-08-28 2:47 ` [Ksummit-discuss] " Levin, Alexander
2016-08-28 2:47 ` Levin, Alexander
2016-08-28 17:15 ` [Ksummit-discuss] " Joe Perches
2016-08-28 17:15 ` Joe Perches
2016-08-28 17:59 ` [Ksummit-discuss] " Greg KH
2016-08-28 17:59 ` Greg KH
2016-08-28 22:37 ` [Ksummit-discuss] " Levin, Alexander
2016-08-28 22:37 ` Levin, Alexander
2016-08-28 23:20 ` [Ksummit-discuss] " Joe Perches
2016-08-28 23:20 ` Joe Perches
2016-08-29 2:22 ` [Ksummit-discuss] " Levin, Alexander
2016-08-29 2:22 ` Levin, Alexander
2016-08-29 8:20 ` [Ksummit-discuss] " Christoph Hellwig
2016-08-29 8:20 ` Christoph Hellwig
2016-08-29 7:15 ` [Ksummit-discuss] " Alexandre Belloni
2016-08-29 7:15 ` Alexandre Belloni
2016-08-29 9:01 ` Arnd Bergmann
2016-08-29 9:01 ` Arnd Bergmann
2016-08-29 12:47 ` Joe Perches
2016-08-29 12:47 ` Joe Perches
2016-08-29 17:16 ` Josh Triplett
2016-08-29 17:16 ` Josh Triplett
2016-08-29 17:41 ` Joe Perches
2016-08-29 17:41 ` Joe Perches
2016-08-29 17:46 ` Luck, Tony
2016-08-29 17:46 ` Luck, Tony
2016-08-29 18:01 ` Joe Perches
2016-08-29 18:47 ` Joe Perches [this message]
2016-08-29 19:08 ` Josh Triplett
2016-08-29 19:08 ` Josh Triplett
2016-08-29 21:07 ` Arnd Bergmann
2016-08-29 21:07 ` Arnd Bergmann
2016-08-29 11:15 ` Kalle Valo
2016-08-29 11:15 ` Kalle Valo
2016-08-29 12:30 ` [Ksummit-discuss] " Joe Perches
2016-08-29 12:30 ` Joe Perches
2016-08-29 18:01 ` [Ksummit-discuss] " Kalle Valo
2016-08-29 18:01 ` Kalle Valo
2016-08-29 19:00 ` [Ksummit-discuss] " Joe Perches
2016-08-29 19:00 ` Joe Perches
2016-08-29 21:00 ` [Ksummit-discuss] " Arnd Bergmann
2016-08-29 21:00 ` Arnd Bergmann
2016-08-28 7:56 ` Alexey Dobriyan
2016-08-28 7:56 ` Alexey Dobriyan
2016-08-28 9:59 ` Julia Lawall
2016-08-28 9:59 ` Julia Lawall
2016-08-28 19:52 ` Joe Perches
2016-08-28 19:52 ` Joe Perches
2016-08-28 20:35 ` Jiri Kosina
2016-08-28 20:35 ` Jiri Kosina
2016-08-28 21:24 ` Dennis Kaarsemaker
2016-08-28 21:24 ` Dennis Kaarsemaker
2016-08-28 21:57 ` Joe Perches
2016-08-28 21:57 ` Joe Perches
2016-08-29 19:06 ` Dan Carpenter
2016-08-29 19:06 ` Dan Carpenter
2016-08-29 19:10 ` Josh Triplett
2016-08-29 19:10 ` Josh Triplett
2016-08-29 19:17 ` Dan Carpenter
2016-08-29 19:17 ` Dan Carpenter
2016-08-29 19:34 ` Joe Perches
2016-08-29 19:34 ` Joe Perches
2016-08-29 19:21 ` Joe Perches
2016-08-29 19:21 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472496420.3425.77.camel@perches.com \
--to=joe@perches.com \
--cc=alexander.levin@verizon.com \
--cc=gregkh@linuxfoundation.org \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.