All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Sasha Levin <levinsasha928@gmail.com>,
	"ksummit-discuss@lists.linuxfoundation.org"
	<ksummit-discuss@lists.linuxfoundation.org>
Subject: Re: [Ksummit-discuss] checkkpatch (in)sanity ?
Date: Sun, 28 Aug 2016 19:59:07 +0200	[thread overview]
Message-ID: <20160828175907.GA9615@kroah.com> (raw)
In-Reply-To: <1472404557.26978.84.camel@perches.com>

On Sun, Aug 28, 2016 at 10:15:57AM -0700, Joe Perches wrote:
> On Sat, 2016-08-27 at 22:47 -0400, Levin, Alexander wrote:
> > > > By default you should only get the most critical warnings we have in the
> > > > kernel like missing S-O-B or corrupt patch.
> > > I don't think so, but if you do, add a filter for ERROR only.
> > I could, but the problem is the people who see the default output as "holy".
> 
> Personally, I think the "my first kernel patch" beginners were
> overly encouraged to produce these checkpatch whitespace type
> changes by a couple things:
> 
> o Greg KH's TuxRadar article back in 2010
>   http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel
> o The Eudyptula Challenge
>   http://eudyptula-challenge.org/
> 
> I don't know if the Eudyptula scripts are specific to
> drivers/staging and most of those beginners haven't read his
> email from 2015 that essentially says "don't do that" on
> anything other than drivers/staging.

I have been assured that Eudyptula says to stick only with
drivers/staging/  If anyone knows otherwise, please let me know and I
will work to resolve that.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: "Levin, Alexander" <alexander.levin@verizon.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"ksummit-discuss@lists.linuxfoundation.org" 
	<ksummit-discuss@lists.linuxfoundation.org>
Subject: Re: checkkpatch (in)sanity ?
Date: Sun, 28 Aug 2016 19:59:07 +0200	[thread overview]
Message-ID: <20160828175907.GA9615@kroah.com> (raw)
In-Reply-To: <1472404557.26978.84.camel@perches.com>

On Sun, Aug 28, 2016 at 10:15:57AM -0700, Joe Perches wrote:
> On Sat, 2016-08-27 at 22:47 -0400, Levin, Alexander wrote:
> > > > By default you should only get the most critical warnings we have in the
> > > > kernel like missing S-O-B or corrupt patch.
> > > I don't think so, but if you do, add a filter for ERROR only.
> > I could, but the problem is the people who see the default output as "holy".
> 
> Personally, I think the "my first kernel patch" beginners were
> overly encouraged to produce these checkpatch whitespace type
> changes by a couple things:
> 
> o Greg KH's TuxRadar article back in 2010
>   http://www.tuxradar.com/content/newbies-guide-hacking-linux-kernel
> o The Eudyptula Challenge
>   http://eudyptula-challenge.org/
> 
> I don't know if the Eudyptula scripts are specific to
> drivers/staging and most of those beginners haven't read his
> email from 2015 that essentially says "don't do that" on
> anything other than drivers/staging.

I have been assured that Eudyptula says to stick only with
drivers/staging/  If anyone knows otherwise, please let me know and I
will work to resolve that.

thanks,

greg k-h

  reply	other threads:[~2016-08-28 17:59 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-27 20:40 [Ksummit-discuss] checkkpatch (in)sanity ? Joe Perches
2016-08-27 20:40 ` Joe Perches
2016-08-28  1:06 ` [Ksummit-discuss] " Levin, Alexander
2016-08-28  1:06   ` Levin, Alexander
2016-08-28  1:42   ` [Ksummit-discuss] " Joe Perches
2016-08-28  1:42     ` Joe Perches
2016-08-28  2:20     ` [Ksummit-discuss] " Joe Perches
2016-08-28  2:20       ` Joe Perches
2016-08-28  2:47     ` [Ksummit-discuss] " Levin, Alexander
2016-08-28  2:47       ` Levin, Alexander
2016-08-28 17:15       ` [Ksummit-discuss] " Joe Perches
2016-08-28 17:15         ` Joe Perches
2016-08-28 17:59         ` Greg KH [this message]
2016-08-28 17:59           ` Greg KH
2016-08-28 22:37         ` [Ksummit-discuss] " Levin, Alexander
2016-08-28 22:37           ` Levin, Alexander
2016-08-28 23:20           ` [Ksummit-discuss] " Joe Perches
2016-08-28 23:20             ` Joe Perches
2016-08-29  2:22             ` [Ksummit-discuss] " Levin, Alexander
2016-08-29  2:22               ` Levin, Alexander
2016-08-29  8:20               ` [Ksummit-discuss] " Christoph Hellwig
2016-08-29  8:20                 ` Christoph Hellwig
2016-08-29  7:15           ` [Ksummit-discuss] " Alexandre Belloni
2016-08-29  7:15             ` Alexandre Belloni
2016-08-29  9:01             ` Arnd Bergmann
2016-08-29  9:01               ` Arnd Bergmann
2016-08-29 12:47               ` Joe Perches
2016-08-29 12:47                 ` Joe Perches
2016-08-29 17:16                 ` Josh Triplett
2016-08-29 17:16                   ` Josh Triplett
2016-08-29 17:41                   ` Joe Perches
2016-08-29 17:41                     ` Joe Perches
2016-08-29 17:46         ` Luck, Tony
2016-08-29 17:46           ` Luck, Tony
2016-08-29 18:01           ` Joe Perches
2016-08-29 18:47             ` Joe Perches
2016-08-29 19:08             ` Josh Triplett
2016-08-29 19:08               ` Josh Triplett
2016-08-29 21:07             ` Arnd Bergmann
2016-08-29 21:07               ` Arnd Bergmann
2016-08-29 11:15     ` Kalle Valo
2016-08-29 11:15       ` Kalle Valo
2016-08-29 12:30       ` [Ksummit-discuss] " Joe Perches
2016-08-29 12:30         ` Joe Perches
2016-08-29 18:01         ` [Ksummit-discuss] " Kalle Valo
2016-08-29 18:01           ` Kalle Valo
2016-08-29 19:00           ` [Ksummit-discuss] " Joe Perches
2016-08-29 19:00             ` Joe Perches
2016-08-29 21:00           ` [Ksummit-discuss] " Arnd Bergmann
2016-08-29 21:00             ` Arnd Bergmann
2016-08-28  7:56   ` Alexey Dobriyan
2016-08-28  7:56     ` Alexey Dobriyan
2016-08-28  9:59     ` Julia Lawall
2016-08-28  9:59       ` Julia Lawall
2016-08-28 19:52       ` Joe Perches
2016-08-28 19:52         ` Joe Perches
2016-08-28 20:35         ` Jiri Kosina
2016-08-28 20:35           ` Jiri Kosina
2016-08-28 21:24         ` Dennis Kaarsemaker
2016-08-28 21:24           ` Dennis Kaarsemaker
2016-08-28 21:57           ` Joe Perches
2016-08-28 21:57             ` Joe Perches
2016-08-29 19:06 ` Dan Carpenter
2016-08-29 19:06   ` Dan Carpenter
2016-08-29 19:10   ` Josh Triplett
2016-08-29 19:10     ` Josh Triplett
2016-08-29 19:17     ` Dan Carpenter
2016-08-29 19:17       ` Dan Carpenter
2016-08-29 19:34       ` Joe Perches
2016-08-29 19:34         ` Joe Perches
2016-08-29 19:21     ` Joe Perches
2016-08-29 19:21       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160828175907.GA9615@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=ksummit-discuss@lists.linuxfoundation.org \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.