From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: "jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"mirza.krak@gmail.com" <mirza.krak@gmail.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"pgaikwad@nvidia.com" <pgaikwad@nvidia.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"gnurou@gmail.com" <gnurou@gmail.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"pdeschrijver@nvidia.com" <pdeschrijver@nvidia.com>,
"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v2 0/6] Add support for Tegra GMI bus controller
Date: Tue, 30 Aug 2016 15:01:37 +0000 [thread overview]
Message-ID: <1472569295.5703.20.camel@toradex.com> (raw)
In-Reply-To: <1472045838-22628-1-git-send-email-mirza.krak@gmail.com>
SGkgTWlyemENCg0KU29ycnksIEkgbG9uZyBzaW5jZSB3YW50ZWQgdG8gZ2l2ZSB5b3Ugc29tZSBm
ZWVkYmFjayBvbiB0aGlzIGFzIHdlbGwuDQoNCkJUVzogVGhhbmsgeW91IHZlcnkgbXVjaCBmb3Ig
dGFraW5nIHRoaXMgb24hDQoNCk9uIFdlZCwgMjAxNi0wOC0yNCBhdCAxNTozNyArMDIwMCwgTWly
emEgS3JhayB3cm90ZToNCj4gRnJvbTogTWlyemEgS3JhayA8bWlyemEua3Jha0BnbWFpbC5jb20+
DQo+IA0KPiBIaS4NCj4gDQo+IFRoaXMgaXMgYSBmb2xsb3cgdXAgdG8gbXkgcHJldmlvdXMgUkZD
IHRvIGFkZCBzdXBwb3J0IGZvciBUZWdyYSBHTUkNCj4gYnVzDQo+IGNvbnRyb2xsZXIuDQo+IA0K
PiBJIGhhdmUgdGVzdGVkIHRoaXMgc2VyaWVzIG9uIGEgVGVncmEzMCB1c2luZyBhIENvbGlicmkg
VDMwIFNPTSBvbiBhDQo+IGN1c3RvbQ0KPiBjYXJyaWVyIGJvYXJkIHdoaWNoIGhhcyBtdWx0aXBs
ZSBDQU4gY29udHJvbGxlcnMgKFNKQTEwMDApIGNvbm5lY3RlZA0KPiB0byB0aGUNCj4gR01JIGJ1
cy4NCg0KV2Ugb25jZSBkaWQgYSBuaWNlIEdNSS1NZW1vcnkgQm9hcmQgd2hpY2ggbWF0ZXMgd2l0
aCB0aGUgZXh0ZW5zaW9uDQpjb25uZWN0b3IgWDMgb2Ygb3VyIFYzLnggQ29saWJyaSBFdmFsdWF0
aW9uIGJvYXJkcyBhbmQgYWxsb3dzIHRlc3RpbmcNClNSQU0gYWNjZXNzIG5vdCBvbmx5IGluIG11
eGVkIGJ1dCBhbHNvIGluIG5vbi1tdXhlZCBtb2RlIGFsYmVpdCAxNi1iaXQNCm9ubHkuIEkgdG9v
ayB5b3VyIGRyaXZlciBmb3IgYSBzcGluIGJvdGggb24gQ29saWJyaSBUMjAgYXMgd2VsbCBhcw0K
Q29saWJyaSBUMzAgYm90aCBpbiBtdXhlZCBhcyB3ZWxsIGFzIG5vbi1tdXhlZCBtb2RlIGFuZCBp
dCBwYXNzZWQgYWxsDQp0ZXN0cyBiZWluZyBib3RoIG1hbnVhbCBkZXZtZW0yIHR5cGUgcmVhZHMv
d3JpdGVzIGFzIHdlbGwgYXMgbWVtdGVzdGVyDQpydW5zIG9uIHRoZSBmdWxsIDEyOEsgU1JBTSBn
aXZpbmcgaXQgdGhlIHBoeXNpY2FsIGFkZHJlc3MgdXNpbmcgdGhlIC1wDQphcmd1bWVudC4NCg0K
U28geW91IG1heSBhZGQgdGhlIGZvbGxvd2luZyB0byB0aGUgd2hvbGUgc2VyaWVzOg0KDQpUZXN0
ZWQtYnk6IE1hcmNlbCBaaXN3aWxlciA8bWFyY2VsLnppc3dpbGVyQHRvcmFkZXguY29tPg0KVGVz
dGVkLW9uOiBDb2xpYnJpIFQyMC9UMzAgb24gRXZhbEJvYXJkIFYzLnggYW5kIEdNSS1NZW1vcnkg
Qm9hcmQNCg0KSSB3aWxsIGxlYXZlIGZ1cnRoZXIgY29tbWVudHMgb24gdGhlIGluZGl2aWR1YWwg
cGF0Y2hlcy4NCg0KQlRXOiBPZiBjb3Vyc2UgZm9yIG5vbi1tdXhlZCBtb2RlIEkgYWxzbyBoYWQg
dG8gYWRqdXN0IHRoZSBwaW4gbXV4aW5nDQphcyB0aGV5IGRlZmF1bHQgdG8gbXV4ZWQuDQoNCj4g
SSBoYXZlIHJlYmFzZWQgb24gdG9wIG9mIGxhdGVzdCB0ZWdyYS9mb3ItbmV4dCBpbiBWMi4gQWxz
byBzZWUNCj4gaW5kaXZpZHVhbA0KPiBwYXRjaGVzIGZvciBjaGFuZ2VzIGluIFYyLg0KPiANCj4g
U2VlIGJlbG93IGxpbmtzIGZvciBwcmV2aW91cyBkaXNjdXNzaW9ucy4NCj4gDQo+IENvbW1lbnRz
IG9uIFJGQzoNCj4gaHR0cHM6Ly9tYXJjLmluZm8vP2w9bGludXgtY2xrJm09MTQ2ODkzNTU3NjI5
OTAzJnc9Mg0KPiBodHRwczovL21hcmMuaW5mby8/bD1saW51eC10ZWdyYSZtPTE0Njg5MzU0MTgy
OTgwMSZ3PTINCj4gaHR0cHM6Ly9tYXJjLmluZm8vP2w9bGludXgtdGVncmEmbT0xNDY4OTM1NDI0
Mjk4MTQmdz0yDQo+IA0KPiBDb21tZW50cyBvbiBWMToNCj4gaHR0cHM6Ly9tYXJjLmluZm8vP2w9
bGludXgtYXJtLWtlcm5lbCZtPTE0NzA1MTU1MTgyMTEyMiZ3PTINCj4gaHR0cHM6Ly9tYXJjLmlu
Zm8vP2w9bGludXgtYXJtLWtlcm5lbCZtPTE0NzA1MTU1MzEyMTE1MCZ3PTINCj4gaHR0cHM6Ly9t
YXJjLmluZm8vP2w9bGludXgtYXJtLWtlcm5lbCZtPTE0NzE5NDg1NjYwMDYyNyZ3PTINCj4gaHR0
cHM6Ly9tYXJjLmluZm8vP2w9bGludXgtYXJtLWtlcm5lbCZtPTE0NzA3Mjc0MjQzMjIxMSZ3PTIN
Cj4gDQo+IA0KPiBNaXJ6YSBLcmFrICg2KToNCj4gwqAgY2xrOiB0ZWdyYTogYWRkIFRFR1JBMjBf
Q0xLX05PUiB0byBpbml0IHRhYmxlDQo+IMKgIGNsazogdGVncmE6IGFkZCBURUdSQTMwX0NMS19O
T1IgdG8gaW5pdCB0YWJsZQ0KPiDCoCBkdC9iaW5kaW5nczogQWRkIGJpbmRpbmdzIGZvciBUZWdy
YSBHTUkgY29udHJvbGxlcg0KPiDCoCBBUk06IHRlZ3JhOiBBZGQgVGVncmEzMCBHTUkgc3VwcG9y
dA0KPiDCoCBBUk06IHRlZ3JhOiBBZGQgVGVncmEyMCBHTUkgc3VwcG9ydA0KPiDCoCBidXM6IEFk
ZCBzdXBwb3J0IGZvciBUZWdyYSBHZW5lcmljIE1lbW9yeSBJbnRlcmZhY2UNCj4gDQo+IMKgLi4u
L2RldmljZXRyZWUvYmluZGluZ3MvYnVzL252aWRpYSx0ZWdyYTIwLWdtaS50eHQgfCAxMzINCj4g
KysrKysrKysrKysrDQo+IMKgYXJjaC9hcm0vYm9vdC9kdHMvdGVncmEyMC5kdHNpwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfMKgwqAxMyArKw0KPiDCoGFyY2gvYXJt
L2Jvb3QvZHRzL3RlZ3JhMzAuZHRzacKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoHzCoMKgMTIgKysNCj4gwqBkcml2ZXJzL2J1cy9LY29uZmlnwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHzCoMKgwqA4
ICsNCj4gwqBkcml2ZXJzL2J1cy9NYWtlZmlsZcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfMKgwqDCoDEgKw0KPiDCoGRyaXZlcnMv
YnVzL3RlZ3JhLWdtaS5jwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqB8IDIzMQ0KPiArKysrKysrKysrKysrKysrKysrKysNCj4gwqBkcml2ZXJz
L2Nsay90ZWdyYS9jbGstdGVncmEyMC5jwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoHzCoMKgwqAxICsNCj4gwqBkcml2ZXJzL2Nsay90ZWdyYS9jbGstdGVncmEzMC5jwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHzCoMKgwqAxICsNCj4gwqA4IGZp
bGVzIGNoYW5nZWQsIDM5OSBpbnNlcnRpb25zKCspDQo+IMKgY3JlYXRlIG1vZGUgMTAwNjQ0DQo+
IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9idXMvbnZpZGlhLHRlZ3JhMjAtZ21p
LnR4dA0KPiDCoGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2J1cy90ZWdyYS1nbWkuYw0KPiAN
Cj4gLS0NCj4gMi4xLjQNCj4gDQo+IC0tDQo+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0
OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC1jbGsiDQo+IGluDQo+IHRoZSBib2R5
IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnDQo+IE1vcmUgbWFqb3Jk
b21vIGluZm8gYXTCoMKgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1s
DQoNCkNoZWVycw0KDQpNYXJjZWwNCg==
WARNING: multiple messages have this Message-ID (diff)
From: Marcel Ziswiler <marcel.ziswiler-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
To: "jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org"
<jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"mirza.krak-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<mirza.krak-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org"
<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org"
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org"
<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org"
<linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"mark.rutland-5wv7dgnIgG8@public.gmane.org"
<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org"
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org"
<sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 0/6] Add support for Tegra GMI bus controller
Date: Tue, 30 Aug 2016 15:01:37 +0000 [thread overview]
Message-ID: <1472569295.5703.20.camel@toradex.com> (raw)
In-Reply-To: <1472045838-22628-1-git-send-email-mirza.krak-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Mirza
Sorry, I long since wanted to give you some feedback on this as well.
BTW: Thank you very much for taking this on!
On Wed, 2016-08-24 at 15:37 +0200, Mirza Krak wrote:
> From: Mirza Krak <mirza.krak@gmail.com>
>
> Hi.
>
> This is a follow up to my previous RFC to add support for Tegra GMI
> bus
> controller.
>
> I have tested this series on a Tegra30 using a Colibri T30 SOM on a
> custom
> carrier board which has multiple CAN controllers (SJA1000) connected
> to the
> GMI bus.
We once did a nice GMI-Memory Board which mates with the extension
connector X3 of our V3.x Colibri Evaluation boards and allows testing
SRAM access not only in muxed but also in non-muxed mode albeit 16-bit
only. I took your driver for a spin both on Colibri T20 as well as
Colibri T30 both in muxed as well as non-muxed mode and it passed all
tests being both manual devmem2 type reads/writes as well as memtester
runs on the full 128K SRAM giving it the physical address using the -p
argument.
So you may add the following to the whole series:
Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Tested-on: Colibri T20/T30 on EvalBoard V3.x and GMI-Memory Board
I will leave further comments on the individual patches.
BTW: Of course for non-muxed mode I also had to adjust the pin muxing
as they default to muxed.
> I have rebased on top of latest tegra/for-next in V2. Also see
> individual
> patches for changes in V2.
>
> See below links for previous discussions.
>
> Comments on RFC:
> https://marc.info/?l=linux-clk&m=146893557629903&w=2
> https://marc.info/?l=linux-tegra&m=146893541829801&w=2
> https://marc.info/?l=linux-tegra&m=146893542429814&w=2
>
> Comments on V1:
> https://marc.info/?l=linux-arm-kernel&m=147051551821122&w=2
> https://marc.info/?l=linux-arm-kernel&m=147051553121150&w=2
> https://marc.info/?l=linux-arm-kernel&m=147194856600627&w=2
> https://marc.info/?l=linux-arm-kernel&m=147072742432211&w=2
>
>
> Mirza Krak (6):
> clk: tegra: add TEGRA20_CLK_NOR to init table
> clk: tegra: add TEGRA30_CLK_NOR to init table
> dt/bindings: Add bindings for Tegra GMI controller
> ARM: tegra: Add Tegra30 GMI support
> ARM: tegra: Add Tegra20 GMI support
> bus: Add support for Tegra Generic Memory Interface
>
> .../devicetree/bindings/bus/nvidia,tegra20-gmi.txt | 132
> ++++++++++++
> arch/arm/boot/dts/tegra20.dtsi | 13 ++
> arch/arm/boot/dts/tegra30.dtsi | 12 ++
> drivers/bus/Kconfig | 8 +
> drivers/bus/Makefile | 1 +
> drivers/bus/tegra-gmi.c | 231
> +++++++++++++++++++++
> drivers/clk/tegra/clk-tegra20.c | 1 +
> drivers/clk/tegra/clk-tegra30.c | 1 +
> 8 files changed, 399 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/bus/nvidia,tegra20-gmi.txt
> create mode 100644 drivers/bus/tegra-gmi.c
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-clk"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers
Marcel
WARNING: multiple messages have this Message-ID (diff)
From: marcel.ziswiler@toradex.com (Marcel Ziswiler)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/6] Add support for Tegra GMI bus controller
Date: Tue, 30 Aug 2016 15:01:37 +0000 [thread overview]
Message-ID: <1472569295.5703.20.camel@toradex.com> (raw)
In-Reply-To: <1472045838-22628-1-git-send-email-mirza.krak@gmail.com>
Hi Mirza
Sorry, I long since wanted to give you some feedback on this as well.
BTW: Thank you very much for taking this on!
On Wed, 2016-08-24 at 15:37 +0200, Mirza Krak wrote:
> From: Mirza Krak <mirza.krak@gmail.com>
>
> Hi.
>
> This is a follow up to my previous RFC to add support for Tegra GMI
> bus
> controller.
>
> I have tested this series on a Tegra30 using a Colibri T30 SOM on a
> custom
> carrier board which has multiple CAN controllers (SJA1000) connected
> to the
> GMI bus.
We once did a nice GMI-Memory Board which mates with the extension
connector X3 of our V3.x Colibri Evaluation boards and allows testing
SRAM access not only in muxed but also in non-muxed mode albeit 16-bit
only. I took your driver for a spin both on Colibri T20 as well as
Colibri T30 both in muxed as well as non-muxed mode and it passed all
tests being both manual devmem2 type reads/writes as well as memtester
runs on the full 128K SRAM giving it the physical address using the -p
argument.
So you may add the following to the whole series:
Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Tested-on: Colibri T20/T30 on EvalBoard V3.x and GMI-Memory Board
I will leave further comments on the individual patches.
BTW: Of course for non-muxed mode I also had to adjust the pin muxing
as they default to muxed.
> I have rebased on top of latest tegra/for-next in V2. Also see
> individual
> patches for changes in V2.
>
> See below links for previous discussions.
>
> Comments on RFC:
> https://marc.info/?l=linux-clk&m=146893557629903&w=2
> https://marc.info/?l=linux-tegra&m=146893541829801&w=2
> https://marc.info/?l=linux-tegra&m=146893542429814&w=2
>
> Comments on V1:
> https://marc.info/?l=linux-arm-kernel&m=147051551821122&w=2
> https://marc.info/?l=linux-arm-kernel&m=147051553121150&w=2
> https://marc.info/?l=linux-arm-kernel&m=147194856600627&w=2
> https://marc.info/?l=linux-arm-kernel&m=147072742432211&w=2
>
>
> Mirza Krak (6):
> ? clk: tegra: add TEGRA20_CLK_NOR to init table
> ? clk: tegra: add TEGRA30_CLK_NOR to init table
> ? dt/bindings: Add bindings for Tegra GMI controller
> ? ARM: tegra: Add Tegra30 GMI support
> ? ARM: tegra: Add Tegra20 GMI support
> ? bus: Add support for Tegra Generic Memory Interface
>
> ?.../devicetree/bindings/bus/nvidia,tegra20-gmi.txt | 132
> ++++++++++++
> ?arch/arm/boot/dts/tegra20.dtsi?????????????????????|??13 ++
> ?arch/arm/boot/dts/tegra30.dtsi?????????????????????|??12 ++
> ?drivers/bus/Kconfig????????????????????????????????|???8 +
> ?drivers/bus/Makefile???????????????????????????????|???1 +
> ?drivers/bus/tegra-gmi.c????????????????????????????| 231
> +++++++++++++++++++++
> ?drivers/clk/tegra/clk-tegra20.c????????????????????|???1 +
> ?drivers/clk/tegra/clk-tegra30.c????????????????????|???1 +
> ?8 files changed, 399 insertions(+)
> ?create mode 100644
> Documentation/devicetree/bindings/bus/nvidia,tegra20-gmi.txt
> ?create mode 100644 drivers/bus/tegra-gmi.c
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-clk"
> in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at??http://vger.kernel.org/majordomo-info.html
Cheers
Marcel
WARNING: multiple messages have this Message-ID (diff)
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: "jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"mirza.krak@gmail.com" <mirza.krak@gmail.com>,
"swarren@wwwdotorg.org" <swarren@wwwdotorg.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"pgaikwad@nvidia.com" <pgaikwad@nvidia.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"gnurou@gmail.com" <gnurou@gmail.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"pdeschrijver@nvidia.com" <pdeschrijver@nvidia.com>,
"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v2 0/6] Add support for Tegra GMI bus controller
Date: Tue, 30 Aug 2016 15:01:37 +0000 [thread overview]
Message-ID: <1472569295.5703.20.camel@toradex.com> (raw)
In-Reply-To: <1472045838-22628-1-git-send-email-mirza.krak@gmail.com>
Hi Mirza
Sorry, I long since wanted to give you some feedback on this as well.
BTW: Thank you very much for taking this on!
On Wed, 2016-08-24 at 15:37 +0200, Mirza Krak wrote:
> From: Mirza Krak <mirza.krak@gmail.com>
>
> Hi.
>
> This is a follow up to my previous RFC to add support for Tegra GMI
> bus
> controller.
>
> I have tested this series on a Tegra30 using a Colibri T30 SOM on a
> custom
> carrier board which has multiple CAN controllers (SJA1000) connected
> to the
> GMI bus.
We once did a nice GMI-Memory Board which mates with the extension
connector X3 of our V3.x Colibri Evaluation boards and allows testing
SRAM access not only in muxed but also in non-muxed mode albeit 16-bit
only. I took your driver for a spin both on Colibri T20 as well as
Colibri T30 both in muxed as well as non-muxed mode and it passed all
tests being both manual devmem2 type reads/writes as well as memtester
runs on the full 128K SRAM giving it the physical address using the -p
argument.
So you may add the following to the whole series:
Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Tested-on: Colibri T20/T30 on EvalBoard V3.x and GMI-Memory Board
I will leave further comments on the individual patches.
BTW: Of course for non-muxed mode I also had to adjust the pin muxing
as they default to muxed.
> I have rebased on top of latest tegra/for-next in V2. Also see
> individual
> patches for changes in V2.
>
> See below links for previous discussions.
>
> Comments on RFC:
> https://marc.info/?l=linux-clk&m=146893557629903&w=2
> https://marc.info/?l=linux-tegra&m=146893541829801&w=2
> https://marc.info/?l=linux-tegra&m=146893542429814&w=2
>
> Comments on V1:
> https://marc.info/?l=linux-arm-kernel&m=147051551821122&w=2
> https://marc.info/?l=linux-arm-kernel&m=147051553121150&w=2
> https://marc.info/?l=linux-arm-kernel&m=147194856600627&w=2
> https://marc.info/?l=linux-arm-kernel&m=147072742432211&w=2
>
>
> Mirza Krak (6):
> clk: tegra: add TEGRA20_CLK_NOR to init table
> clk: tegra: add TEGRA30_CLK_NOR to init table
> dt/bindings: Add bindings for Tegra GMI controller
> ARM: tegra: Add Tegra30 GMI support
> ARM: tegra: Add Tegra20 GMI support
> bus: Add support for Tegra Generic Memory Interface
>
> .../devicetree/bindings/bus/nvidia,tegra20-gmi.txt | 132
> ++++++++++++
> arch/arm/boot/dts/tegra20.dtsi | 13 ++
> arch/arm/boot/dts/tegra30.dtsi | 12 ++
> drivers/bus/Kconfig | 8 +
> drivers/bus/Makefile | 1 +
> drivers/bus/tegra-gmi.c | 231
> +++++++++++++++++++++
> drivers/clk/tegra/clk-tegra20.c | 1 +
> drivers/clk/tegra/clk-tegra30.c | 1 +
> 8 files changed, 399 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/bus/nvidia,tegra20-gmi.txt
> create mode 100644 drivers/bus/tegra-gmi.c
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-clk"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers
Marcel
next prev parent reply other threads:[~2016-08-30 15:01 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 13:37 [PATCH v2 0/6] Add support for Tegra GMI bus controller Mirza Krak
2016-08-24 13:37 ` Mirza Krak
2016-08-24 13:37 ` [PATCH v2 1/6] clk: tegra: add TEGRA20_CLK_NOR to init table Mirza Krak
2016-08-24 13:37 ` Mirza Krak
2016-08-24 13:37 ` Mirza Krak
2016-08-24 13:37 ` [PATCH v2 2/6] clk: tegra: add TEGRA30_CLK_NOR " Mirza Krak
2016-08-24 13:37 ` Mirza Krak
2016-08-24 13:37 ` Mirza Krak
2016-08-24 13:37 ` [PATCH v2 3/6] dt/bindings: Add bindings for Tegra GMI controller Mirza Krak
2016-08-24 13:37 ` Mirza Krak
2016-08-24 15:56 ` Jon Hunter
2016-08-24 15:56 ` Jon Hunter
2016-08-24 15:56 ` Jon Hunter
2016-08-24 19:54 ` Mirza Krak
2016-08-24 19:54 ` Mirza Krak
2016-08-24 19:54 ` Mirza Krak
2016-08-26 4:53 ` Mirza Krak
2016-08-26 4:53 ` Mirza Krak
2016-08-26 4:53 ` Mirza Krak
2016-08-26 7:25 ` Jon Hunter
2016-08-26 7:25 ` Jon Hunter
2016-08-26 7:25 ` Jon Hunter
2016-08-29 7:38 ` Mirza Krak
2016-08-29 7:38 ` Mirza Krak
2016-08-30 17:06 ` Rob Herring
2016-08-30 17:06 ` Rob Herring
2016-08-30 17:06 ` Rob Herring
2016-08-31 11:22 ` Mirza Krak
2016-08-31 11:22 ` Mirza Krak
2016-08-31 11:22 ` Mirza Krak
2016-09-06 10:32 ` Jon Hunter
2016-09-06 10:32 ` Jon Hunter
2016-09-06 10:32 ` Jon Hunter
2016-09-19 7:21 ` Mirza Krak
2016-09-19 7:21 ` Mirza Krak
2016-09-19 7:21 ` Mirza Krak
2016-09-30 8:02 ` Jon Hunter
2016-09-30 8:02 ` Jon Hunter
2016-09-30 8:02 ` Jon Hunter
2016-09-06 10:35 ` Jon Hunter
2016-09-06 10:35 ` Jon Hunter
2016-09-06 10:35 ` Jon Hunter
2016-08-30 15:02 ` Marcel Ziswiler
2016-08-30 15:02 ` Marcel Ziswiler
2016-08-30 15:02 ` Marcel Ziswiler
2016-08-30 15:02 ` Marcel Ziswiler
2016-08-31 9:24 ` Mirza Krak
2016-08-31 9:24 ` Mirza Krak
2016-08-31 9:24 ` Mirza Krak
2016-08-24 13:37 ` [PATCH v2 4/6] ARM: tegra: Add Tegra30 GMI support Mirza Krak
2016-08-24 13:37 ` Mirza Krak
2016-08-24 13:37 ` Mirza Krak
2016-08-24 13:37 ` [PATCH v2 5/6] ARM: tegra: Add Tegra20 " Mirza Krak
2016-08-24 13:37 ` Mirza Krak
2016-08-24 13:37 ` Mirza Krak
2016-08-24 13:37 ` [PATCH v2 6/6] bus: Add support for Tegra Generic Memory Interface Mirza Krak
2016-08-24 13:37 ` Mirza Krak
2016-08-24 13:37 ` Mirza Krak
2016-08-26 8:21 ` Jon Hunter
2016-08-26 8:21 ` Jon Hunter
2016-08-26 8:21 ` Jon Hunter
2016-08-30 15:01 ` Marcel Ziswiler [this message]
2016-08-30 15:01 ` [PATCH v2 0/6] Add support for Tegra GMI bus controller Marcel Ziswiler
2016-08-30 15:01 ` Marcel Ziswiler
2016-08-30 15:01 ` Marcel Ziswiler
2016-08-31 9:23 ` Mirza Krak
2016-08-31 9:23 ` Mirza Krak
2016-08-31 9:23 ` Mirza Krak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472569295.5703.20.camel@toradex.com \
--to=marcel.ziswiler@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mirza.krak@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.