From: Arnd Bergmann <arnd@arndb.de>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Roger Quadros <rogerq@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] mtd: omap_elm: print interrupt resource using %pr
Date: Sat, 12 Dec 2015 15:41:31 +0100 [thread overview]
Message-ID: <1472979.NmboBT3Vms@wuerfel> (raw)
In-Reply-To: <20151212011056.GA144873@google.com>
On Friday 11 December 2015 17:10:56 Brian Norris wrote:
> Hi Arnd,
>
> On Tue, Dec 08, 2015 at 04:39:45PM +0100, Arnd Bergmann wrote:
> > When CONFIG_LPAE is set on ARM, resource_size_t is 64-bit wide
> > and we get a warning about an incorrect format string for printing
> > the interrupt number in elm_probe:
> >
> > drivers/mtd/nand/omap_elm.c: In function 'elm_probe':
> > drivers/mtd/nand/omap_elm.c:417:23: warning: format '%i' expects argument of type 'int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
> >
> > This patch avoids the type mismatch by printing the interrupt as
> > a resource using the %pr format string.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/mtd/nand/omap_elm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/nand/omap_elm.c b/drivers/mtd/nand/omap_elm.c
> > index 235ec7992b4c..11f174b07217 100644
> > --- a/drivers/mtd/nand/omap_elm.c
> > +++ b/drivers/mtd/nand/omap_elm.c
> > @@ -414,7 +414,7 @@ static int elm_probe(struct platform_device *pdev)
> > ret = devm_request_irq(&pdev->dev, irq->start, elm_isr, 0,
> > pdev->name, info);
> > if (ret) {
> > - dev_err(&pdev->dev, "failure requesting irq %i\n", irq->start);
> > + dev_err(&pdev->dev, "failure requesting %pr\n", &irq);
>
> drivers/mtd/nand/omap_elm.c:417 elm_probe() error: '%pr' expects argument of type struct resource *, but argument 3 has type 'struct resource**' [smatch]
Ah, good catch. Do you want to fix it up yourself, or should I send a new version?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: omap_elm: print interrupt resource using %pr
Date: Sat, 12 Dec 2015 15:41:31 +0100 [thread overview]
Message-ID: <1472979.NmboBT3Vms@wuerfel> (raw)
In-Reply-To: <20151212011056.GA144873@google.com>
On Friday 11 December 2015 17:10:56 Brian Norris wrote:
> Hi Arnd,
>
> On Tue, Dec 08, 2015 at 04:39:45PM +0100, Arnd Bergmann wrote:
> > When CONFIG_LPAE is set on ARM, resource_size_t is 64-bit wide
> > and we get a warning about an incorrect format string for printing
> > the interrupt number in elm_probe:
> >
> > drivers/mtd/nand/omap_elm.c: In function 'elm_probe':
> > drivers/mtd/nand/omap_elm.c:417:23: warning: format '%i' expects argument of type 'int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
> >
> > This patch avoids the type mismatch by printing the interrupt as
> > a resource using the %pr format string.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/mtd/nand/omap_elm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/nand/omap_elm.c b/drivers/mtd/nand/omap_elm.c
> > index 235ec7992b4c..11f174b07217 100644
> > --- a/drivers/mtd/nand/omap_elm.c
> > +++ b/drivers/mtd/nand/omap_elm.c
> > @@ -414,7 +414,7 @@ static int elm_probe(struct platform_device *pdev)
> > ret = devm_request_irq(&pdev->dev, irq->start, elm_isr, 0,
> > pdev->name, info);
> > if (ret) {
> > - dev_err(&pdev->dev, "failure requesting irq %i\n", irq->start);
> > + dev_err(&pdev->dev, "failure requesting %pr\n", &irq);
>
> drivers/mtd/nand/omap_elm.c:417 elm_probe() error: '%pr' expects argument of type struct resource *, but argument 3 has type 'struct resource**' [smatch]
Ah, good catch. Do you want to fix it up yourself, or should I send a new version?
Arnd
next prev parent reply other threads:[~2015-12-12 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 15:39 [PATCH] mtd: omap_elm: print interrupt resource using %pr Arnd Bergmann
2015-12-08 15:39 ` Arnd Bergmann
2015-12-12 1:10 ` Brian Norris
2015-12-12 1:10 ` Brian Norris
2015-12-12 14:41 ` Arnd Bergmann [this message]
2015-12-12 14:41 ` Arnd Bergmann
2015-12-14 18:31 ` Brian Norris
2015-12-14 18:31 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472979.NmboBT3Vms@wuerfel \
--to=arnd@arndb.de \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.