Re: [PATCH] valgrind: MIPS: Make toolchain basename generic

["André Draszik" <git@andred.net>]

On Do, 2016-09-08 at 14:14 +0100, Zubair Lutfullah Kakakhel wrote:
> For the hard float case, COMPATIBLE_HOST should be set to ".*-linux"
> since OE can support multiple distro layers, not just poky.
> 
> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
> 
> ---
> Pointed out by Andre McCurdy but patch v1 had already been accepted
> and applied.
> ---
>  meta/recipes-devtools/valgrind/valgrind_3.11.0.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> index 3d49131..42fd27f 100644
> --- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> +++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> @@ -39,8 +39,8 @@ COMPATIBLE_HOST_armv5 = 'null'
>  COMPATIBLE_HOST_armv6 = 'null'
>  
>  # valgrind doesn't like mips soft float
> -COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft",
> "null", "mips-poky-linux", d)}"
> -COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft",
> "null", "mipsel-poky-linux", d)}"
> +COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft",
> "null", ".*-linux", d)}"
> +COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft",
> "null", ".*-linux", d)}"

Can it not just be set to mips or mipsel? Why .*-linux?

COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mips", d)}"
COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mipsel", d)}"

Cheers,
Andre'