All of lore.kernel.org
 help / color / mirror / Atom feed
From: akuster808 <akuster808@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] valgrind: MIPS: Make toolchain basename generic
Date: Thu, 8 Sep 2016 08:45:48 -0700	[thread overview]
Message-ID: <e0f721cd-96d5-e3a5-b060-83bb467d1784@gmail.com> (raw)
In-Reply-To: <1473340457-31797-1-git-send-email-Zubair.Kakakhel@imgtec.com>



On 09/08/2016 06:14 AM, Zubair Lutfullah Kakakhel wrote:
> For the hard float case, COMPATIBLE_HOST should be set to ".*-linux"
> since OE can support multiple distro layers, not just poky.
>
> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>

is this good for Krogoth too? it has the same version.

- armin
>
> ---
> Pointed out by Andre McCurdy but patch v1 had already been accepted
> and applied.
> ---
>   meta/recipes-devtools/valgrind/valgrind_3.11.0.bb | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> index 3d49131..42fd27f 100644
> --- a/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> +++ b/meta/recipes-devtools/valgrind/valgrind_3.11.0.bb
> @@ -39,8 +39,8 @@ COMPATIBLE_HOST_armv5 = 'null'
>   COMPATIBLE_HOST_armv6 = 'null'
>   
>   # valgrind doesn't like mips soft float
> -COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mips-poky-linux", d)}"
> -COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft", "null", "mipsel-poky-linux", d)}"
> +COMPATIBLE_HOST_mips = "${@bb.utils.contains("TARGET_FPU", "soft", "null", ".*-linux", d)}"
> +COMPATIBLE_HOST_mipsel = "${@bb.utils.contains("TARGET_FPU", "soft", "null", ".*-linux", d)}"
>   
>   inherit autotools ptest
>   



  parent reply	other threads:[~2016-09-08 15:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08 13:14 [PATCH] valgrind: MIPS: Make toolchain basename generic Zubair Lutfullah Kakakhel
2016-09-08 15:45 ` André Draszik
2016-09-08 23:29   ` Andre McCurdy
2016-09-08 15:45 ` akuster808 [this message]
2016-09-12 15:04   ` Zubair Lutfullah Kakakhel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0f721cd-96d5-e3a5-b060-83bb467d1784@gmail.com \
    --to=akuster808@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.